revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Improve the handling of the php_compat_info.json file.

Browse source 
Summary: See inline comments on D9576. Also replace `json_decode` with `phutil_json_decode`, for better error handling.

Test Plan: Make sure `arc unit` still works.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9656
This commit is contained in:
Joshua Spence 2014-06-23 01:56:44 +10:00
parent b9b9c138fe
commit 990027e3e0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -394,7 +394,7 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$target = phutil_get_library_root('arcanist'). $target = phutil_get_library_root('arcanist').
'/../resources/php_compat_info.json'; '/../resources/php_compat_info.json';
$compat_info = json_decode(file_get_contents($target), true); $compat_info = phutil_json_decode(Filesystem::readFile($target));
$calls = $root->selectDescendantsOfType('n_FUNCTION_CALL'); $calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
foreach ($calls as $call) { foreach ($calls as $call) {