revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Change visibility of some linter methods

Browse source 
Summary: Change the visibility of the `raiseLintAtSomething` methods, mainly to allow linter rules to raise linter messages (see D10541).

Test Plan: `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12976
This commit is contained in:
Joshua Spence 2015-05-24 07:45:01 +10:00
parent 6f86866104
commit 9b7c6786cd
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lint/linter/ArcanistBaseXHPASTLinter.php
View file

@ -23,7 +23,7 @@ abstract class ArcanistBaseXHPASTLinter extends ArcanistFutureLinter {
return implode('-', $parts);
}
final protected function raiseLintAtToken(
final public function raiseLintAtToken(
XHPASTToken $token,
$code,
$desc,
@ -36,7 +36,7 @@ abstract class ArcanistBaseXHPASTLinter extends ArcanistFutureLinter {
$replace);
}
final protected function raiseLintAtNode(
final public function raiseLintAtNode(
XHPASTNode $node,
$code,
$desc,

6
src/lint/linter/ArcanistLinter.php
View file

@ -416,7 +416,7 @@ abstract class ArcanistLinter {
return $this->messages;
}
final protected function raiseLintAtLine(
final public function raiseLintAtLine(
$line,
$char,
$code,
@ -438,11 +438,11 @@ abstract class ArcanistLinter {
return $this->addLintMessage($message);
}
final protected function raiseLintAtPath($code, $desc) {
final public function raiseLintAtPath($code, $desc) {
return $this->raiseLintAtLine(null, null, $code, $desc, null, null);
}
final protected function raiseLintAtOffset(
final public function raiseLintAtOffset(
$offset,
$code,
$desc,