revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Export namespace in ArcanistUnitTestResult dictionary

Browse source 
Summary: D7952 added namespaces to `ArcanistUnitTestResult` but these are not exported and thus don't get sent from client to server.

Test Plan: Uploaded a diff and inspected the contents of the `phabricator_differential.differential_diffproperty` table.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11208
This commit is contained in:
Joshua Spence 2015-01-05 06:48:32 +11:00
parent 4fe5243d81
commit 9e6f876a68
2 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/unit/ArcanistUnitTestResult.php
View file

@ -122,6 +122,7 @@ final class ArcanistUnitTestResult {
public function toDictionary() { public function toDictionary() {
return array( return array(
'namespace' => $this->getNamespace(),
'name' => $this->getName(), 'name' => $this->getName(),
'link' => $this->getLink(), 'link' => $this->getLink(),
'result' => $this->getResult(), 'result' => $this->getResult(),

9
src/workflow/ArcanistDiffWorkflow.php
View file

@ -1333,14 +1333,7 @@ EOTEXT
$this->testResults = array(); $this->testResults = array();
foreach ($unit_workflow->getTestResults() as $test) { foreach ($unit_workflow->getTestResults() as $test) {
$this->testResults[] = array( $this->testResults[] = $test->toDictionary();
'name' => $test->getName(),
'link' => $test->getLink(),
'result' => $test->getResult(),
'userdata' => $test->getUserData(),
'coverage' => $test->getCoverage(),
'extra' => $test->getExtraData(),
);
} }
return $unit_result; return $unit_result;