revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity

Prevent double rendering of unit test results

Browse source 
Summary: D14037 had the logic slightly wrong and unit test results are now being double rendered.

Test Plan: Ran a unit test with `arc unit -- path/to/test` and saw the results rendered only once.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14495
This commit is contained in:
Joshua Spence 2015-11-18 07:19:40 +11:00
parent b25cf080bc
commit a4dba24c46
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php
View file

@ -148,7 +148,9 @@ final class ArcanistConfigurationDrivenUnitTestEngine
$all_results[] = $results; $all_results[] = $results;
foreach ($results as $result) { foreach ($results as $result) {
if ($engine->shouldEchoTestResults()) { // If the proxied engine renders its own test results then there
// is no need to render them again here.
if (!$engine->shouldEchoTestResults()) {
echo $renderer->renderUnitResult($result); echo $renderer->renderUnitResult($result);
} }
} }