mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-26 00:32:41 +01:00
Prevent double rendering of unit test results
Summary: D14037 had the logic slightly wrong and unit test results are now being double rendered. Test Plan: Ran a unit test with `arc unit -- path/to/test` and saw the results rendered only once. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14495
This commit is contained in:
parent
b25cf080bc
commit
a4dba24c46
1 changed files with 3 additions and 1 deletions
|
@ -148,7 +148,9 @@ final class ArcanistConfigurationDrivenUnitTestEngine
|
|||
$all_results[] = $results;
|
||||
|
||||
foreach ($results as $result) {
|
||||
if ($engine->shouldEchoTestResults()) {
|
||||
// If the proxied engine renders its own test results then there
|
||||
// is no need to render them again here.
|
||||
if (!$engine->shouldEchoTestResults()) {
|
||||
echo $renderer->renderUnitResult($result);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue