revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Setting default minimumSeverity to zero from null

Browse source 
Summary:
In hphp's version of idx, it uses debug_rlog() which is not
available in phabricator's code. It will be executed if null is passed
as the second value to idx.

Test Plan:
ran arc lint which still report error message, and php
./scripts/arcanist.php unit src/lint/linter/xhpast/__test__ doesn't
throw.

Reviewed By: epriestley
Reviewers: tuomaspelkonen, epriestley
CC: aran, jungejason, epriestley
Differential Revision: 666
This commit is contained in:
Jason Ge 2011-07-13 16:33:18 -07:00
parent 2d50e08ee6
commit b3a9ee3d84
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/engine/base/ArcanistLintEngine.php
View file

@ -65,7 +65,7 @@ abstract class ArcanistLintEngine {
protected $charToLine = array(); protected $charToLine = array();
protected $lineToFirstChar = array(); protected $lineToFirstChar = array();
private $results = array(); private $results = array();
private $minimumSeverity = null; private $minimumSeverity = ArcanistLintSeverity::SEVERITY_DISABLED;
private $changedLines = array(); private $changedLines = array();
private $commitHookMode = false; private $commitHookMode = false;