Use the ArcanistConfigurationDrivenLintEngine as a linting engine.

Summary: Ref T2039. The `.arclint` file is reasonably complete now and we should start using it if possible, since we are trying to recommend it to others.

Test Plan: `arc lint`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T2039

Differential Revision: https://secure.phabricator.com/D9057

.arcconfig

@@ -1,7 +1,6 @@
 {
   "project.name" : "arcanist",
   "phabricator.uri" : "https://secure.phabricator.com/",
-  "lint.engine" : "PhutilLintEngine",
   "unit.engine" : "PhutilUnitTestEngine",
   "load" : [
     "src/"

.arclint

@@ -0,0 +1,41 @@
+{
+  "exclude": [
+    "(^externals/)",
+    "(\\.lint-test$)"
+  ],
+  "linters": {
+    "filename": {
+      "type": "filename"
+    },
+    "generated": {
+      "type": "generated"
+    },
+    "merge-conflict": {
+      "type": "merge-conflict"
+    },
+    "nolint": {
+      "type": "nolint"
+    },
+    "phutil-xhpast": {
+      "type": "phutil-xhpast",
+      "include": "(\\.php$)"
+    },
+    "text": {
+      "type": "text"
+    },
+    "spelling": {
+      "type": "spelling"
+    },
+    "xhpast": {
+      "type": "xhpast",
+      "include": "(\\.php$)",
+      "severity": {
+        "16": "advice",
+        "29": "warning",
+        "31": "error",
+        "34": "error",
+        "35": "error"
+      }
+    }
+  }
+}

src/lint/linter/ArcanistPhutilXHPASTLinter.php

@@ -46,6 +46,10 @@ final class ArcanistPhutilXHPASTLinter extends ArcanistBaseXHPASTLinter {
     return 'PHLXHP';
   }
 
+  public function getLinterConfigurationName() {
+    return 'phutil-xhpast';
+  }
+
   public function getCacheVersion() {
     $version = '2';
     $path = xhpast_get_binary_path();

src/lint/linter/ArcanistXHPASTLinter.php

@@ -91,6 +91,10 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
     return 'XHP';
   }
 
+  public function getLinterConfigurationName() {
+    return 'xhpast';
+  }
+
   public function getLintSeverityMap() {
     $disabled = ArcanistLintSeverity::SEVERITY_DISABLED;
     $advice   = ArcanistLintSeverity::SEVERITY_ADVICE;