1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-24 15:52:40 +01:00

Use the ArcanistConfigurationDrivenLintEngine as a linting engine.

Summary: Ref T2039. The `.arclint` file is reasonably complete now and we should start using it if possible, since we are trying to recommend it to others.

Test Plan: `arc lint`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T2039

Differential Revision: https://secure.phabricator.com/D9057
This commit is contained in:
Joshua Spence 2014-05-11 19:33:40 -07:00 committed by epriestley
parent 86cbcb9f56
commit b63828a87e
4 changed files with 49 additions and 1 deletions

View file

@ -1,7 +1,6 @@
{
"project.name" : "arcanist",
"phabricator.uri" : "https://secure.phabricator.com/",
"lint.engine" : "PhutilLintEngine",
"unit.engine" : "PhutilUnitTestEngine",
"load" : [
"src/"

41
.arclint Normal file
View file

@ -0,0 +1,41 @@
{
"exclude": [
"(^externals/)",
"(\\.lint-test$)"
],
"linters": {
"filename": {
"type": "filename"
},
"generated": {
"type": "generated"
},
"merge-conflict": {
"type": "merge-conflict"
},
"nolint": {
"type": "nolint"
},
"phutil-xhpast": {
"type": "phutil-xhpast",
"include": "(\\.php$)"
},
"text": {
"type": "text"
},
"spelling": {
"type": "spelling"
},
"xhpast": {
"type": "xhpast",
"include": "(\\.php$)",
"severity": {
"16": "advice",
"29": "warning",
"31": "error",
"34": "error",
"35": "error"
}
}
}
}

View file

@ -46,6 +46,10 @@ final class ArcanistPhutilXHPASTLinter extends ArcanistBaseXHPASTLinter {
return 'PHLXHP';
}
public function getLinterConfigurationName() {
return 'phutil-xhpast';
}
public function getCacheVersion() {
$version = '2';
$path = xhpast_get_binary_path();

View file

@ -91,6 +91,10 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
return 'XHP';
}
public function getLinterConfigurationName() {
return 'xhpast';
}
public function getLintSeverityMap() {
$disabled = ArcanistLintSeverity::SEVERITY_DISABLED;
$advice = ArcanistLintSeverity::SEVERITY_ADVICE;