revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

Use the raw formatter for coffeelint

Browse source 
Summary: Using `--reporter=raw` exposes raw JSON output rather than a limited XML output. This allows us to pull more context from the `coffeelint` output.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11320
This commit is contained in:
Joshua Spence 2015-01-12 07:22:42 +11:00
parent 23bc9f294c
commit b780ef0868
1 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/lint/linter/ArcanistCoffeeLintLinter.php
View file

@ -57,7 +57,7 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter {
protected function getMandatoryFlags() { protected function getMandatoryFlags() {
$options = array( $options = array(
'--reporter=checkstyle', '--reporter=raw',
); );
if ($this->config) { if ($this->config) {
@ -89,32 +89,29 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter {
} }
protected function parseLinterOutput($path, $err, $stdout, $stderr) { protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$report_dom = new DOMDocument(); $messages = array();
$ok = @$report_dom->loadXML($stdout); $output = phutil_json_decode($stdout);
if (!$ok) { // We are only linting a single file.
if (count($output) != 1) {
return false; return false;
} }
$files = $report_dom->getElementsByTagName('file'); foreach ($output as $reports) {
$messages = array(); foreach ($reports as $report) {
foreach ($files as $file) {
foreach ($file->getElementsByTagName('error') as $error) {
// Column number is not provided in the output. // Column number is not provided in the output.
// See https://github.com/clutchski/coffeelint/issues/87 // See https://github.com/clutchski/coffeelint/issues/87
$message = id(new ArcanistLintMessage()) $message = id(new ArcanistLintMessage())
->setPath($path) ->setPath($path)
->setLine($error->getAttribute('line')) ->setLine($report['lineNumber'])
->setCode($this->getLinterName()) ->setCode($this->getLinterName())
->setDescription(preg_replace( ->setName(ucwords(str_replace('_', ' ', $report['name'])))
'/; context: .*$/', ->setDescription($report['message'])
'.', ->setOriginalText(idx($report, 'line'));
$error->getAttribute('message')));
switch ($error->getAttribute('severity')) { switch ($report['level']) {
case 'warning': case 'warn':
$message->setSeverity(ArcanistLintSeverity::SEVERITY_WARNING); $message->setSeverity(ArcanistLintSeverity::SEVERITY_WARNING);
break; break;
@ -131,6 +128,10 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter {
} }
} }
if ($err && !$messages) {
return false;
}
return $messages; return $messages;
} }