revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity

Fix 'arc lint --everything' when svn has uncommitted changes

Browse source 
Summary: My recent change adding --everything to arc lint could sometimes cause a "diff is empty" error, this patch fixes it.

Test Plan: Ran "arc lint --everything" before and after patch. No longer errors out. Only appeared to originally happen when there were uncommited changes in an svn repo.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6732
This commit is contained in:
Eric Stern 2013-08-12 13:47:33 -07:00 committed by epriestley
parent 857b754c7e
commit c11b9e1af9
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/workflow/ArcanistLintWorkflow.php
View file

@ -222,6 +222,7 @@ EOTEXT
$paths = id(new FileFinder($working_copy->getProjectRoot())) $paths = id(new FileFinder($working_copy->getProjectRoot()))
->excludePath($filter) ->excludePath($filter)
->find(); ->find();
$this->shouldLintAll = true;
} else { } else {
$paths = $this->selectPathsForWorkflow($paths, $rev); $paths = $this->selectPathsForWorkflow($paths, $rev);
} }