revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Add missing image functions to PHP extension functions list

Browse source 
Summary:
Copied from PHP Manual.

Also fix missing cache key for implicitly linted file.

Test Plan:
  phabricator/ $ arc lint src/applications/files/PhabricatorImageTransformer.php # without GD2

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Differential Revision: https://secure.phabricator.com/D5457
This commit is contained in:
Jakub Vrana 2013-03-28 05:04:37 +00:00
parent 50b4f0af65
commit d1027c186c
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
scripts/php_extension_functions.txt
View file

@ -111,6 +111,7 @@ imagecreatefrompng
imagecreatefromstring imagecreatefromstring
imagecreatefromwbmp imagecreatefromwbmp
imagecreatefromxbm imagecreatefromxbm
imagecreatefromxpm
imagecreatetruecolor imagecreatetruecolor
imagedashedline imagedashedline
imagedestroy imagedestroy
@ -124,10 +125,14 @@ imagefilltoborder
imagefilter imagefilter
imagefontheight imagefontheight
imagefontwidth imagefontwidth
imageftbbox
imagefttext
imagegammacorrect imagegammacorrect
imagegd imagegd
imagegd2 imagegd2
imagegif imagegif
imagegrabscreen
imagegrabwindow
imageinterlace imageinterlace
imageistruecolor imageistruecolor
imagejpeg imagejpeg
@ -137,6 +142,13 @@ imageloadfont
imagepalettecopy imagepalettecopy
imagepng imagepng
imagepolygon imagepolygon
imagepsbbox
imagepsencodefont
imagepsextendfont
imagepsfreefont
imagepsloadfont
imagepsslantfont
imagepstext
imagerectangle imagerectangle
imagerotate imagerotate
imagesavealpha imagesavealpha
@ -150,6 +162,8 @@ imagestringup
imagesx imagesx
imagesy imagesy
imagetruecolortopalette imagetruecolortopalette
imagettfbbox
imagettftext
imagetypes imagetypes
imagewbmp imagewbmp
imagexbm imagexbm

5
src/workflow/ArcanistLintWorkflow.php
View file

@ -548,7 +548,10 @@ EOTEXT
$cached_path[] = $message->toDictionary(); $cached_path[] = $message->toDictionary();
} }
} }
$hash = $file_hashes[$abs_path]; $hash = idx($file_hashes, $abs_path);
if (!$hash) {
$hash = md5_file($abs_path);
}
$cached[$path] = array($hash => array($version => $cached_path)); $cached[$path] = array($hash => array($version => $cached_path));
} }
$cache[$this->getCacheKey()] = $cached; $cache[$this->getCacheKey()] = $cached;