revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-24 15:52:40 +01:00
Code Issues Releases Wiki Activity

Add a character marker to the "IMPLICIT COMMITS" warning in "arc land"

Browse source 
Summary:
Ref T13576. The "implicit commits" prompt in "arc land" shows a list of implicit and non-implicit commits.

The implicit commits are marked with a background color, but this doesn't survive if you copy/paste the output into a support ticket.

Make my life easier by also marking commits so the marker survives copy/paste.

Test Plan: Ran "arc land" with implicit commits, saw a copy-pastable indicator.

Maniphest Tasks: T13576

Differential Revision: https://secure.phabricator.com/D21589
This commit is contained in:
epriestley 2021-03-03 13:06:58 -08:00
parent 4399ee6b7f
commit d72fad6461
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/land/engine/ArcanistLandEngine.php
View file

@ -780,13 +780,15 @@ abstract class ArcanistLandEngine
$display_summary = $commit->getDisplaySummary(); $display_summary = $commit->getDisplaySummary();
if ($is_implicit) { if ($is_implicit) {
// NOTE: Mark commits with both a color and a character so the marking
// survives copy/paste.
echo tsprintf( echo tsprintf(
" <bg:yellow> %s </bg> %s\n", " ! <bg:yellow> %s </bg> %s\n",
$display_hash, $display_hash,
$display_summary); $display_summary);
} else { } else {
echo tsprintf( echo tsprintf(
" %s %s\n", " %s %s\n",
$display_hash, $display_hash,
$display_summary); $display_summary);
} }