revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Consolidate redundant "should should" from some linter help strings in Arcanist

Browse source 
Summary: See <https://phabricator.wikimedia.org/T201138>.

Test Plan: Read carefully.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19561
This commit is contained in:
epriestley 2018-08-03 12:57:55 -07:00
parent 875d018360
commit d9a4293ae7
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php
View file

@ -20,7 +20,7 @@ final class ArcanistDeprecationXHPASTLinterRule
'xhpast.deprecated.functions' => array( 'xhpast.deprecated.functions' => array(
'type' => 'optional map<string, string>', 'type' => 'optional map<string, string>',
'help' => pht( 'help' => pht(
'Functions which should should be considered deprecated.'), 'Functions which should be considered deprecated.'),
), ),
); );
} }

6
src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php
View file

@ -21,14 +21,14 @@ final class ArcanistUnsafeDynamicStringXHPASTLinterRule
'xhpast.dynamic-string.classes' => array( 'xhpast.dynamic-string.classes' => array(
'type' => 'optional map<string, string>', 'type' => 'optional map<string, string>',
'help' => pht( 'help' => pht(
'Classes which should should not be used because they represent the '. 'Classes which should not be used because they represent the '.
'unsafe usage of dynamic strings.'), 'unsafe usage of dynamic strings.'),
), ),
'xhpast.dynamic-string.functions' => array( 'xhpast.dynamic-string.functions' => array(
'type' => 'optional map<string, string>', 'type' => 'optional map<string, string>',
'help' => pht( 'help' => pht(
'Functions which should should not be used because they represent '. 'Functions which should not be used because they represent the '.
'the unsafe usage of dynamic strings.'), 'unsafe usage of dynamic strings.'),
), ),
); );