mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 23:02:41 +01:00
[Tests] Only use concrete TestCases
Summary: Don't use abstract subclasses of ArcanistPhutilTestCase, only use concrete ones. This lets you put common functionality in an abstract BaseTestCase (which itself is a subclass of ArcanistPhutilTestCase), then implement concrete subclasses of the BaseTestCase. Test Plan: Tested with a simple Base -> {Case1, Case2} setup. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2300
This commit is contained in:
parent
2831d075c0
commit
dd6ffa4a13
1 changed files with 1 additions and 0 deletions
|
@ -118,6 +118,7 @@ final class PhutilUnitTestEngine extends ArcanistBaseUnitTestEngine {
|
|||
->setLibrary($test['library'])
|
||||
->setModule($test['module'])
|
||||
->setAncestorClass('ArcanistPhutilTestCase')
|
||||
->setConcreteOnly(true)
|
||||
->selectAndLoadSymbols();
|
||||
foreach ($symbols as $symbol) {
|
||||
$run_tests[$symbol['name']] = true;
|
||||
|
|
Loading…
Reference in a new issue