revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity

Various linter fixes

Browse source 
Summary: Self explanatory.

Test Plan: `arc lint`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13861
This commit is contained in:
Joshua Spence 2015-08-11 22:35:40 +10:00
parent 31a4919680
commit e00e2939c1
3 changed files with 89 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/__tests__/ArcanistLinterTestCase.php
View file

@ -65,7 +65,7 @@ abstract class ArcanistLinterTestCase extends PhutilTestCase {
'~~~~~~~~~~')); '~~~~~~~~~~'));
} }
list ($data, $expect, $xform, $config) = array_merge( list($data, $expect, $xform, $config) = array_merge(
$contents, $contents,
array(null, null)); array(null, null));

95
src/parser/ArcanistBundle.php
View file

@ -819,16 +819,91 @@ final class ArcanistBundle extends Phobject {
// additional casting.) // additional casting.)
static $map = array( static $map = array(
'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0',
'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', '1',
'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', '2',
'U', 'V', 'W', 'X', 'Y', 'Z', '3',
'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', '4',
'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', '5',
'u', 'v', 'w', 'x', 'y', 'z', '6',
'!', '#', '$', '%', '&', '(', ')', '*', '+', '-', '7',
';', '<', '=', '>', '?', '@', '^', '_', '`', '{', '8',
'|', '}', '~', '9',
'A',
'B',
'C',
'D',
'E',
'F',
'G',
'H',
'I',
'J',
'K',
'L',
'M',
'N',
'O',
'P',
'Q',
'R',
'S',
'T',
'U',
'V',
'W',
'X',
'Y',
'Z',
'a',
'b',
'c',
'd',
'e',
'f',
'g',
'h',
'i',
'j',
'k',
'l',
'm',
'n',
'o',
'p',
'q',
'r',
's',
't',
'u',
'v',
'w',
'x',
'y',
'z',
'!',
'#',
'$',
'%',
'&',
'(',
')',
'*',
'+',
'-',
';',
'<',
'=',
'>',
'?',
'@',
'^',
'_',
'`',
'{',
'|',
'}',
'~',
); );
$buf = ''; $buf = '';

6
src/repository/api/ArcanistMercurialAPI.php
View file

@ -250,7 +250,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
list($node, $rev, $full_author, $date, $branch, $tag, list($node, $rev, $full_author, $date, $branch, $tag,
$parents, $desc) = explode("\1", $log, 9); $parents, $desc) = explode("\1", $log, 9);
list ($author, $author_email) = $this->parseFullAuthor($full_author); list($author, $author_email) = $this->parseFullAuthor($full_author);
// NOTE: If a commit has only one parent, {parents} returns empty. // NOTE: If a commit has only one parent, {parents} returns empty.
// If it has two parents, {parents} returns revs and short hashes, not // If it has two parents, {parents} returns revs and short hashes, not
@ -535,7 +535,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
public function supportsRebase() { public function supportsRebase() {
if ($this->supportsRebase === null) { if ($this->supportsRebase === null) {
list ($err) = $this->execManualLocal('help rebase'); list($err) = $this->execManualLocal('help rebase');
$this->supportsRebase = $err === 0; $this->supportsRebase = $err === 0;
} }
@ -544,7 +544,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
public function supportsPhases() { public function supportsPhases() {
if ($this->supportsPhases === null) { if ($this->supportsPhases === null) {
list ($err) = $this->execManualLocal('help phase'); list($err) = $this->execManualLocal('help phase');
$this->supportsPhases = $err === 0; $this->supportsPhases = $err === 0;
} }