revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Run 'mark-committed' from 'arc land'

Browse source 
Summary:
  - Remove "new and experimental" because arc land is super awesome and great.
  - Run the 'mark-committed' finalize workflow after pushing for untracked repo
setups.

Test Plan: Ran "arc mark-committed --quiet --finalize 123". Will run "arc land"
on this. so lazy

Reviewers: cpiro, btrahan

Reviewed By: cpiro

CC: aran, epriestley

Maniphest Tasks: T819

Differential Revision: https://secure.phabricator.com/D1538
This commit is contained in:
epriestley 2012-02-01 14:32:43 -08:00
parent 4f07c3c8fd
commit eaa565747e
2 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/workflow/land/ArcanistLandWorkflow.php
View file

@ -81,10 +81,6 @@ EOTEXT
} }
public function run() { public function run() {
$this->writeStatusMessage(
phutil_console_format(
"**WARNING:** 'arc land' is new and experimental.\n"));
$branch = $this->getArgument('branch'); $branch = $this->getArgument('branch');
if (count($branch) !== 1) { if (count($branch) !== 1) {
throw new ArcanistUsageException( throw new ArcanistUsageException(
@ -257,6 +253,15 @@ EOTEXT
throw new ArcanistUsageException("'git push' failed."); throw new ArcanistUsageException("'git push' failed.");
} }
$mark_workflow = $this->buildChildWorkflow(
'mark-committed',
array(
'--finalize',
'--quiet',
$revision['id'],
));
$mark_workflow->run();
echo "\n"; echo "\n";
} }

5
src/workflow/mark-committed/ArcanistMarkCommittedWorkflow.php
View file

@ -45,6 +45,9 @@ EOTEXT
"revision is accepted. Continue even if the mark can't happen. This ". "revision is accepted. Continue even if the mark can't happen. This ".
"is a soft version of 'mark-committed' used by other workflows.", "is a soft version of 'mark-committed' used by other workflows.",
), ),
'quiet' => array(
'help' => 'Do not print a success message.',
),
'*' => 'revision', '*' => 'revision',
); );
} }
@ -149,12 +152,14 @@ EOTEXT
$is_finalized = false; $is_finalized = false;
} }
if (!$this->getArgument('quiet')) {
if ($is_finalized) { if ($is_finalized) {
$message = $this->getRepositoryAPI()->getFinalizedRevisionMessage(); $message = $this->getRepositoryAPI()->getFinalizedRevisionMessage();
echo phutil_console_wrap($message)."\n"; echo phutil_console_wrap($message)."\n";
} else { } else {
echo "Done.\n"; echo "Done.\n";
} }
}
return 0; return 0;
} }