revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8

Browse source 
Summary:
PHP 8 deprecates openssl_free_key as the key is automatically freed, so
silence the warning in PhutilOAuth1Future::signString.

Test Plan: Ran arc lint --everything

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21502
This commit is contained in:
Jessica Clarke 2021-01-11 04:50:37 +00:00 committed by jrtc27
parent 9589fd1866
commit f64eb04300
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/future/oauth/PhutilOAuth1Future.php
View file

@ -268,7 +268,8 @@ final class PhutilOAuth1Future extends FutureProxy {
throw new Exception(pht('%s failed!', 'openssl_sign()'));
}
openssl_free_key($pkey);
// Deprecated in PHP 8; key is automatically freed.
@openssl_free_key($pkey);
return base64_encode($signature);
case 'PLAINTEXT':