1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-10 14:51:05 +01:00
phorge-arcanist/src/lint/linter/ArcanistGoLintLinter.php
Joshua Spence 23bc9f294c Change the default value for ArcanistExternalLinter::shouldExpectCommandErrors
Summary: It is more common for linters to exit with a non-zero status than it is for linters to return with a zero exit status, Really this function serves very little purposes, it simply determines whether or not to throw an exception if a non-zero status is returned by the external linter.

Test Plan: `arc unit`

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11322
2015-01-12 07:21:33 +11:00

64 lines
1.4 KiB
PHP

<?php
final class ArcanistGoLintLinter extends ArcanistExternalLinter {
public function getInfoName() {
return 'Golint';
}
public function getInfoURI() {
return 'https://github.com/golang/lint';
}
public function getInfoDescription() {
return pht('Golint is a linter for Go source code.');
}
public function getLinterName() {
return 'GOLINT';
}
public function getLinterConfigurationName() {
return 'golint';
}
public function getDefaultBinary() {
return 'golint';
}
public function getInstallInstructions() {
return pht('Install Golint using `go get github.com/golang/lint/golint`.');
}
public function shouldExpectCommandErrors() {
return false;
}
protected function canCustomizeLintSeverities() {
return true;
}
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$lines = phutil_split_lines($stdout, false);
$messages = array();
foreach ($lines as $line) {
$matches = explode(':', $line, 4);
if (count($matches) === 4) {
$message = new ArcanistLintMessage();
$message->setPath($path);
$message->setLine($matches[1]);
$message->setChar($matches[2]);
$message->setCode($this->getLinterName());
$message->setDescription(ucfirst(trim($matches[3])));
$message->setSeverity(ArcanistLintSeverity::SEVERITY_ADVICE);
$messages[] = $message;
}
}
return $messages;
}
}