mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-25 08:12:40 +01:00
No description
1b8ce98304
Summary: Calling `arc patch` on a diff that's dependent on a different diff tries to patch the parent first. To patch the parent a child workflow is created, and a conduit is passed down, but the credentials are not and it is not marked as authenticated. Then when the child tries to get the commit message for the dependency, it checks isConduitAuthenticated() https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistPatchWorkflow.php;2c3268f03ed70d3221eb1642bIc99ebb39b12902e$800 and on failure pops up an interactive editor for the commit message. Instead we just pass down the credentials to the childred and mark them as authenticated, so this is not a problem. Test Plan: With two diffs where DA2 depends on DA1, run `arc patch --force --nobranch DA2` ... this no longer pops an interactive editor for the commit message for the dependency. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: hach-que, seshness, epriestley, Korvin Maniphest Tasks: T5986 Differential Revision: https://secure.phabricator.com/D10381 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .arclint | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README | ||
= WHAT IS ARCANIST? = Arcanist is the command-line tool for [[http://phabricator.org/ | Phabricator]]. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide [[http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html | here]]. For more information about Phabricator, see http://phabricator.org/. = LICENSE = Arcanist is released under the Apache 2.0 license except as otherwise noted.