1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-09 00:12:40 +01:00
phorge-arcanist/src
epriestley 2650e8627a Make the Arcanist comment remover less aggressive about stripping instructional comments
Summary:
Ref T13098. See PHI858. If you write this at the end of a message in `arc diff`:

```
  Subscribers:
  #projectname

  # NEW DIFFERENTIAL REVISION
  # Describe the changes in this new revision.
  # ...
```

...we'll currently eat the `#projectname` as an instructional comment, even if it is followed by an empty line.

Instead, stop eating stuff once we hit the first empty line. (We escape empty lines in comments already.)

After T13098 I'll maybe adjust this to use a more explicit instruction escape, like `##`, since there's no reason we're bound to `#`.

Test Plan: Added a unit test and made it pass.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19639
2018-09-14 11:03:26 -07:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:37:59 +11:00
configuration Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote 2017-06-09 08:12:37 -07:00
difference Raise the intraline diff hard limit from 80 to 100 characters 2018-05-09 13:38:20 -07:00
differential Extend from Phobject 2015-06-15 15:47:33 +10:00
docs/book Minor documentation improvements 2015-06-08 11:31:35 +10:00
events/constant Remove @group annotations 2014-07-09 09:12:13 +10:00
exception Allow diff generation via ArcanistBundle to be limited to an approximate maximum byte size 2018-05-14 09:09:06 -07:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Fix a property name collision in ArcanistHgServerChannel 2017-02-16 05:44:10 -08:00
internationalization Various translation improvements 2015-11-02 21:31:04 +11:00
land Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
lint Allow willLintPaths and didLintPaths to be overridden 2018-09-06 12:44:23 +10:00
parser Make the Arcanist comment remover less aggressive about stripping instructional comments 2018-09-14 11:03:26 -07:00
ref Make "arc land" accommodate a minor API change in Harbormaster build statuses 2017-12-23 11:39:19 -08:00
repository Fix arc diff when adding large new file with new git 2018-07-09 17:59:15 +00:00
unit [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines 2018-06-05 20:58:47 +00:00
upload Upgrade "arc upload" to use SHA256 2017-04-04 16:56:35 -07:00
workflow In "arc patch", update submodules slightly later 2018-06-07 12:03:08 -07:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Allow diff generation via ArcanistBundle to be limited to an approximate maximum byte size 2018-05-14 09:09:06 -07:00