1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-09 00:12:40 +01:00
phorge-arcanist/src
epriestley 2df96ed405 Allow users to skip "arc:prompt" by entering no text
Summary:
Fixes T9476. Currently, if you enter no text in "arc:prompt", we abort resolution immediately.

However, this is a bit inconsistent (other rules that fail to resolve are skipped) it is reasonable to put some default rule behind "arc:prompt" so that you can just mash enter to select it. This construction is unusual, but seems fine and sensible to me.

If you're using "arc:prompt" as the last rule, the behavior is the same as before, so this should only make the rule more useful.

Test Plan:
  - Ran `arc which --base 'arc:prompt, git:HEAD^'` with and without the patch.
  - Without the patch, entering no text at "arc:prompt" failed immediately.
  - With the patch, entering no text caused fallback to the "git:HEAD^" rule.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9476

Differential Revision: https://secure.phabricator.com/D14187
2015-09-29 07:09:19 -07:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:37:59 +11:00
configuration Fix an issue with "arc nrabch" 2015-09-15 11:14:07 -07:00
difference Extend from Phobject 2015-06-15 15:47:33 +10:00
differential Extend from Phobject 2015-06-15 15:47:33 +10:00
docs/book Minor documentation improvements 2015-06-08 11:31:35 +10:00
events/constant Remove @group annotations 2014-07-09 09:12:13 +10:00
exception pht all the things 2015-05-13 21:00:53 +10:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Extend from Phobject 2015-06-15 15:47:33 +10:00
internationalization Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
lint Improve validation of 'name' and 'code' parameters for lint messages 2015-09-25 11:16:04 -07:00
parser Allow users to skip "arc:prompt" by entering no text 2015-09-29 07:09:19 -07:00
repository Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
unit Remove leftover code for "postponed" lint and unit status 2015-08-30 21:56:12 +10:00
upload Improve temporary file upload API and add viewPolicy support 2015-09-07 12:44:59 -07:00
workflow Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Add a linter rule for detecting empty files 2015-09-01 19:30:55 +10:00