mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
No description
39e4656278
Summary: The module analyzer reads "phutil_require_module" in the source of a module as a dependency, and tries to regenerate __init__.php if symbols from that module aren't actually used. This creates patches which don't actually resolve the problem, since changing __init__.php won't change the dependency. Instead, trust that anyone using phutil_require_module in the source of a module knows what they're doing and don't mark it as a dependency. We currently have an issue with this in phabricator's Setup process since I load some other libraries' modules just to test if they can be loaded @lesha, this might be the issue you reported a while ago. Test Plan: Ran "arc lint" on a module which pulls in another module explicitly in the source, didn't get a no-op lint error. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, lesha CC: aran, epriestley, jungejason Differential Revision: 770 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for at least a couple months. -epriestley WHAT IS ARCANIST? Arcanist is the CLI for Facebook's code review tool, Differential. Since Differential isn't released yet, it may not be terribly useful on its own.