1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
phorge-arcanist/scripts
epriestley 39e4656278 Fix an obscure dependency issue in Arcanist + libphutil
Summary:
The module analyzer reads "phutil_require_module" in the source of a module as a
dependency, and tries to regenerate __init__.php if symbols from that module
aren't actually used. This creates patches which don't actually resolve the
problem, since changing __init__.php won't change the dependency.

Instead, trust that anyone using phutil_require_module in the source of a module
knows what they're doing and don't mark it as a dependency.

We currently have an issue with this in phabricator's Setup process since I load
some other libraries' modules just to test if they can be loaded

@lesha, this might be the issue you reported a while ago.

Test Plan: Ran "arc lint" on a module which pulls in another module explicitly
in the source, didn't get a no-op lint error.
Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen, aran, lesha
CC: aran, epriestley, jungejason
Differential Revision: 770
2011-08-03 12:17:49 -07:00
..
__init_script__.php Flush output buffers before running 'arc' 2011-07-16 08:09:47 -07:00
arcanist.php Move Conduit management into Workflow 2011-07-15 12:38:45 -07:00
phutil_analyzer.php Fix an obscure dependency issue in Arcanist + libphutil 2011-08-03 12:17:49 -07:00
phutil_mapper.php 'arc liberate', convenience wrapper for various libphutil operations 2011-05-17 09:53:19 -07:00