1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
phorge-arcanist/src
epriestley 3cdfe1fff8 When running "arc land" from a detached HEAD, don't try to delete the source ref
Summary:
Fixes T10321. Some reasonable but less-common workflows involve running `arc land` from a detached HEAD state.

When users do this, we currently try to delete the raw hash as though it were a branch during cleanup. Instead, detect if the thing we're thinking about deleting is a branch or not, and just leave it alone if it isn't.

Test Plan:
  - Ran `git checkout <some hash>`, then `arc land --revision <some revision>`.
  - Before, everything worked but cleanup tried to `git branch -D <some hash>`.
  - After, everything worked and cleanup skipped branch deletion.

Maniphest Tasks: T10321

Differential Revision: https://secure.phabricator.com/D20786
2019-09-05 05:31:00 -07:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:37:59 +11:00
configuration Small ReMarkup fix 2018-11-07 21:56:19 -08:00
difference Add Arcanist support for highlighting indent change intraline diffs 2019-02-19 12:17:32 -08:00
differential Extend from Phobject 2015-06-15 15:47:33 +10:00
docs/book Minor documentation improvements 2015-06-08 11:31:35 +10:00
events/constant Remove @group annotations 2014-07-09 09:12:13 +10:00
exception Allow diff generation via ArcanistBundle to be limited to an approximate maximum byte size 2018-05-14 09:09:06 -07:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Fix a property name collision in ArcanistHgServerChannel 2017-02-16 05:44:10 -08:00
internationalization Various translation improvements 2015-11-02 21:31:04 +11:00
land When running "arc land" from a detached HEAD, don't try to delete the source ref 2019-09-05 05:31:00 -07:00
lint Modify the lint-test file format to allow for more powerful assertions 2019-05-21 13:48:30 +10:00
parser Make the Arcanist comment remover less aggressive about stripping instructional comments 2018-09-14 11:03:26 -07:00
ref Implement "Warn When Landing" behavior for Build Plans in Arcanist 2019-03-06 06:47:53 -08:00
repository Work around a Windows escaping issue and security conecern in "hg cat --output ..." 2018-10-26 07:28:50 -07:00
unit [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines 2018-06-05 20:58:47 +00:00
upload Upgrade "arc upload" to use SHA256 2017-04-04 16:56:35 -07:00
workflow Fix two "msort()" vs "msortv()" issues in "arc land" 2019-06-20 16:07:13 -07:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Implement "Warn When Landing" behavior for Build Plans in Arcanist 2019-03-06 06:47:53 -08:00