1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-09-20 08:58:55 +02:00
No description
Find a file
Joshua Spence 3f79ae258f Allow classes/functions from a later version if they are used conditionally
Summary:
Fixes T5299. Currently, linting `src/future/http/HTTPSFuture.php` from rPHU will raise the following error:

```
   Error  (XHP31) Use Of PHP 5.3 Features
    This codebase targets PHP 5.2.3, but `curlfile` was not introduced until
    PHP 5.5.0.

             532       // use this "@" stuff.
             533
             534       if (class_exists('CURLFile')) {
    >>>      535         $file_value = new CURLFile((string)$tmp, $info['mime'], $info['name']);
             536       } else {
             537         $file_value = '@'.(string)$tmp;
             538       }
```

However, since this class is being used conditionally, it //should// be fine and no linter errors should be being raised.

Test Plan: Added a test case.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5299

Differential Revision: https://secure.phabricator.com/D10132
2014-09-11 00:24:08 +10:00
bin Added ArcanistTextLinter::LINT_BOF_WHITESPACE and ArcanistTextLinter::LINT_EOF_WHITESPACE 2014-01-13 18:05:42 -08:00
externals Add a newline to externals/includes/README 2014-07-16 22:11:52 +10:00
resources Move PhutilLibraryMapBuilder to libphutil 2014-07-05 17:01:36 +10:00
scripts Fix various spelling mistakes 2014-07-13 00:45:38 +10:00
src Allow classes/functions from a later version if they are used conditionally 2014-09-11 00:24:08 +10:00
.arcconfig Use the ArcanistConfigurationDrivenLintEngine as a linting engine. 2014-05-11 19:33:40 -07:00
.arclint Move ArcanistSpellingDefaultData into a configurable JSON file 2014-07-04 08:18:33 +10:00
.editorconfig Apply various linter fixes. 2014-06-10 11:02:42 -07:00
.gitignore Update .gitignore. 2014-06-14 11:44:38 -07:00
LICENSE Delete license headers from files 2012-11-05 11:16:24 -08:00
NOTICE Remove duplicate newline 2014-07-17 08:25:22 +10:00
README Reformat README as Remarkup 2014-07-16 22:11:10 +10:00

= WHAT IS ARCANIST? =

Arcanist is the command-line tool for [[http://phabricator.org/ | Phabricator]].
It allows you to interact with Phabricator installs to send code for review,
download patches, transfer files, view status, make API calls, and various other
things. You can find a complete user guide
[[http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html |
here]].

For more information about Phabricator, see http://phabricator.org/.

= LICENSE =
Arcanist is released under the Apache 2.0 license except as otherwise noted.