revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/workflow
History
Lawrence D'\''Anna 4230292997 Fix incorrect quoting of author in 'arc patch' 
Summary:
Author field is formatted with csprintf, which would be appropriate
if the resulting string was concatenated into a shell command as a
string -- but because the flags are passed as a vector of strings
and not parsed by the shell, this results in extraneous shell
quoting making it into to author field.   In particular this
renders my name as D'\''Anna instead of D'Anna

Test Plan:
Performed 'arc patch' with and without these changes, confirmed
that my apostrophe was no longer mangled by shell quotes in the
resulting commit.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: MacFan4000, Ekubischta, speck, tobiaswiese, valerio.bozzolan

Differential Revision: https://we.phorge.it/D25026
2021-10-23 15:02:16 -04:00
..
exception pht all the things 2015-05-13 21:00:53 +10:00
ArcanistAmendWorkflow.php Update "arc land" display of build failures, and rename "DisplayRef" to "RefView" 2020-06-30 06:27:56 -07:00
ArcanistAnoidWorkflow.php Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes 2020-02-16 09:16:24 -08:00
ArcanistBookmarksWorkflow.php Provide a more powerful query mechanism for "markers" (branches/bookmarks) 2020-06-08 16:27:20 -07:00
ArcanistBranchesWorkflow.php Provide a more powerful query mechanism for "markers" (branches/bookmarks) 2020-06-08 16:27:20 -07:00
ArcanistCallConduitWorkflow.php Implement Conduit login prompt behavior as a pure FutureProxy, not a Future-like object 2020-07-01 06:37:31 -07:00
ArcanistCloseRevisionWorkflow.php Fix additional "xsprintf()"-family static parameter errors 2020-09-08 11:45:54 -07:00
ArcanistCommitWorkflow.php Various translation improvements 2015-11-02 21:31:04 +11:00
ArcanistCoverWorkflow.php Various translation improvements 2015-11-02 21:31:04 +11:00
ArcanistDiffWorkflow.php fail arc diff if second lfs push errors 2020-09-28 16:20:56 -07:00
ArcanistDownloadWorkflow.php Upgrade "arc download" to Toolsets 2020-04-12 16:18:03 -07:00
ArcanistExportWorkflow.php Remove call to "arcanist.projectinfo" from arc export 2015-05-25 18:31:09 +10:00
ArcanistGetConfigWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistInspectWorkflow.php Support inspection of remote refs with "arc inspect remote(...)" 2020-06-30 13:07:25 -07:00
ArcanistInstallCertificateWorkflow.php Added a warning prompt if the user tries to use an API cert instead of a CLI cert 2016-08-25 11:34:34 -04:00
ArcanistLandWorkflow.php Correct a leftover reference to "--keep-branch" 2020-06-30 06:30:51 -07:00
ArcanistLiberateWorkflow.php Mark the wildcard argument to "arc liberate" as a path argument for shell completion 2020-05-28 07:33:12 -07:00
ArcanistLintersWorkflow.php Fix missing whitespace in arc linters --help message 2017-08-04 13:12:59 -07:00
ArcanistLintWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistListWorkflow.php Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
ArcanistLookWorkflow.php Give Mercurial more plausible marker behavior 2020-06-30 15:50:07 -07:00
ArcanistMarkersWorkflow.php Give Mercurial more plausible marker behavior 2020-06-30 15:50:07 -07:00
ArcanistPasteWorkflow.php Update Paste help to include missing "--" 2021-03-16 09:29:50 -07:00
ArcanistPatchWorkflow.php Fix incorrect quoting of author in 'arc patch' 2021-10-23 15:02:16 -04:00
ArcanistSetConfigWorkflow.php Add back pht()s and tsprintf()s to arg set-config 2017-02-16 11:08:45 +00:00
ArcanistTasksWorkflow.php Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
ArcanistTodoWorkflow.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistUnitWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistUpgradeWorkflow.php Update the "WorkingCopy" API and create a fallback "Filesystem" working copy 2020-04-08 09:22:43 -07:00
ArcanistUploadWorkflow.php Remove an unused method in "ArcanistUploadWorkflow" 2020-07-01 06:37:30 -07:00
ArcanistWeldWorkflow.php Require "--" as an argument terminator when running noninteractively 2020-02-16 09:16:51 -08:00
ArcanistWhichWorkflow.php Make callsigns optional in arcanist 2016-03-15 03:58:46 +00:00
ArcanistWorkflow.php Remove final from private functions for PHP 8 compatibility 2021-01-10 22:05:20 +00:00
ArcanistWorkWorkflow.php Support "arc land --pick" to pick specific changes out of a sequence 2020-06-08 16:30:53 -07:00