mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-02-10 22:08:31 +01:00
Summary: I found a few strings that I had missed, using a mostly-broken-but-somewhat-okay custom linter ruler (https://secure.phabricator.com/differential/diff/30988/). Test Plan: Intense eyeballing. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: aurelijus, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12888
85 lines
2 KiB
PHP
85 lines
2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* A linter for JSON files.
|
|
*/
|
|
final class ArcanistJSONLintLinter extends ArcanistExternalLinter {
|
|
|
|
public function getInfoName() {
|
|
return pht('JSON Lint');
|
|
}
|
|
|
|
public function getInfoURI() {
|
|
return 'https://github.com/zaach/jsonlint';
|
|
}
|
|
|
|
public function getInfoDescription() {
|
|
return pht('Use `%s` to detect syntax errors in JSON files.', 'jsonlint');
|
|
}
|
|
|
|
public function getLinterName() {
|
|
return 'JSON';
|
|
}
|
|
|
|
public function getLinterConfigurationName() {
|
|
return 'jsonlint';
|
|
}
|
|
|
|
public function getDefaultBinary() {
|
|
return 'jsonlint';
|
|
}
|
|
|
|
public function getVersion() {
|
|
// NOTE: `jsonlint --version` returns a non-zero exit status.
|
|
list($err, $stdout) = exec_manual(
|
|
'%C --version',
|
|
$this->getExecutableCommand());
|
|
|
|
$matches = array();
|
|
if (preg_match('/^(?P<version>\d+\.\d+\.\d+)$/', $stdout, $matches)) {
|
|
return $matches['version'];
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public function getInstallInstructions() {
|
|
return pht('Install jsonlint using `%s`.', 'npm install -g jsonlint');
|
|
}
|
|
|
|
protected function getMandatoryFlags() {
|
|
return array(
|
|
'--compact',
|
|
);
|
|
}
|
|
|
|
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
|
|
$lines = phutil_split_lines($stderr, false);
|
|
|
|
$messages = array();
|
|
foreach ($lines as $line) {
|
|
$matches = null;
|
|
$match = preg_match(
|
|
'/^(?:(?<path>.+): )?'.
|
|
'line (?<line>\d+), col (?<column>\d+), '.
|
|
'(?<description>.*)$/',
|
|
$line,
|
|
$matches);
|
|
|
|
if ($match) {
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($matches['line']);
|
|
$message->setChar($matches['column']);
|
|
$message->setCode($this->getLinterName());
|
|
$message->setDescription(ucfirst($matches['description']));
|
|
$message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);
|
|
|
|
$messages[] = $message;
|
|
}
|
|
}
|
|
|
|
return $messages;
|
|
}
|
|
|
|
}
|