revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-14 19:02:40 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src
History
epriestley be1a4a9142 Avoid leaving stdin in nonblocking mode after a modern prompt 
Summary:
Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan: This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Maniphest Tasks: T13649

Differential Revision: https://secure.phabricator.com/D21666
2021-05-30 01:33:15 -07:00
..
__tests__ Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer 2020-02-13 14:10:46 -08:00
browse Add "--browse" to "arc upload" and update behavior, particularly "--json" 2020-05-01 09:13:01 -07:00
channel Move Phage to FuturePool 2020-04-05 05:56:21 -07:00
conduit In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions 2020-09-17 13:20:24 -07:00
config In Arcanist, when trying to write to a file configuration source, create missing directories 2021-03-03 13:40:56 -08:00
configuration Remove "arc feature", "arc branch", "arc bookmark", and significant chunks of obsolete marker code 2020-06-08 16:27:31 -07:00
console Improve grid layout in "arc branches" at various terminal widths 2020-06-30 15:50:06 -07:00
difference Fix an initialization issue in VectorTree 2020-05-04 15:50:26 -07:00
differential Merge "--draft" flag and related changes from "experimental" to "master" 2020-02-12 16:54:18 -08:00
docs Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
engine Implement "arc work", to replace "arc feature" 2020-06-08 16:27:27 -07:00
error Fix error handler on PHP 8 2021-01-11 02:02:16 +00:00
events Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
exception Provide some "preg_*" wrappers which raise exceptions on failure 2021-02-19 11:16:09 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
filesystem On Windows, implement "Filesystem::copyFile()" with "copy()" 2021-03-22 12:00:23 -07:00
future Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8 2021-01-11 04:50:37 +00:00
hardpoint Fix additional "xsprintf()"-family static parameter errors 2020-09-08 11:45:54 -07:00
hgdaemon Fix a property name collision in ArcanistHgServerChannel 2017-02-16 05:44:10 -08:00
init Correct a mistaken Phurl link in the "missing symbol" exception 2021-03-12 09:51:18 -08:00
inspector Support inspection of remote refs with "arc inspect remote(...)" 2020-06-30 13:07:25 -07:00
internationalization Merge utility/support changes from "wilds" to "master" 2020-02-13 14:10:09 -08:00
ip Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
land In "arc land", if rebasing a range fails, attempt to "reduce" it 2021-03-03 13:40:56 -08:00
lexer Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
lint Update golint install instructions 2021-02-10 10:03:39 -08:00
log Update "arc paste" for Toolsets 2020-04-13 15:01:51 -07:00
moduleutils Allow lint to correct the spelling of builtin symbols 2021-02-03 13:26:33 -08:00
object Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
parser Improve "PhutilJSON" handling of PHP-object JSON values 2021-03-11 12:43:08 -08:00
phage Allow "phage" to print execution status on SIGINT 2020-04-06 11:09:43 -07:00
progress Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
query Provide "gitsprintf(...)" and disambiguate Git ref selectors 2021-01-13 12:31:15 -08:00
readableserializer Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
ref Implement Conduit login prompt behavior as a pure FutureProxy, not a Future-like object 2020-07-01 06:37:31 -07:00
repository Provide "gitsprintf(...)" and disambiguate Git ref selectors 2021-01-13 12:31:15 -08:00
runtime Fix additional "xsprintf()"-family static parameter errors 2020-09-08 11:45:54 -07:00
serviceprofiler Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
symbols Merge utility/support changes from "wilds" to "master" 2020-02-13 14:10:09 -08:00
toolset Avoid leaving stdin in nonblocking mode after a modern prompt 2021-05-30 01:33:15 -07:00
unit Remove final from private functions for PHP 8 compatibility 2021-01-10 22:05:20 +00:00
upload Implement Conduit login prompt behavior as a pure FutureProxy, not a Future-like object 2020-07-01 06:37:31 -07:00
utils Avoid leaving stdin in nonblocking mode after a modern prompt 2021-05-30 01:33:15 -07:00
work Update "arc land" display of build failures, and rename "DisplayRef" to "RefView" 2020-06-30 06:27:56 -07:00
workflow Update Paste help to include missing "--" 2021-03-16 09:29:50 -07:00
workingcopy Introduce "arc inspect" and some of the new ref/hardpoint classes 2020-04-10 05:01:25 -07:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
xsprintf Annotate the unusual use of "$callback()" in "xsprintf()" 2021-02-03 14:21:08 -08:00
__phutil_library_init__.php Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
__phutil_library_map__.php Avoid leaving stdin in nonblocking mode after a modern prompt 2021-05-30 01:33:15 -07:00