mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-09-20 00:49:11 +02:00
No description
66a6128239
Summary: Depends on D21031. Ref T11968. This clears some lint with the word "Future", but is just a minor cleanup patch not really related to the main goal in that task. We currently warn on `preg_quote()` with no second parameter, but this is valid and correct: ``` preg_match('('.preg_quote($x).')', ...) ``` This is the modern recommended style for this sort of expression, so the warning is often a false positive; drop it. The "__CLASS__" warning looks for hard-coded class names in strings, but currently looks for them as a word anywhere in the string. This is often a false positive and sometimes makes error messages or exceptions untranslatable. For example, translators can't do anything with this: > Filesystem path "%s" does not exist. ...if it's written as: > %s path "%s" does not exist. ...just because it happens to appear in the class "Filesystem". Some other classes, including "Future", suffer from this. Even when the detection is correct, it's clunky and a mistake here (failing to update the class name in an error message) is unlikely to ever do any real damage. Test Plan: Ran unit tests and `arc lint`. Maniphest Tasks: T11968 Differential Revision: https://secure.phabricator.com/D21032 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can read more in the User Guide
For more information about Phabricator, see http://phabricator.org/.
LICENSE
Arcanist is released under the Apache 2.0 license except as otherwise noted.