mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 14:22:40 +01:00
No description
72e59da804
Summary:
When using `arc diff`, this crash should not fire anymore on non-English shells:
Undefined array key "Repository UUID"
The error message comes to this line:
https://we.phorge.it/source/arcanist/browse/master/src/repository/api/ArcanistSubversionAPI.php;f7fcf31c7e23475e345cb3cd4abf0474ba6fd9cf$606
Look at the parser of `svn info` that expects English language:
https://we.phorge.it/source/arcanist/browse/master/src/repository/api/ArcanistSubversionAPI.php;f7fcf31c7e23475e345cb3cd4abf0474ba6fd9cf$326-375
The historical behavior of `ExecFuture` is to inherit environment variables. It may have sense, to have the user home, etc.
So, the approach is to just clear the incompatible specific environment variable that alters the output language.
Closes T15855
Test Plan:
- clone a random a Subversion repository
- have your operating system in a non-English language
- (e.g. `export LANGUAGE=en_US:it_IT`)
- run 'arc diff'
No crash anymore. You are able to submit the patch, just like in git.
Reviewers: O1 Blessed Committers, l2dy, avivey
Reviewed By: O1 Blessed Committers, l2dy, avivey
Subscribers: l2dy, aklapper, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15855
Differential Revision: https://we.phorge.it/D25691
|
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Arcanist is the command-line tool for Phorge. It allows you to interact with Phorge installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can read more in the User Guide
For more information about Phorge, see https://phorge.it/.
LICENSE
Arcanist is released under the Apache 2.0 license except as otherwise noted.