1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
phorge-arcanist/src
epriestley 86779b1526 Render lint patches which have newlines in a less misleading way
Summary:
Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  - Includes test coverage for removing a newline, from T12765.
  - Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  - For one-line patches, highlighting the patched section.
  - For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan: Ran unit tests, linted a few things.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9846

Differential Revision: https://secure.phabricator.com/D18510
2017-08-31 13:28:31 -07:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:37:59 +11:00
configuration Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote 2017-06-09 08:12:37 -07:00
difference Don't compute intraline diffs if the input fails a coarse check for being huge 2016-10-07 07:42:19 -07:00
differential Extend from Phobject 2015-06-15 15:47:33 +10:00
docs/book Minor documentation improvements 2015-06-08 11:31:35 +10:00
events/constant Remove @group annotations 2014-07-09 09:12:13 +10:00
exception pht all the things 2015-05-13 21:00:53 +10:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Fix a property name collision in ArcanistHgServerChannel 2017-02-16 05:44:10 -08:00
internationalization Various translation improvements 2015-11-02 21:31:04 +11:00
land Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
lint Render lint patches which have newlines in a less misleading way 2017-08-31 13:28:31 -07:00
parser Update documentation for changed splitGitDiffPaths function 2016-08-19 14:55:33 -07:00
repository Fix errors found by PHPStan 2017-02-18 09:24:19 +00:00
unit Fix errors found by PHPStan 2017-02-18 09:24:19 +00:00
upload Upgrade "arc upload" to use SHA256 2017-04-04 16:56:35 -07:00
workflow Fix missing whitespace in arc linters --help message 2017-08-04 13:12:59 -07:00
workingcopyidentity Extend from Phobject 2015-06-15 15:47:33 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Extract and cover the logic for "trimming" a lint message 2017-08-31 13:28:01 -07:00