mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
No description
90ac9a2ff2
Summary: PHP 8's sprintf raises a ValueError when encountering unknown format specifiers (previously it would eat the argument and print nothing), so linting format strings like %Ls dies with an uncaught ValueError. Fix this by using a custom callback during linting to turn all format specifiers into %s and replace the dummy null argument with the original format specifier, ensuring we always end up providing valid input to the sprintf at the end. This has the nice property that the output of the call to xsprintf is the original format string, though any transformation into valid input would do. Test Plan: Ran arc lint Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T13588 Differential Revision: https://secure.phabricator.com/D21500 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can read more in the User Guide
For more information about Phabricator, see http://phabricator.org/.
LICENSE
Arcanist is released under the Apache 2.0 license except as otherwise noted.