1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-24 07:42:39 +01:00
phorge-arcanist/scripts
Dimitry Andric 97056a3b85 Preserve the exit code of the diff command in binary_safe_diff.sh
Summary:
Some versions of Subversion (1.9 in any case, maybe others) will
duplicate diff headers, if the diff command run through --diff-cmd
returns 0.

This lead to T9970, where the addition of a new file with properties
only shows the properties themselves in the review, not the content of
the new file.

Test Plan: This is a trivial change, is a test needed at all?

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: stevenh, Korvin, eadler

Differential Revision: https://secure.phabricator.com/D14755
2015-12-13 02:21:43 -08:00
..
hgdaemon phtize some strings 2015-01-06 23:15:50 +11:00
repository Preserve the exit code of the diff command in binary_safe_diff.sh 2015-12-13 02:21:43 -08:00
__init_script__.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
arcanist.php Fix callsites which called libphutil_console_wrap like it were _format 2015-09-03 12:01:01 -07:00
breakout.py Fix text lint issues 2015-04-07 18:09:27 +10:00