1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-09 00:12:40 +01:00
phorge-arcanist/src/parser
epriestley 2650e8627a Make the Arcanist comment remover less aggressive about stripping instructional comments
Summary:
Ref T13098. See PHI858. If you write this at the end of a message in `arc diff`:

```
  Subscribers:
  #projectname

  # NEW DIFFERENTIAL REVISION
  # Describe the changes in this new revision.
  # ...
```

...we'll currently eat the `#projectname` as an instructional comment, even if it is followed by an empty line.

Instead, stop eating stuff once we hit the first empty line. (We escape empty lines in comments already.)

After T13098 I'll maybe adjust this to use a more explicit instruction escape, like `##`, since there's no reason we're bound to `#`.

Test Plan: Added a unit test and made it pass.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19639
2018-09-14 11:03:26 -07:00
..
__tests__ Make the Arcanist comment remover less aggressive about stripping instructional comments 2018-09-14 11:03:26 -07:00
diff Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistBaseCommitParser.php Linter fixes 2015-12-07 21:35:34 +11:00
ArcanistBundle.php Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable 2018-08-24 11:00:16 -07:00
ArcanistCommentRemover.php Make the Arcanist comment remover less aggressive about stripping instructional comments 2018-09-14 11:03:26 -07:00
ArcanistDiffParser.php Update documentation for changed splitGitDiffPaths function 2016-08-19 14:55:33 -07:00