1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-18 17:58:36 +01:00
phorge-arcanist/src/parser/__tests__
epriestley 2650e8627a Make the Arcanist comment remover less aggressive about stripping instructional comments
Summary:
Ref T13098. See PHI858. If you write this at the end of a message in `arc diff`:

```
  Subscribers:
  #projectname

  # NEW DIFFERENTIAL REVISION
  # Describe the changes in this new revision.
  # ...
```

...we'll currently eat the `#projectname` as an instructional comment, even if it is followed by an empty line.

Instead, stop eating stuff once we hit the first empty line. (We escape empty lines in comments already.)

After T13098 I'll maybe adjust this to use a more explicit instruction escape, like `##`, since there's no reason we're bound to `#`.

Test Plan: Added a unit test and made it pass.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19639
2018-09-14 11:03:26 -07:00
..
base85 Restructure base85 unit tests to support inlining and multiple encoding pathways 2018-04-27 12:03:14 -07:00
bundle Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable 2018-08-24 11:00:16 -07:00
diff Parse git renames with inconsistent quoting or custom prefixes 2016-08-16 17:45:51 -07:00
patches Fix an issue where arc diff would loop indefinitely for a property change 2012-11-06 17:46:55 -08:00
ArcanistBaseCommitParserTestCase.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
ArcanistBundleTestCase.php Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable 2018-08-24 11:00:16 -07:00
ArcanistCommentRemoverTestCase.php Make the Arcanist comment remover less aggressive about stripping instructional comments 2018-09-14 11:03:26 -07:00
ArcanistDiffParserTestCase.php Parse git renames with inconsistent quoting or custom prefixes 2016-08-16 17:45:51 -07:00
bundle.git.tgz Fix an issue where arc diff would loop indefinitely for a property change 2012-11-06 17:46:55 -08:00