mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-09 22:31:02 +01:00
a6a26bb3a3
Summary: Ref T2039. Convert the `ArcanistPylintLinter` to an `ArcanistExternalLinter` and make it compatible with `.arclint`. In doing so, it was necessary to drop support of older versions of `pylint` by setting the minimum version to be 1.0.0. I think that dropping support for older versions is reasonable because version 1.0.0 was released ~18 months ago. In the case than an incompatible version is detected, an `ArcanistMissingLinterException` is thrown. One caveat here is that support for `lint.pylint.codes.(error|warning|advice)` is dropped. Any installs that are relying on this configuration will need to migrate to using the `.arclint` file for specifying linter severity. We could potentially continue to support this deprecated configuration, but I'm not sure if this is worthwhile. Test Plan: Wrote and executed unit tests with `arc unit`. I ran the unit tests on all `pylint` releases after (and including) 1.0.0. Specifically, the tests were run on v1.0.0, v1.1.0, v1.2.0, v1.3.0 and v1.4.0. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Maniphest Tasks: T2039 Differential Revision: https://secure.phabricator.com/D9109 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| exception | ||
| xhpast | ||
| ArcanistBaseXHPASTLinter.php | ||
| ArcanistChmodLinter.php | ||
| ArcanistClosureLinter.php | ||
| ArcanistCoffeeLintLinter.php | ||
| ArcanistConduitLinter.php | ||
| ArcanistCppcheckLinter.php | ||
| ArcanistCpplintLinter.php | ||
| ArcanistCSharpLinter.php | ||
| ArcanistCSSLintLinter.php | ||
| ArcanistExternalLinter.php | ||
| ArcanistFilenameLinter.php | ||
| ArcanistFlake8Linter.php | ||
| ArcanistFutureLinter.php | ||
| ArcanistGeneratedLinter.php | ||
| ArcanistGoLintLinter.php | ||
| ArcanistHLintLinter.php | ||
| ArcanistJscsLinter.php | ||
| ArcanistJSHintLinter.php | ||
| ArcanistJSONLinter.php | ||
| ArcanistJSONLintLinter.php | ||
| ArcanistLesscLinter.php | ||
| ArcanistLinter.php | ||
| ArcanistMergeConflictLinter.php | ||
| ArcanistNoLintLinter.php | ||
| ArcanistPEP8Linter.php | ||
| ArcanistPhpcsLinter.php | ||
| ArcanistPhpLinter.php | ||
| ArcanistPhutilLibraryLinter.php | ||
| ArcanistPhutilXHPASTLinter.php | ||
| ArcanistPuppetLintLinter.php | ||
| ArcanistPyFlakesLinter.php | ||
| ArcanistPyLintLinter.php | ||
| ArcanistRuboCopLinter.php | ||
| ArcanistRubyLinter.php | ||
| ArcanistScriptAndRegexLinter.php | ||
| ArcanistSpellingLinter.php | ||
| ArcanistTextLinter.php | ||
| ArcanistXHPASTLinter.php | ||
| ArcanistXMLLinter.php | ||
| reporter.js | ||