1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-07 21:31:01 +01:00
phorge-arcanist/src/lint
John Allen aeb374b333 Fix cpplint message regex
Summary:
ref T8404

The issue is caused, not by the non-zero return code, but by the fact that
$messages is coming back empty due to the incorrect regex. tyhoff pointed out
that the regex matched correctly when we used STDIN, but now it is failing.

https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistExternalLinter.php;8c589f1f759f0913135b8cc6959a6c1589e14ae4$357

Test Plan:
arc lint cpp file containing lint error. run cpplint on the
file directly to confirm that there are errors and that the return code
is non-zero

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T8404

Differential Revision: https://secure.phabricator.com/D14960
2016-01-06 13:15:09 -08:00
..
engine Improve validation of 'name' and 'code' parameters for lint messages 2015-09-25 11:16:04 -07:00
linter Fix cpplint message regex 2016-01-06 13:15:09 -08:00
renderer Fix checkstyle severities 2015-07-23 09:14:16 +10:00
ArcanistLintMessage.php Improve validation of 'name' and 'code' parameters for lint messages 2015-09-25 11:16:04 -07:00
ArcanistLintPatcher.php Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistLintResult.php Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistLintSeverity.php Extend from Phobject 2015-06-15 15:47:33 +10:00