1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-10-23 00:58:50 +02:00
No description
Find a file
Valerio Bozzolan b3d45c7104 ArcanistBundleTestCase: fix support of non-English environments
Summary:
Recently this unit test was always failing for some specific users.
I was able to reproduce the issue with an Italian unix environment:

    arc unit src/parser/__tests__/ArcanistBundleTestCase.php

Obtaining:

    counterexample
    EXCEPTION (Exception): Diff Parse Exception: Expected '\ No newline at end of file'.

After this change, the involved unit test always work also in my Italian environment.

Note that the `LC_ALL=C` means that all localization should be deactivated,
and we should instead use C-sourced strings (not translated in any language). Nice!

Closes T15927

Test Plan: Run the unit test. It does not fail anymore if you are Italian of French or whatever.

Reviewers: O1 Blessed Committers, mainframe98, 20after4

Reviewed By: O1 Blessed Committers, mainframe98, 20after4

Subscribers: mainframe98, aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15927

Differential Revision: https://we.phorge.it/D25809
2024-10-21 07:35:14 +02:00
bin When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code 2020-02-27 06:17:02 -08:00
externals Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards 2023-06-02 18:30:58 +02:00
resources Add resources/ssl/custom.pem to .gitignore 2023-06-21 19:56:55 +01:00
scripts Remove all product name literals in "pht()" in Arcanist 2022-04-25 12:21:31 -07:00
src ArcanistBundleTestCase: fix support of non-English environments 2024-10-21 07:35:14 +02:00
support Correct call to non-existing PhutilFileLockException in support/unit/lock.php 2024-05-30 14:36:03 +02:00
.arcconfig Arcanist Update .arcconfig to point to we.phorge.it 2021-06-19 18:10:39 +00:00
.arclint Add new "Hardpoint" classes to support request parallelization 2020-04-08 09:23:50 -07:00
.arcunit Rough version of configuration driven unit test engine 2015-08-11 06:54:16 +10:00
.editorconfig Test XHPAST linter rules in isolation 2015-11-19 08:57:23 +11:00
.gitignore Add resources/ssl/custom.pem to .gitignore 2023-06-21 19:56:55 +01:00
LICENSE Fix text lint issues 2015-04-07 18:09:27 +10:00
NOTICE Remove duplicate newline 2014-07-17 08:25:22 +10:00
README.md Update arcanist readme to reference Phorge 2021-06-20 15:20:47 -06:00

Arcanist is the command-line tool for Phorge. It allows you to interact with Phorge installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can read more in the User Guide

For more information about Phorge, see https://phorge.it/.

LICENSE

Arcanist is released under the Apache 2.0 license except as otherwise noted.