1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
No description
Find a file
Joshua Spence d477df00eb Add a linter rule to detect the use of blacklisted functions
Summary:
As mentioned in the [[https://secure.phabricator.com/book/phabcontrib/article/php_coding_standards/ | Phabricator PHP coding standards]], the `eval` function should be avoided. There is some good discussion on [[http://stackoverflow.com/questions/951373/when-is-eval-evil-in-php | StackOverflow]] as well.

Having said that, instead of hardcoding `eval()`, I have generalised this enough to allow a set of "blacklisted" functions to be defined with `xhpast.blacklisted.function` in the `.arclint` file.

Test Plan: Added a test case.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D10686
2015-01-05 10:51:33 +11:00
bin Added ArcanistTextLinter::LINT_BOF_WHITESPACE and ArcanistTextLinter::LINT_EOF_WHITESPACE 2014-01-13 18:05:42 -08:00
externals Add a newline to externals/includes/README 2014-07-16 22:11:52 +10:00
resources Add some more spelling corrections to Spelling linter 2014-12-22 16:08:02 -08:00
scripts Support simpler, token-based Conduit authentication in Arcanist 2014-12-15 11:12:38 -08:00
src Add a linter rule to detect the use of blacklisted functions 2015-01-05 10:51:33 +11:00
.arcconfig Use the ArcanistConfigurationDrivenLintEngine as a linting engine. 2014-05-11 19:33:40 -07:00
.arclint Add a linter rule to detect the use of blacklisted functions 2015-01-05 10:51:33 +11:00
.editorconfig Apply various linter fixes. 2014-06-10 11:02:42 -07:00
.gitignore Update .gitignore. 2014-06-14 11:44:38 -07:00
LICENSE Delete license headers from files 2012-11-05 11:16:24 -08:00
NOTICE Remove duplicate newline 2014-07-17 08:25:22 +10:00
README Reformat README as Remarkup 2014-07-16 22:11:10 +10:00

= WHAT IS ARCANIST? =

Arcanist is the command-line tool for [[http://phabricator.org/ | Phabricator]].
It allows you to interact with Phabricator installs to send code for review,
download patches, transfer files, view status, make API calls, and various other
things. You can find a complete user guide
[[http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html |
here]].

For more information about Phabricator, see http://phabricator.org/.

= LICENSE =
Arcanist is released under the Apache 2.0 license except as otherwise noted.