1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
phorge-arcanist/src
Andre Klapper f974927377 Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]
```

Refs T15926

Test Plan: Either read the code, or probably run something like `arc unit` on D25797?

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15926

Differential Revision: https://we.phorge.it/D25800
2024-09-03 12:08:10 +02:00
..
__tests__ Catch more product names in "pht()", and replace newly matched Arcanist product names 2022-04-25 16:45:55 -07:00
browse Improve arc-browse for php 8.1 2023-07-07 09:16:59 -07:00
channel Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
conduit Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
config Remove all product name literals in "pht()" in Arcanist 2022-04-25 12:21:31 -07:00
configuration Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
console Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
difference Fix an initialization issue in VectorTree 2020-05-04 15:50:26 -07:00
differential Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
docs Update Diviner documentation to reference Phorge instead of Phabricator for Arcanist. 2021-06-19 18:46:39 -06:00
engine Implement "arc work", to replace "arc feature" 2020-06-08 16:27:27 -07:00
error Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
events Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
exception Provide some "preg_*" wrappers which raise exceptions on failure 2021-02-19 11:16:09 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
filesystem Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
future Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
hardpoint Fix additional "xsprintf()"-family static parameter errors 2020-09-08 11:45:54 -07:00
hgdaemon Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
init Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
inspector Support inspection of remote refs with "arc inspect remote(...)" 2020-06-30 13:07:25 -07:00
internationalization Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
ip Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
land Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
lexer Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
lint Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
log Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
moduleutils Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
object Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
parser Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase 2024-09-03 12:08:10 +02:00
phage Fix $boot_length comparison in PhagePHPAgentBootloader 2024-08-15 20:24:47 +02:00
platform Rebrand: Add "path" entries to PlatformSymbols 2023-08-12 08:41:53 -07:00
progress Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
query Provide "gitsprintf(...)" and disambiguate Git ref selectors 2021-01-13 12:31:15 -08:00
readableserializer Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
ref Improve arc-browse for php 8.1 2023-07-07 09:16:59 -07:00
repository Remove unused ArcanistGitLocalState::getDisplayStashRef() 2024-09-02 08:55:45 +02:00
runtime Replace all phurl.io short URIs with target URIs 2024-02-28 14:59:26 +01:00
serviceprofiler Provide additional Arcanist PHP 8.1 fixes 2021-12-09 16:42:19 -08:00
symbols Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
toolset Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine 2024-06-23 10:03:01 +02:00
unit Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
upload Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
utils Remove an outdated PHP 5.3 check in utils 2024-08-26 16:36:54 +02:00
work Update "arc land" display of build failures, and rename "DisplayRef" to "RefView" 2020-06-30 06:27:56 -07:00
workflow Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
workingcopy Declare missing class properties 2024-07-03 09:05:34 +02:00
workingcopyidentity Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
xsprintf Add missing variable names to PHPDoc @param of methods 2024-08-23 18:52:13 +02:00
__phutil_library_init__.php Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
__phutil_library_map__.php Add "pht_list()", a translation wrapper for lists of items 2022-05-12 10:57:39 -07:00