2011-02-06 23:00:32 +01:00
|
|
|
<?php
|
|
|
|
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
final class DifferentialUpdateRevisionConduitAPIMethod
|
|
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
|
|
|
|
public function getAPIMethodName() {
|
|
|
|
return 'differential.updaterevision';
|
|
|
|
}
|
2011-02-06 23:00:32 +01:00
|
|
|
|
|
|
|
public function getMethodDescription() {
|
2014-06-09 20:36:49 +02:00
|
|
|
return pht('Update a Differential revision.');
|
2011-02-06 23:00:32 +01:00
|
|
|
}
|
|
|
|
|
2017-01-08 21:54:39 +01:00
|
|
|
public function getMethodStatus() {
|
|
|
|
return self::METHOD_STATUS_FROZEN;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getMethodStatusDescription() {
|
|
|
|
return pht(
|
|
|
|
'This method is frozen and will eventually be deprecated. New code '.
|
|
|
|
'should use "differential.revision.edit" instead.');
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineParamTypes() {
|
2011-02-06 23:00:32 +01:00
|
|
|
return array(
|
|
|
|
'id' => 'required revisionid',
|
|
|
|
'diffid' => 'required diffid',
|
|
|
|
'fields' => 'required dict',
|
|
|
|
'message' => 'required string',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineReturnType() {
|
2011-02-06 23:00:32 +01:00
|
|
|
return 'nonempty dict';
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineErrorTypes() {
|
2011-02-06 23:00:32 +01:00
|
|
|
return array(
|
2015-05-22 09:27:56 +02:00
|
|
|
'ERR_BAD_DIFF' => pht('Bad diff ID.'),
|
|
|
|
'ERR_BAD_REVISION' => pht('Bad revision ID.'),
|
|
|
|
'ERR_WRONG_USER' => pht('You are not the author of this revision.'),
|
|
|
|
'ERR_CLOSED' => pht('This revision has already been closed.'),
|
2011-02-06 23:00:32 +01:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
2014-03-08 19:51:01 +01:00
|
|
|
$viewer = $request->getUser();
|
|
|
|
|
2013-07-01 21:38:42 +02:00
|
|
|
$diff = id(new DifferentialDiffQuery())
|
2014-03-08 19:51:01 +01:00
|
|
|
->setViewer($viewer)
|
2013-07-01 21:38:42 +02:00
|
|
|
->withIDs(array($request->getValue('diffid')))
|
|
|
|
->executeOne();
|
2011-02-06 23:00:32 +01:00
|
|
|
if (!$diff) {
|
|
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
|
|
}
|
|
|
|
|
2013-07-01 21:38:42 +02:00
|
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
|
|
->setViewer($request->getUser())
|
|
|
|
->withIDs(array($request->getValue('id')))
|
2017-03-20 22:37:24 +01:00
|
|
|
->needReviewers(true)
|
2014-03-08 19:51:01 +01:00
|
|
|
->needActiveDiffs(true)
|
|
|
|
->requireCapabilities(
|
|
|
|
array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
))
|
2013-07-01 21:38:42 +02:00
|
|
|
->executeOne();
|
2011-08-15 03:52:09 +02:00
|
|
|
if (!$revision) {
|
|
|
|
throw new ConduitException('ERR_BAD_REVISION');
|
|
|
|
}
|
2011-02-06 23:00:32 +01:00
|
|
|
|
2017-08-04 17:20:20 +02:00
|
|
|
if ($revision->isPublished()) {
|
2012-04-24 02:40:57 +02:00
|
|
|
throw new ConduitException('ERR_CLOSED');
|
2011-04-08 02:03:41 +02:00
|
|
|
}
|
2011-02-06 23:00:32 +01:00
|
|
|
|
2014-03-08 20:21:38 +01:00
|
|
|
$this->applyFieldEdit(
|
|
|
|
$request,
|
2014-03-08 19:51:01 +01:00
|
|
|
$revision,
|
2014-03-08 20:21:38 +01:00
|
|
|
$diff,
|
|
|
|
$request->getValue('fields', array()),
|
|
|
|
$request->getValue('message'));
|
2011-02-06 23:00:32 +01:00
|
|
|
|
|
|
|
return array(
|
|
|
|
'revisionid' => $revision->getID(),
|
|
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|