2011-01-16 22:51:39 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
2012-01-04 16:35:52 +01:00
|
|
|
* Copyright 2012 Facebook, Inc.
|
2011-01-16 22:51:39 +01:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2012-03-14 00:21:04 +01:00
|
|
|
final class PhabricatorStandardPageView extends AphrontPageView {
|
2011-01-16 22:51:39 +01:00
|
|
|
|
|
|
|
private $baseURI;
|
|
|
|
private $applicationName;
|
|
|
|
private $glyph;
|
2011-01-25 18:59:31 +01:00
|
|
|
private $bodyContent;
|
2012-07-31 15:18:38 +02:00
|
|
|
private $menuContent;
|
2011-01-26 22:21:12 +01:00
|
|
|
private $request;
|
2011-05-12 19:06:54 +02:00
|
|
|
private $isAdminInterface;
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
private $showChrome = true;
|
2011-07-09 18:45:19 +02:00
|
|
|
private $isFrameable = false;
|
|
|
|
private $disableConsole;
|
2012-02-15 02:00:12 +01:00
|
|
|
private $searchDefaultScope;
|
2012-06-14 02:28:21 +02:00
|
|
|
private $pageObjects = array();
|
2012-08-05 23:12:43 +02:00
|
|
|
private $controller;
|
2012-08-15 19:45:06 +02:00
|
|
|
private $deviceReady;
|
|
|
|
|
|
|
|
public function setDeviceReady($device_ready) {
|
|
|
|
$this->deviceReady = $device_ready;
|
|
|
|
return $this;
|
|
|
|
}
|
2012-08-05 23:12:43 +02:00
|
|
|
|
|
|
|
public function setController(AphrontController $controller) {
|
|
|
|
$this->controller = $controller;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getController() {
|
|
|
|
return $this->controller;
|
|
|
|
}
|
2011-05-12 19:06:54 +02:00
|
|
|
|
|
|
|
public function setIsAdminInterface($is_admin_interface) {
|
|
|
|
$this->isAdminInterface = $is_admin_interface;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getIsAdminInterface() {
|
|
|
|
return $this->isAdminInterface;
|
|
|
|
}
|
2011-01-26 22:21:12 +01:00
|
|
|
|
|
|
|
public function setRequest($request) {
|
|
|
|
$this->request = $request;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getRequest() {
|
|
|
|
return $this->request;
|
|
|
|
}
|
2011-01-16 22:51:39 +01:00
|
|
|
|
|
|
|
public function setApplicationName($application_name) {
|
|
|
|
$this->applicationName = $application_name;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-07-09 18:45:19 +02:00
|
|
|
public function setFrameable($frameable) {
|
|
|
|
$this->isFrameable = $frameable;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setDisableConsole($disable) {
|
|
|
|
$this->disableConsole = $disable;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-16 22:51:39 +01:00
|
|
|
public function getApplicationName() {
|
|
|
|
return $this->applicationName;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setBaseURI($base_uri) {
|
|
|
|
$this->baseURI = $base_uri;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getBaseURI() {
|
|
|
|
return $this->baseURI;
|
|
|
|
}
|
|
|
|
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
public function setShowChrome($show_chrome) {
|
|
|
|
$this->showChrome = $show_chrome;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getShowChrome() {
|
|
|
|
return $this->showChrome;
|
|
|
|
}
|
|
|
|
|
2012-02-15 02:00:12 +01:00
|
|
|
public function setSearchDefaultScope($search_default_scope) {
|
|
|
|
$this->searchDefaultScope = $search_default_scope;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getSearchDefaultScope() {
|
|
|
|
return $this->searchDefaultScope;
|
|
|
|
}
|
|
|
|
|
2012-06-14 02:28:21 +02:00
|
|
|
public function appendPageObjects(array $objs) {
|
|
|
|
foreach ($objs as $obj) {
|
|
|
|
$this->pageObjects[] = $obj;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-01-16 22:51:39 +01:00
|
|
|
public function getTitle() {
|
2011-03-31 04:21:09 +02:00
|
|
|
$use_glyph = true;
|
|
|
|
$request = $this->getRequest();
|
|
|
|
if ($request) {
|
|
|
|
$user = $request->getUser();
|
|
|
|
if ($user && $user->loadPreferences()->getPreference(
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_TITLES) !== 'glyph') {
|
|
|
|
$use_glyph = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return ($use_glyph ?
|
|
|
|
$this->getGlyph() : '['.$this->getApplicationName().']').
|
|
|
|
' '.parent::getTitle();
|
2011-01-16 22:51:39 +01:00
|
|
|
}
|
|
|
|
|
2011-01-25 20:31:40 +01:00
|
|
|
|
2011-01-25 18:59:31 +01:00
|
|
|
protected function willRenderPage() {
|
2011-02-02 22:48:52 +01:00
|
|
|
|
|
|
|
if (!$this->getRequest()) {
|
|
|
|
throw new Exception(
|
|
|
|
"You must set the Request to render a PhabricatorStandardPageView.");
|
|
|
|
}
|
|
|
|
|
2011-07-09 18:45:19 +02:00
|
|
|
$console = $this->getConsole();
|
2011-02-02 22:48:52 +01:00
|
|
|
|
2011-01-25 18:59:31 +01:00
|
|
|
require_celerity_resource('phabricator-core-css');
|
2012-08-14 23:20:01 +02:00
|
|
|
require_celerity_resource('autosprite-css');
|
2011-01-25 20:31:40 +01:00
|
|
|
require_celerity_resource('phabricator-core-buttons-css');
|
|
|
|
require_celerity_resource('phabricator-standard-page-view');
|
|
|
|
|
Prevent CSRF uploads via /file/dropupload/
Summary:
We don't currently validate CSRF tokens on this workflow. This allows an
attacker to upload arbitrary files on the user's behalf. Although I believe the
tight list of servable mime-types means that's more or less the end of the
attack, this is still a vulnerability.
In the long term, the right solution is probably to pass CSRF tokens on all Ajax
requests in an HTTP header (or just a GET param) or something like that.
However, this endpoint is unique and this is the quickest and most direct way to
close the hole.
Test Plan:
- Drop-uploaded files to Files, Maniphest, Phriction and Differential.
- Modified CSRF vaidator to use __csrf__.'x' and verified uploads and form
submissions don't work.
Reviewers: andrewjcg, aran, jungejason, tuomaspelkonen, erling
Commenters: andrewjcg, pedram
CC: aran, epriestley, andrewjcg, pedram
Differential Revision: 758
2011-08-02 05:23:01 +02:00
|
|
|
$current_token = null;
|
|
|
|
$request = $this->getRequest();
|
|
|
|
if ($request) {
|
|
|
|
$user = $request->getUser();
|
|
|
|
if ($user) {
|
|
|
|
$current_token = $user->getCSRFToken();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-02-05 20:45:13 +01:00
|
|
|
Javelin::initBehavior('workflow', array());
|
2012-07-31 01:08:42 +02:00
|
|
|
Javelin::initBehavior('toggle-class', array());
|
Prevent CSRF uploads via /file/dropupload/
Summary:
We don't currently validate CSRF tokens on this workflow. This allows an
attacker to upload arbitrary files on the user's behalf. Although I believe the
tight list of servable mime-types means that's more or less the end of the
attack, this is still a vulnerability.
In the long term, the right solution is probably to pass CSRF tokens on all Ajax
requests in an HTTP header (or just a GET param) or something like that.
However, this endpoint is unique and this is the quickest and most direct way to
close the hole.
Test Plan:
- Drop-uploaded files to Files, Maniphest, Phriction and Differential.
- Modified CSRF vaidator to use __csrf__.'x' and verified uploads and form
submissions don't work.
Reviewers: andrewjcg, aran, jungejason, tuomaspelkonen, erling
Commenters: andrewjcg, pedram
CC: aran, epriestley, andrewjcg, pedram
Differential Revision: 758
2011-08-02 05:23:01 +02:00
|
|
|
Javelin::initBehavior(
|
|
|
|
'refresh-csrf',
|
|
|
|
array(
|
|
|
|
'tokenName' => AphrontRequest::getCSRFTokenName(),
|
|
|
|
'header' => AphrontRequest::getCSRFHeaderName(),
|
|
|
|
'current' => $current_token,
|
|
|
|
));
|
2012-07-31 15:18:38 +02:00
|
|
|
Javelin::initBehavior('device', array('id' => 'base-page'));
|
2012-03-15 04:47:17 +01:00
|
|
|
|
2011-02-02 22:48:52 +01:00
|
|
|
if ($console) {
|
|
|
|
require_celerity_resource('aphront-dark-console-css');
|
|
|
|
Javelin::initBehavior(
|
|
|
|
'dark-console',
|
|
|
|
array(
|
2012-05-25 19:14:17 +02:00
|
|
|
'uri' => '/~/',
|
|
|
|
'request_uri' => $request ? (string) $request->getRequestURI() : '/',
|
2011-02-02 22:48:52 +01:00
|
|
|
));
|
2011-04-05 21:24:21 +02:00
|
|
|
|
|
|
|
// Change this to initBehavior when there is some behavior to initialize
|
|
|
|
require_celerity_resource('javelin-behavior-error-log');
|
2011-02-02 22:48:52 +01:00
|
|
|
}
|
|
|
|
|
2012-07-31 15:18:38 +02:00
|
|
|
$this->menuContent = $this->renderMainMenu();
|
2011-01-25 18:59:31 +01:00
|
|
|
$this->bodyContent = $this->renderChildren();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-01-16 22:51:39 +01:00
|
|
|
protected function getHead() {
|
2011-07-09 18:45:19 +02:00
|
|
|
|
|
|
|
$framebust = null;
|
|
|
|
if (!$this->isFrameable) {
|
|
|
|
$framebust = '(top != self) && top.location.replace(self.location.href);';
|
|
|
|
}
|
|
|
|
|
2011-01-25 18:59:31 +01:00
|
|
|
$response = CelerityAPI::getStaticResourceResponse();
|
2012-07-07 00:39:43 +02:00
|
|
|
|
|
|
|
$monospaced = PhabricatorEnv::getEnvConfig('style.monospace');
|
2011-03-31 04:21:09 +02:00
|
|
|
|
|
|
|
$request = $this->getRequest();
|
|
|
|
if ($request) {
|
|
|
|
$user = $request->getUser();
|
|
|
|
if ($user) {
|
2012-07-07 00:39:43 +02:00
|
|
|
$monospaced = nonempty(
|
|
|
|
$user->loadPreferences()->getPreference(
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_MONOSPACED),
|
|
|
|
$monospaced);
|
2011-03-31 04:21:09 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-07-25 20:51:27 +02:00
|
|
|
$viewport_tag = null;
|
2012-08-15 19:45:06 +02:00
|
|
|
if (PhabricatorEnv::getEnvConfig('preview.viewport-meta-tag') ||
|
|
|
|
$this->deviceReady) {
|
2012-07-25 20:51:27 +02:00
|
|
|
$viewport_tag = phutil_render_tag(
|
|
|
|
'meta',
|
|
|
|
array(
|
|
|
|
'name' => 'viewport',
|
2012-08-15 19:45:06 +02:00
|
|
|
'content' => 'width=device-width, '.
|
|
|
|
'initial-scale=1, '.
|
|
|
|
'maximum-scale=1',
|
2012-07-25 20:51:27 +02:00
|
|
|
));
|
|
|
|
}
|
|
|
|
|
2012-07-07 00:39:43 +02:00
|
|
|
$head =
|
2012-07-25 20:51:27 +02:00
|
|
|
$viewport_tag.
|
2012-07-07 00:39:43 +02:00
|
|
|
'<script type="text/javascript">'.
|
|
|
|
$framebust.
|
|
|
|
'window.__DEV__=1;'.
|
|
|
|
'</script>'.
|
|
|
|
$response->renderResourcesOfType('css').
|
|
|
|
'<style type="text/css">'.
|
|
|
|
'.PhabricatorMonospaced { font: '.$monospaced.'; }'.
|
|
|
|
'</style>'.
|
|
|
|
$response->renderSingleResource('javelin-magical-init');
|
|
|
|
|
2011-03-31 04:21:09 +02:00
|
|
|
return $head;
|
2011-01-16 22:51:39 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function setGlyph($glyph) {
|
|
|
|
$this->glyph = $glyph;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getGlyph() {
|
|
|
|
return $this->glyph;
|
|
|
|
}
|
|
|
|
|
2011-02-02 22:48:52 +01:00
|
|
|
protected function willSendResponse($response) {
|
|
|
|
$console = $this->getRequest()->getApplicationConfiguration()->getConsole();
|
|
|
|
if ($console) {
|
|
|
|
$response = str_replace(
|
|
|
|
'<darkconsole />',
|
|
|
|
$console->render($this->getRequest()),
|
|
|
|
$response);
|
|
|
|
}
|
|
|
|
return $response;
|
|
|
|
}
|
|
|
|
|
2011-01-16 22:51:39 +01:00
|
|
|
protected function getBody() {
|
2011-07-09 18:45:19 +02:00
|
|
|
$console = $this->getConsole();
|
2011-01-16 22:51:39 +01:00
|
|
|
|
2011-01-26 22:21:12 +01:00
|
|
|
$login_stuff = null;
|
|
|
|
$request = $this->getRequest();
|
2011-02-27 05:57:21 +01:00
|
|
|
$user = null;
|
2011-01-26 02:17:19 +01:00
|
|
|
if ($request) {
|
|
|
|
$user = $request->getUser();
|
2011-02-27 05:57:21 +01:00
|
|
|
// NOTE: user may not be set here if we caught an exception early
|
|
|
|
// in the execution workflow.
|
|
|
|
if ($user && $user->getPHID()) {
|
2011-01-31 03:52:29 +01:00
|
|
|
$login_stuff =
|
2011-06-10 19:18:27 +02:00
|
|
|
phutil_render_tag(
|
2011-02-22 20:06:37 +01:00
|
|
|
'a',
|
|
|
|
array(
|
|
|
|
'href' => '/p/'.$user->getUsername().'/',
|
|
|
|
),
|
|
|
|
phutil_escape_html($user->getUsername())).
|
2011-01-31 03:52:29 +01:00
|
|
|
' · '.
|
2011-02-05 03:24:03 +01:00
|
|
|
'<a href="/settings/">Settings</a>'.
|
|
|
|
' · '.
|
2011-02-15 00:34:20 +01:00
|
|
|
phabricator_render_form(
|
|
|
|
$user,
|
|
|
|
array(
|
|
|
|
'action' => '/search/',
|
|
|
|
'method' => 'post',
|
|
|
|
'style' => 'display: inline',
|
|
|
|
),
|
2012-07-31 01:09:14 +02:00
|
|
|
'<div class="menu-section menu-section-search">'.
|
|
|
|
'<div class="menu-search-container">'.
|
|
|
|
'<input type="text" name="query" id="standard-search-box" />'.
|
|
|
|
'<button id="standard-search-button">Search</button>'.
|
|
|
|
'</div>'.
|
|
|
|
'</div>'.
|
2012-02-15 02:00:12 +01:00
|
|
|
' in '.
|
|
|
|
AphrontFormSelectControl::renderSelectTag(
|
|
|
|
$this->getSearchDefaultScope(),
|
|
|
|
PhabricatorSearchScope::getScopeOptions(),
|
|
|
|
array(
|
|
|
|
'name' => 'scope',
|
|
|
|
)).
|
|
|
|
' '.
|
2011-02-15 00:34:20 +01:00
|
|
|
'<button>Search</button>');
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-26 22:21:12 +01:00
|
|
|
}
|
2011-02-05 21:20:18 +01:00
|
|
|
|
2011-05-12 19:06:54 +02:00
|
|
|
$admin_class = null;
|
|
|
|
if ($this->getIsAdminInterface()) {
|
|
|
|
$admin_class = 'phabricator-admin-page-view';
|
|
|
|
}
|
|
|
|
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
$header_chrome = null;
|
|
|
|
$footer_chrome = null;
|
|
|
|
if ($this->getShowChrome()) {
|
2012-07-31 15:18:38 +02:00
|
|
|
$header_chrome = $this->menuContent;
|
2012-08-15 19:45:06 +02:00
|
|
|
|
|
|
|
if (!$this->deviceReady) {
|
|
|
|
$footer_chrome = $this->renderFooter();
|
|
|
|
}
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
}
|
|
|
|
|
2012-01-04 16:35:52 +01:00
|
|
|
$developer_warning = null;
|
|
|
|
if (PhabricatorEnv::getEnvConfig('phabricator.show-error-callout') &&
|
|
|
|
DarkConsoleErrorLogPluginAPI::getErrors()) {
|
|
|
|
$developer_warning =
|
|
|
|
'<div class="aphront-developer-error-callout">'.
|
|
|
|
'This page raised PHP errors. Find them in DarkConsole '.
|
|
|
|
'or the error log.'.
|
|
|
|
'</div>';
|
|
|
|
}
|
|
|
|
|
2012-07-25 20:51:27 +02:00
|
|
|
$agent = idx($_SERVER, 'HTTP_USER_AGENT');
|
|
|
|
|
|
|
|
// Try to guess the device resolution based on UA strings to avoid a flash
|
|
|
|
// of incorrectly-styled content.
|
|
|
|
$device_guess = 'device-desktop';
|
|
|
|
if (preg_match('/iPhone|iPod/', $agent)) {
|
|
|
|
$device_guess = 'device-phone';
|
|
|
|
} else if (preg_match('/iPad/', $agent)) {
|
|
|
|
$device_guess = 'device-tablet';
|
|
|
|
}
|
|
|
|
|
|
|
|
$classes = array(
|
|
|
|
'phabricator-standard-page',
|
|
|
|
$admin_class,
|
|
|
|
$device_guess,
|
|
|
|
);
|
|
|
|
$classes = implode(' ', $classes);
|
|
|
|
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
return
|
2012-07-25 20:51:27 +02:00
|
|
|
phutil_render_tag(
|
|
|
|
'div',
|
|
|
|
array(
|
|
|
|
'id' => 'base-page',
|
|
|
|
'class' => $classes,
|
|
|
|
),
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
$header_chrome.
|
2012-07-31 16:04:26 +02:00
|
|
|
'<div class="phabricator-main-menu-spacer"></div>'.
|
2012-07-31 01:09:14 +02:00
|
|
|
'<div class="phabricator-standard-page-body">'.
|
|
|
|
($console ? '<darkconsole />' : null).
|
|
|
|
$developer_warning.
|
|
|
|
$this->bodyContent.
|
|
|
|
'<div style="clear: both;"></div>'.
|
|
|
|
'</div>').
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
$footer_chrome;
|
2011-01-16 22:51:39 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
protected function getTail() {
|
2012-07-31 01:09:14 +02:00
|
|
|
$request = $this->getRequest();
|
|
|
|
$user = $request->getUser();
|
|
|
|
|
|
|
|
$container = null;
|
|
|
|
if (PhabricatorEnv::getEnvConfig('notification.enabled') &&
|
|
|
|
$user->isLoggedIn()) {
|
|
|
|
|
|
|
|
$aphlict_object_id = celerity_generate_unique_node_id();
|
|
|
|
$aphlict_container_id = celerity_generate_unique_node_id();
|
|
|
|
|
|
|
|
$client_uri = PhabricatorEnv::getEnvConfig('notification.client-uri');
|
|
|
|
$client_uri = new PhutilURI($client_uri);
|
|
|
|
if ($client_uri->getDomain() == 'localhost') {
|
|
|
|
$this_host = $this->getRequest()->getHost();
|
|
|
|
$this_host = new PhutilURI('http://'.$this_host.'/');
|
|
|
|
$client_uri->setDomain($this_host->getDomain());
|
|
|
|
}
|
|
|
|
|
|
|
|
$enable_debug = PhabricatorEnv::getEnvConfig('notification.debug');
|
|
|
|
Javelin::initBehavior(
|
|
|
|
'aphlict-listen',
|
|
|
|
array(
|
|
|
|
'id' => $aphlict_object_id,
|
|
|
|
'containerID' => $aphlict_container_id,
|
|
|
|
'server' => $client_uri->getDomain(),
|
|
|
|
'port' => $client_uri->getPort(),
|
|
|
|
'debug' => $enable_debug,
|
|
|
|
'pageObjects' => array_fill_keys($this->pageObjects, true),
|
|
|
|
));
|
|
|
|
$container = phutil_render_tag(
|
|
|
|
'div',
|
|
|
|
array(
|
|
|
|
'id' => $aphlict_container_id,
|
|
|
|
'style' => 'position: absolute; width: 0; height: 0;',
|
|
|
|
),
|
2012-07-31 15:18:38 +02:00
|
|
|
'');
|
2012-07-31 01:09:14 +02:00
|
|
|
}
|
|
|
|
|
2011-01-25 18:59:31 +01:00
|
|
|
$response = CelerityAPI::getStaticResourceResponse();
|
|
|
|
return
|
|
|
|
$response->renderResourcesOfType('js').
|
2012-07-31 01:09:14 +02:00
|
|
|
$container.
|
2011-01-25 20:57:47 +01:00
|
|
|
$response->renderHTMLFooter();
|
2011-01-16 22:51:39 +01:00
|
|
|
}
|
|
|
|
|
Countdown tweaks
Summary:
A few tweaks to hsb's Countdown implementation:
- Allow the page to be rendered "chromeless", suitable for display on one of
the dozens of monitors everyone has laying around.
- Show title of countdown in deletion dialog.
- When creating a new countdown default to time(), not Dec 31, 1969.
- Add extra "/" after editing to avoid needless redirect.
- Tweak some page titles.
- Show countdown author in list view.
- Highlight tab in list view.
- Tweak menu copy.
- Link countdown title in list view, separate buttons into different columns
so they pick up padding.
Test Plan:
Created, edited and deleted a timer. Viewed a timer and toggled chrome mode.
Viewed timer list.
Reviewed By: hsb
Reviewers: hsb, aran, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 454
2011-06-14 02:35:13 +02:00
|
|
|
protected function getBodyClasses() {
|
|
|
|
$classes = array();
|
|
|
|
|
|
|
|
if (!$this->getShowChrome()) {
|
|
|
|
$classes[] = 'phabricator-chromeless-page';
|
|
|
|
}
|
|
|
|
|
|
|
|
return implode(' ', $classes);
|
|
|
|
}
|
|
|
|
|
2011-07-09 18:45:19 +02:00
|
|
|
private function getConsole() {
|
|
|
|
if ($this->disableConsole) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
return $this->getRequest()->getApplicationConfiguration()->getConsole();
|
|
|
|
}
|
2012-07-31 01:09:14 +02:00
|
|
|
|
|
|
|
private function renderMainMenu() {
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$user = $request->getUser();
|
|
|
|
|
|
|
|
$menu = new PhabricatorMainMenuView();
|
|
|
|
$menu->setUser($user);
|
|
|
|
|
|
|
|
$keyboard_config = array(
|
|
|
|
'helpURI' => '/help/keyboardshortcut/',
|
|
|
|
);
|
|
|
|
|
|
|
|
if ($user->isLoggedIn()) {
|
|
|
|
$search = new PhabricatorMainMenuSearchView();
|
|
|
|
$search->setUser($user);
|
|
|
|
$search->setScope($this->getSearchDefaultScope());
|
|
|
|
$menu->appendChild($search);
|
|
|
|
|
|
|
|
$pref_shortcut = PhabricatorUserPreferences::PREFERENCE_SEARCH_SHORTCUT;
|
|
|
|
if ($user->loadPreferences()->getPreference($pref_shortcut, true)) {
|
|
|
|
$keyboard_config['searchID'] = $search->getID();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
Javelin::initBehavior('phabricator-keyboard-shortcuts', $keyboard_config);
|
|
|
|
|
2012-08-05 23:12:43 +02:00
|
|
|
$applications = PhabricatorApplication::getAllInstalledApplications();
|
|
|
|
$icon_views = array();
|
|
|
|
foreach ($applications as $application) {
|
|
|
|
$icon_views[] = $application->buildMainMenuItems(
|
|
|
|
$this->getRequest()->getUser(),
|
|
|
|
$this->getController());
|
2012-07-31 01:09:14 +02:00
|
|
|
}
|
2012-08-05 23:12:43 +02:00
|
|
|
$icon_views = array_mergev($icon_views);
|
|
|
|
$icon_views = msort($icon_views, 'getSortOrder');
|
|
|
|
|
|
|
|
$menu->appendChild($icon_views);
|
2012-07-31 01:09:14 +02:00
|
|
|
|
|
|
|
return $menu->render();
|
|
|
|
}
|
|
|
|
|
2012-08-15 19:45:06 +02:00
|
|
|
public function renderFooter() {
|
|
|
|
$console = $this->getConsole();
|
|
|
|
|
|
|
|
$foot_links = array();
|
|
|
|
|
|
|
|
$version = PhabricatorEnv::getEnvConfig('phabricator.version');
|
|
|
|
$foot_links[] = phutil_escape_html('Phabricator '.$version);
|
|
|
|
|
|
|
|
$foot_links[] =
|
|
|
|
'<a href="https://secure.phabricator.com/maniphest/task/create/">'.
|
|
|
|
'Report a Bug'.
|
|
|
|
'</a>';
|
|
|
|
|
|
|
|
if (PhabricatorEnv::getEnvConfig('darkconsole.enabled') &&
|
|
|
|
!PhabricatorEnv::getEnvConfig('darkconsole.always-on')) {
|
|
|
|
if ($console) {
|
|
|
|
$link = javelin_render_tag(
|
|
|
|
'a',
|
|
|
|
array(
|
|
|
|
'href' => '/~/',
|
|
|
|
'sigil' => 'workflow',
|
|
|
|
),
|
|
|
|
'Disable DarkConsole');
|
|
|
|
} else {
|
|
|
|
$link = javelin_render_tag(
|
|
|
|
'a',
|
|
|
|
array(
|
|
|
|
'href' => '/~/',
|
|
|
|
'sigil' => 'workflow',
|
|
|
|
),
|
|
|
|
'Enable DarkConsole');
|
|
|
|
}
|
|
|
|
$foot_links[] = $link;
|
|
|
|
}
|
|
|
|
|
|
|
|
$foot_links = implode(' · ', $foot_links);
|
|
|
|
|
|
|
|
return
|
|
|
|
'<div class="phabricator-page-foot">'.
|
|
|
|
$foot_links.
|
|
|
|
'</div>';
|
|
|
|
}
|
|
|
|
|
2011-01-16 22:51:39 +01:00
|
|
|
}
|