2011-03-24 21:49:21 +01:00
|
|
|
<?php
|
|
|
|
|
2012-03-10 00:46:25 +01:00
|
|
|
final class HeraldTestConsoleController extends HeraldController {
|
2011-03-24 21:49:21 +01:00
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$user = $request->getUser();
|
|
|
|
|
|
|
|
$request = $this->getRequest();
|
|
|
|
|
|
|
|
$object_name = trim($request->getStr('object_name'));
|
|
|
|
|
|
|
|
$e_name = true;
|
|
|
|
$errors = array();
|
|
|
|
if ($request->isFormPost()) {
|
|
|
|
if (!$object_name) {
|
2013-05-20 17:24:07 +02:00
|
|
|
$e_name = pht('Required');
|
|
|
|
$errors[] = pht('An object name is required.');
|
2011-03-24 21:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!$errors) {
|
2013-09-26 01:54:48 +02:00
|
|
|
$object = id(new PhabricatorObjectQuery())
|
|
|
|
->setViewer($user)
|
|
|
|
->withNames(array($object_name))
|
|
|
|
->executeOne();
|
|
|
|
|
|
|
|
if (!$object) {
|
2013-05-20 17:24:07 +02:00
|
|
|
$e_name = pht('Invalid');
|
2013-09-26 01:54:48 +02:00
|
|
|
$errors[] = pht('No object exists with that name.');
|
2011-03-24 21:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!$errors) {
|
2013-10-05 00:17:01 +02:00
|
|
|
|
|
|
|
// TODO: Let the adapters claim objects instead.
|
|
|
|
|
2011-03-24 21:49:21 +01:00
|
|
|
if ($object instanceof DifferentialRevision) {
|
2013-08-02 17:55:13 +02:00
|
|
|
$adapter = HeraldDifferentialRevisionAdapter::newLegacyAdapter(
|
2011-04-06 05:49:31 +02:00
|
|
|
$object,
|
|
|
|
$object->loadActiveDiff());
|
2011-03-24 21:49:21 +01:00
|
|
|
} else if ($object instanceof PhabricatorRepositoryCommit) {
|
2014-01-10 00:56:24 +01:00
|
|
|
$adapter = id(new HeraldCommitAdapter())
|
|
|
|
->setCommit($object);
|
2013-10-05 00:17:01 +02:00
|
|
|
} else if ($object instanceof ManiphestTask) {
|
|
|
|
$adapter = id(new HeraldManiphestTaskAdapter())
|
|
|
|
->setTask($object);
|
|
|
|
} else if ($object instanceof PholioMock) {
|
|
|
|
$adapter = id(new HeraldPholioMockAdapter())
|
|
|
|
->setMock($object);
|
2011-03-24 21:49:21 +01:00
|
|
|
} else {
|
|
|
|
throw new Exception("Can not build adapter for object!");
|
|
|
|
}
|
|
|
|
|
2013-08-06 20:32:13 +02:00
|
|
|
$rules = id(new HeraldRuleQuery())
|
|
|
|
->setViewer($user)
|
|
|
|
->withContentTypes(array($adapter->getAdapterContentType()))
|
2013-10-07 02:10:29 +02:00
|
|
|
->withDisabled(false)
|
2013-08-06 20:32:13 +02:00
|
|
|
->needConditionsAndActions(true)
|
|
|
|
->needAppliedToPHIDs(array($object->getPHID()))
|
|
|
|
->needValidateAuthors(true)
|
|
|
|
->execute();
|
2011-03-24 21:49:21 +01:00
|
|
|
|
2013-08-07 15:47:55 +02:00
|
|
|
$engine = id(new HeraldEngine())
|
|
|
|
->setDryRun(true);
|
2011-03-24 21:49:21 +01:00
|
|
|
|
2013-08-07 15:47:55 +02:00
|
|
|
$effects = $engine->applyRules($rules, $adapter);
|
|
|
|
$engine->applyEffects($effects, $adapter, $rules);
|
2011-03-24 21:49:21 +01:00
|
|
|
|
|
|
|
$xscript = $engine->getTranscript();
|
|
|
|
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
|
|
->setURI('/herald/transcript/'.$xscript->getID().'/');
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($errors) {
|
|
|
|
$error_view = new AphrontErrorView();
|
2013-05-20 17:24:07 +02:00
|
|
|
$error_view->setTitle(pht('Form Errors'));
|
2011-03-24 21:49:21 +01:00
|
|
|
$error_view->setErrors($errors);
|
|
|
|
} else {
|
|
|
|
$error_view = null;
|
|
|
|
}
|
|
|
|
|
2013-10-05 00:17:01 +02:00
|
|
|
$text = pht(
|
|
|
|
'Enter an object to test rules for, like a Diffusion commit (e.g., '.
|
|
|
|
'rX123) or a Differential revision (e.g., D123). You will be shown '.
|
|
|
|
'the results of a dry run on the object.');
|
2013-05-20 17:24:07 +02:00
|
|
|
|
2011-03-24 21:49:21 +01:00
|
|
|
$form = id(new AphrontFormView())
|
|
|
|
->setUser($user)
|
2013-11-11 18:23:23 +01:00
|
|
|
->appendChild(
|
|
|
|
phutil_tag('p', array('class' => 'aphront-form-instructions'), $text))
|
2011-03-24 21:49:21 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTextControl())
|
2013-01-19 21:15:41 +01:00
|
|
|
->setLabel(pht('Object Name'))
|
2011-03-24 21:49:21 +01:00
|
|
|
->setName('object_name')
|
|
|
|
->setError($e_name)
|
|
|
|
->setValue($object_name))
|
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSubmitControl())
|
2013-01-19 21:15:41 +01:00
|
|
|
->setValue(pht('Test Rules')));
|
2011-03-24 21:49:21 +01:00
|
|
|
|
2013-10-05 00:17:01 +02:00
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
|
|
->setHeaderText(pht('Herald Test Console'))
|
|
|
|
->setFormError($error_view)
|
|
|
|
->setForm($form);
|
General Herald refactoring pass
Summary:
**Who can delete global rules?**: I discussed this with @jungejason. The current behavior is that the rule author or any administrator can delete a global rule, but this
isn't consistent with who can edit a rule (anyone) and doesn't really make much sense (it's an artifact of the global/personal split). I proposed that anyone can delete a
rule but we don't actually delete them, and log the deletion. However, when it came time to actually write the code for this I backed off a bit and continued actually
deleting the rules -- I think this does a reasonable job of balancing accountability with complexity. So the new impelmentation is:
- Personal rules can be deleted only by their owners.
- Global rules can be deleted by any user.
- All deletes are logged.
- Logs are more detailed.
- All logged actions can be viewed in aggregate.
**Minor Cleanup**
- Merged `HomeController` and `AllController`.
- Moved most queries to Query classes.
- Use AphrontFormSelectControl::renderSelectTag() where appropriate (this is a fairly recent addition).
- Use an AphrontErrorView to render the dry run notice (this didn't exist when I ported).
- Reenable some transaction code (this works again now).
- Removed the ability for admins to change rule authors (this was a little buggy, messy, and doesn't make tons of sense after the personal/global rule split).
- Rules which depend on other rules now display the right options (all global rules, all your personal rules for personal rules).
- Fix a bug in AphrontTableView where the "no data" cell would be rendered too wide if some columns are not visible.
- Allow selectFilter() in AphrontNavFilterView to be called without a 'default' argument.
Test Plan:
- Browsed, created, edited, deleted personal and gules.
- Verified generated logs.
- Did some dry runs.
- Verified transcript list and transcript details.
- Created/edited all/any rules; created/edited once/every time rules.
- Filtered admin views by users.
Reviewers: jungejason, btrahan
Reviewed By: btrahan
CC: aran, epriestley
Differential Revision: https://secure.phabricator.com/D2040
2012-03-30 19:49:55 +02:00
|
|
|
|
2013-01-21 16:46:13 +01:00
|
|
|
$crumbs = id($this->buildApplicationCrumbs())
|
2013-12-19 02:47:34 +01:00
|
|
|
->addTextCrumb(
|
|
|
|
pht('Transcripts'),
|
|
|
|
$this->getApplicationURI('/transcript/'))
|
|
|
|
->addTextCrumb(pht('Test Console'));
|
2013-01-21 16:46:13 +01:00
|
|
|
|
Update form styles, implement in many places
Summary:
This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
- Font Styles are correctly applied for form elements now.
- Everything lines up!
- Selects are larger, easier to read, interact.
- Inputs have been squared.
- Consistant CSS applied glow (try it!)
- Improved Mobile Responsiveness
- CSS applied to all form elements, not just Aphront
- Many other minor tweaks.
I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
Test Plan: Tested many applications, forms, mobile and tablet.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5860
2013-05-07 23:07:06 +02:00
|
|
|
return $this->buildApplicationPage(
|
2013-10-05 00:17:01 +02:00
|
|
|
$box,
|
2011-03-24 21:49:21 +01:00
|
|
|
array(
|
Update form styles, implement in many places
Summary:
This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
- Font Styles are correctly applied for form elements now.
- Everything lines up!
- Selects are larger, easier to read, interact.
- Inputs have been squared.
- Consistant CSS applied glow (try it!)
- Improved Mobile Responsiveness
- CSS applied to all form elements, not just Aphront
- Many other minor tweaks.
I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
Test Plan: Tested many applications, forms, mobile and tablet.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5860
2013-05-07 23:07:06 +02:00
|
|
|
'title' => pht('Test Console'),
|
|
|
|
'device' => true,
|
2011-03-24 21:49:21 +01:00
|
|
|
));
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|