revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/celerity/map.php

2232 lines
80 KiB
PHP
Raw Normal View History

Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
<?php
/**
* This file is automatically generated. Use 'bin/celerity map' to rebuild it.
Minor change to the Celerity map formatting Summary: Add a new line for clarity. Test Plan: Inspected `./resources/celerity/map.php`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9931
2014-07-16 03:29:06 +02:00
*
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
* @generated
*/
return array(
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'names' => array(
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'core.pkg.css' => '9a9b59ca',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'core.pkg.js' => '493cc6e6',
Quicksand - remove code not ready for production re: dark console Summary: goofed and slipped this into D12499 as I was working on T7700 too. Test Plan: noted console.log output not there Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12513
2015-04-23 02:12:58 +02:00
'darkconsole.pkg.js' => '8ab24e01',
Likely fix for spooky scrollbar in Firefox Summary: Fixes T7690. Test Plan: This fix worked when I applied it in the DOM inspector. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7690 Differential Revision: https://secure.phabricator.com/D12211
2015-03-30 21:06:40 +02:00
'differential.pkg.css' => '3500921f',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'differential.pkg.js' => '890046d3',
Convert Audit comment rendering to standard infrastructure Summary: Ref T4896. Depends on D10055. This uses core rendering stuff for audit comments, and fixes all the wonkiness with inlines so we can actually land the migration. Test Plan: Viewed, previewed and edited various types of comments in Diffusion. Reviewers: chad, btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10056
2014-07-29 00:01:43 +02:00
'diffusion.pkg.css' => '591664fa',
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'diffusion.pkg.js' => '0115b37c',
Clean up various mobile spacing Summary: Things on mobile should be 8px gutter. Test Plan: view in smaller browser windows Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11525
2015-01-27 19:24:28 +01:00
'maniphest.pkg.css' => '68d4dd3d',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'maniphest.pkg.js' => 'df4aa49f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'rsrc/css/aphront/dark-console.css' => '6378ef3d',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/aphront/dialog-view.css' => '9fddf890',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
AphrontFilterView should have 8px spacing on tablet Summary: Adds a tablet breakpoint CSS for better filter alignment on tablet. Test Plan: Review desktop, tablet, and mobile breakpoints on an ApplicationSearch Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12332
2015-04-08 19:44:11 +02:00
'rsrc/css/aphront/list-filter-view.css' => 'b2161041',
Send on enter in Conpherence chat column Summary: Ref T7538. We can figure out whether to backport this to main Conpherence later and/or remove buttons, etc., but this behavior seems pretty clearly good. Test Plan: - Pressed enter (sent message). - Pressed shift+enter (newline). Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7538 Differential Revision: https://secure.phabricator.com/D12085
2015-03-14 19:16:47 +01:00
'rsrc/css/aphront/multi-column.css' => 'fd18389d',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'rsrc/css/aphront/notification.css' => '9c279160',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/aphront/pager-view.css' => '2e3539af',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'rsrc/css/aphront/panel-view.css' => '8427b78d',
Minor fixes for CSS linter issues Summary: Fixes a few line length linter issues with CSS resources. Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11060
2014-12-30 11:48:26 +01:00
'rsrc/css/aphront/phabricator-nav-view.css' => '7aeaf435',
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'rsrc/css/aphront/table-view.css' => '59e2c0f8',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'rsrc/css/aphront/tokenizer.css' => '86a13f7f',
Add some spacing around jx-tooltips Summary: Using tooltips with icons is problematic because we currently draw the arrow after the tooltip location, meaning it goes 5px into the container. This gives a 5px padding around the outer container to better account for this. Test Plan: tested tooltips in remarkup bar, project icon nav, and in durable column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12184
2015-03-27 18:38:28 +01:00
'rsrc/css/aphront/tooltip.css' => '7672b60f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/aphront/two-column.css' => '16ab3ad2',
Tweak browse-more CSS Summary: Just adds some space, color. Test Plan: test a long browse list Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12471
2015-04-20 19:19:39 +02:00
'rsrc/css/aphront/typeahead-browse.css' => 'd8581d2c',
Minor indentation fixes Summary: Some CSS files are indented inconsistently, with a single space instead of two. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11061
2014-12-30 11:48:53 +01:00
'rsrc/css/aphront/typeahead.css' => '0e403212',
Allow Almanac service types to define default properties Summary: Ref T5833. This allows Almanac ServiceTypes to define default properties for a service, which show up in the UI and are more easily editable. Overall, this makes it much easier to make structured/usable/consistent service records: you can check a checkbox that says "prevent new allocations" instead of needing to know the meaning of a key. Test Plan: {F251593} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5833 Differential Revision: https://secure.phabricator.com/D10996
2014-12-17 20:10:50 +01:00
'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/auth/auth.css' => '1e655982',
Carrots are awesome with vegetables Summary: Use an angle-down icon instead of hard edged caret for search bar. I tested replacing this globally, but it didn't hold up as well. Test Plan: hover states, desktop, tablet, mobile. {F379596} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12521
2015-04-23 05:30:51 +02:00
'rsrc/css/application/base/main-menu-view.css' => 'c75df9ed',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
Roll out more FontIcons Summary: Sidenav launcher, search typeahead results, apps launcher Test Plan: Used each of these items {F275814} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11499
2015-01-26 17:19:22 +01:00
'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'rsrc/css/application/base/standard-page-view.css' => 'd3e1abe9',
Make chatlog bg white Summary: More white, less whitesmoke. Test Plan: rload chatlg Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8207
2014-02-12 18:55:53 +01:00
'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/config/config-options.css' => '7fedf08b',
Make base font a Celerity CSS variable Summary: For consistency, we switch back to base font in a few places when using alternate fonts like source-sans or monospace, this makes sure the base font is consistently reset. Test Plan: Review a Document, a Diff, and a Legalpad form Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11891
2015-02-26 18:26:36 +01:00
'rsrc/css/application/config/config-template.css' => '8e6c6fcd',
New Admin Welcome Screen Summary: Somewhat easier to parse and present information, with ICONS. Test Plan: Rebuilt current view with new layout. Tested toggling on and off some of the entries. {F327816} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11938
2015-03-03 00:42:25 +01:00
'rsrc/css/application/config/config-welcome.css' => '6abd79be',
ConfigIssueView minor tweaks Summary: Minor, adds border, reduces greys, etc. Test Plan: View a number of config issues, see new colors. {F282035} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11650
2015-02-03 18:07:00 +01:00
'rsrc/css/application/config/setup-issue.css' => '22270af2',
Basic style for exception page Summary: Fixes T6846, cleans up spacing, makes it look scary red. Test Plan: Fake an exception, see new layout Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6846 Differential Revision: https://secure.phabricator.com/D11161
2015-01-02 22:48:18 +01:00
'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'rsrc/css/application/conpherence/durable-column.css' => '5faebda3',
Move Conpherence when warning is present Summary: Turns out only Conpherence/Durable Column still have issues. Workboards is OK. Simple 2 new CSS classes and punt the issue down the road. Test Plan: Test Workboards, Conpherence, Durable Column with a setup check issue. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12394
2015-04-13 19:30:13 +02:00
'rsrc/css/application/conpherence/menu.css' => 'f389e048',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'rsrc/css/application/conpherence/message-pane.css' => 'e7c09fda',
Reduce subtitle length in Conpherence menu Summary: If you have a subtitle that is long and a new count indicator, they overlap. This gives a little space. Test Plan: fake a count Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12429
2015-04-16 01:19:18 +02:00
'rsrc/css/application/conpherence/notification.css' => 'd208f806',
Greens
2015-04-14 22:06:53 +02:00
'rsrc/css/application/conpherence/transaction.css' => '25138b7f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/conpherence/update.css' => '1099a660',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'rsrc/css/application/conpherence/widget-pane.css' => '2af42ebe',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'rsrc/css/application/dashboard/dashboard.css' => '17937d22',
Update InlineCommentSummary UI Summary: Minor spring cleaning, improve the visual feel of the comments table, more consistent structure. Test Plan: Test multiple comments, long comments, short comments, and multiple lines. {F282462} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11666
2015-02-09 17:38:51 +01:00
'rsrc/css/application/diff/inline-comment-summary.css' => 'eb5f8e8c',
Revamp inline commenting UI Summary: Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns: **To the author:** - The author of the diff should be able to easily identify what comments are done and not done. - We keep undone comments yellow - Clicking done turns comment block into 'unsubmitted state' **To the reviewer:** - Easier understanding of unsubmitted states - All conversations to be yellow/important **Todo** - Not all color CSS states correct - Unpulished checkbox support Test Plan: Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states. From the Diff Author's perspective: {F352094} For a Diff commenter's perspective: {F352095} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T1460, T7660, T7503 Differential Revision: https://secure.phabricator.com/D12171
2015-03-28 00:00:09 +01:00
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
Likely fix for spooky scrollbar in Firefox Summary: Fixes T7690. Test Plan: This fix worked when I applied it in the DOM inspector. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7690 Differential Revision: https://secure.phabricator.com/D12211
2015-03-30 21:06:40 +02:00
'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/css/application/differential/core.css' => '7ac3cabc',
Track ghostly inlines across file moves Summary: Ref T7447. Ref T7870. - Forward: When rendering some file "B" which was moved from "A", port ghosts for both "A" and "B" to it. - Backward: When porting a comment on "X" which was moved from some "Y", allow it to port to a file named "Y" if it can't find a file named "X". Test Plan: Before: {F377809} After: {F377806} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7447, T7870 Differential Revision: https://secure.phabricator.com/D12493
2015-04-21 17:26:00 +02:00
'rsrc/css/application/differential/phui-inline-comment.css' => '7adedadb',
Fix mobile CSS for lint/unit results table Summary: Removes nowrap when on mobile devices. Test Plan: Test Lint/Unit layout on mobile and table layouts Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10608
2014-09-30 18:47:54 +02:00
'rsrc/css/application/differential/results-table.css' => '181aa9d9',
Revamp inline commenting UI Summary: Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns: **To the author:** - The author of the diff should be able to easily identify what comments are done and not done. - We keep undone comments yellow - Clicking done turns comment block into 'unsubmitted state' **To the reviewer:** - Easier understanding of unsubmitted states - All conversations to be yellow/important **Todo** - Not all color CSS states correct - Unpulished checkbox support Test Plan: Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states. From the Diff Author's perspective: {F352094} For a Diff commenter's perspective: {F352095} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T1460, T7660, T7503 Differential Revision: https://secure.phabricator.com/D12171
2015-03-28 00:00:09 +01:00
'rsrc/css/application/differential/revision-comment.css' => '024dda6b',
Fibrous vegeables.
2014-03-12 21:53:04 +01:00
'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'rsrc/css/application/differential/table-of-contents.css' => '63f3ef4a',
Remove double border on tables in object boxes Summary: The CSS rule tends to miss many tables, make the rule more universal and add borders as needed. Test Plan: Test a Revision and Diffusion Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9516
2014-06-13 20:36:01 +02:00
'rsrc/css/application/diffusion/diffusion-icons.css' => '9c5828da',
Send Markdown in Diffusion through SourceSans Summary: This moves Markdown rendering from normal fonts to PHUIDocumentView with Source Sans improving readability of this longer form text. Test Plan: Test libphutil and Phabricator readmes in my sandbox. {F363483} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12330
2015-04-08 18:41:56 +02:00
'rsrc/css/application/diffusion/diffusion-readme.css' => '2106ea08',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/diffusion/diffusion-source.css' => '66fdf661',
Minor fixes for CSS linter issues Summary: Fixes a few line length linter issues with CSS resources. Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11060
2014-12-30 11:48:26 +01:00
'rsrc/css/application/feed/feed.css' => 'b513b5f4',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/files/global-drag-and-drop.css' => '697324ad',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'rsrc/css/application/flag/flag.css' => '5337623f',
Hide empty build logs Summary: This automatically hides any empty build logs from Harbormaster, so that they do not appear. Test Plan: Viewed a build plan where the logs were empty and didn't see them appear. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10091
2014-08-06 02:28:13 +02:00
'rsrc/css/application/harbormaster/harbormaster.css' => '49d64eb4',
Moderize Herald UI Summary: Removes many tables and uses PropertyLists and ObjectItemList when possible. Adds cleaner CSS, makes mobile editing more possible. Test Plan: Test new UI on desktop and mobile. Verify all functionality still exists. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4272 Differential Revision: https://secure.phabricator.com/D8860
2014-04-27 20:18:48 +02:00
'rsrc/css/application/herald/herald-test.css' => '778b008e',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'rsrc/css/application/herald/herald.css' => '826075fa',
Fix Workboard task spacing Summary: Restricts the padding change to homepage only. Derped this. Test Plan: View Homepage, View Workboard. Proper layouts ensue. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11534
2015-01-28 17:45:23 +01:00
'rsrc/css/application/home/home.css' => 'e34bf140',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/css/application/maniphest/batch-editor.css' => '8f380ebc',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'rsrc/css/application/maniphest/report.css' => 'f6931fdf',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
Clean up various mobile spacing Summary: Things on mobile should be 8px gutter. Test Plan: view in smaller browser windows Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11525
2015-01-27 19:24:28 +01:00
'rsrc/css/application/maniphest/task-summary.css' => 'ab2fc691',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/objectselector/object-selector.css' => '029a133d',
'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'rsrc/css/application/paste/paste.css' => 'eb997ddd',
Fix slowvote exception when viewing description diff Summary: Fixes T6937. We weren't passing required parameters. Test Plan: Followed repro steps in task. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6937 Differential Revision: https://secure.phabricator.com/D11346
2015-01-12 16:20:20 +01:00
'rsrc/css/application/people/people-profile.css' => '25970776',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'rsrc/css/application/phame/phame.css' => '88bd4705',
Make Pholio work a little better on mobile Summary: Ref T2644. This adjusts thumb sizing so the "X" button is visible, and hides the uploader on devices for now. The thumb stuff I'm sort of hacking (we'll cut off a little bit of wide thumbs on the iPhone), but it looks fine, is usable, and works a little better in landscape mode and at tablet sizes. Test Plan: {F167022} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2644 Differential Revision: https://secure.phabricator.com/D9562
2014-06-16 00:00:43 +02:00
'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee',
Add spacing under Pholio Inline Comments Summary: Adds a bit of space Test Plan: View 2 or more inline comments on same transaction. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9712
2014-06-25 00:23:57 +02:00
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
Update Pholio to use pink instead of indigo Summary: We recently shipping a more color correct version of Indigo, which means Pholio should use Pink for highlights. Test Plan: Review Pholio Comments, Hovers. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D10732
2014-10-21 19:06:10 +02:00
'rsrc/css/application/pholio/pholio.css' => '95174bdd',
Make it easier to add payment methods for subscription autopay Summary: Fixes T7424. Ref T6308. Currently, there's no option to just add a card directly from the autopay UI. Add a button so this works. Also, chip away at T6308 a bit. This isn't perfect but looks a little less out of place. Test Plan: {F327637} - Added a payment method, then set it as autopay. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6308, T7424 Differential Revision: https://secure.phabricator.com/D11935
2015-03-02 22:01:08 +01:00
'rsrc/css/application/phortune/phortune-credit-card-form.css' => '8391eb02',
Make Phortune checkout UI a little less bad Summary: Ref T2787. There were some mega-uggo buttons and such; reduce the uggo-ness by a hair. Test Plan: {F179686} Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10006
2014-07-23 19:36:37 +02:00
'rsrc/css/application/phortune/phortune.css' => '9149f103',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'rsrc/css/application/phriction/phriction-document-css.css' => '0d16bc9a',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
Notifications - add a "Clear All Notifications" link to dropdown Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links? Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2576 Differential Revision: https://secure.phabricator.com/D8894
2014-04-29 19:43:38 +02:00
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/policy/policy.css' => '957ea14c',
'rsrc/css/application/ponder/comments.css' => '6cdccea7',
'rsrc/css/application/ponder/feed.css' => 'e62615b6',
Update Conpherence CSS to handle multiple edits better Summary: Fixes T7655. We'll set tighter spacing around edit clusters. Also darkened up the date marker and remove unused `phabricator-transaction-view` CSS that was still scattered around the site. Test Plan: Test a full and column multi-edit spam. Visited Ponder and Diffusion, noticed no issues using those apps. Grepped for other users of `phabricator-transaction-view` Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Maniphest Tasks: T7655 Differential Revision: https://secure.phabricator.com/D12148
2015-03-26 20:56:58 +01:00
'rsrc/css/application/ponder/post.css' => '9d415218',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/ponder/vote.css' => '8ed6ed8b',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'rsrc/css/application/profile/profile-view.css' => '1a20dcbf',
Dashboard CSS updates Summary: Updates ObjectList dashboarda and tweaks minor css items elsewhere. Test Plan: Test my dashboard, editing, and standalone Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9275
2014-05-24 06:48:15 +02:00
'rsrc/css/application/projects/project-icon.css' => 'c2ecb7f1',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733',
Remove ReleephProjectController Summary: Ref T3657. General changes here: - Removes `ReleephProjectController`, which is the source of T3657. - Mostly moves requests from "RQ" as a monogram to "Y" (looks like a merge, mnemonic for "yank"?, we don't have too many characters left). This should be essentially only cosmetic. This reduces ambiguity with "rQ" and "R123", which are current and future repository monograms. This will continue in the next few diffs. - Makes requests implement policies correctly. Test Plan: Created, edited, browsed requests. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3657 Differential Revision: https://secure.phabricator.com/D8766
2014-04-14 21:06:56 +02:00
'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd',
'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae',
Clean up copy detection code a bit Summary: Ref T1266. This doesn't change any behaviors, but some of this code has a lot of really complicated conditionals and I tried to break that up a bit. Also, reexpress this stuff in terms of the "structured" parser in D12144. Test Plan: Unit tests still pass. They aren't hugely comprehensive but did reliably fail when I screwed stuff up. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1266 Differential Revision: https://secure.phabricator.com/D12145
2015-03-24 21:12:09 +01:00
'rsrc/css/application/search/search-results.css' => '15c71110',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/slowvote/slowvote.css' => '266df6a1',
Make tokens more accessible to assitive technologies Summary: Ref T4843. - The token award buttons are just icons. - The tokens themselves are just icons. - Also spread the tokens out a tiny bit, they feel a little tight to me right now. Test Plan: Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4843 Differential Revision: https://secure.phabricator.com/D8982
2014-05-05 19:54:34 +02:00
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
Clean up FontAwesome / Timeline CSS Summary: Normalize FA CSS, expand timeline icons to 14px, fix mobile browsers, give attribution in uiexamples Test Plan: tested iOS simulator, chrome, ie Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8845
2014-04-23 03:29:14 +02:00
'rsrc/css/application/uiexample/example.css' => '528b19de',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'rsrc/css/core/core.css' => '76e8ee93',
Move ToC in Phriction to it's own column Summary: Adds additional CSS to make the Table of Contents into it's own column (if one exists). Test Plan: Tested a page with and without a table of contents. Tested tablet, mobile, and desktop breakpoints. Tested Conpherence, scrolling seemed fine still on trackpad and mouse. {F370973} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12417
2015-04-15 01:02:30 +02:00
'rsrc/css/core/remarkup.css' => 'e10512ff',
Apple remarkup-code padding to child spans as well. Summary: Fixes T6440. The issue is when a nested span appears, we don't apply the spacing. Test Plan: Test a new diff in my sandbox that exhibits the issue. Ensure spacing now aligns. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6440 Differential Revision: https://secure.phabricator.com/D10768
2014-10-31 18:45:11 +01:00
'rsrc/css/core/syntax.css' => '56c1ba38',
Move setup warning callout above the nav-drag div Summary: See {T7830} Test Plan: I manually set this to `5` in Chrome inspector and checked a few pages. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12481
2015-04-20 19:52:51 +02:00
'rsrc/css/core/z-index.css' => '5a2b9d9d',
Support WOFF files in Celerity and add Source Sans Pro Summary: - Allow Celerity to map and serve WOFF files. - Add Source Sans Pro, Source Sans Pro Bold, and the corresponding LICENSE. - Add a `font-source-sans-pro` resource for the font. Test Plan: - Changed body `font-face` to `'Source Sans Pro'`. - Added `require_celerity_resource('font-source-sans-pro')` in StandardPageView. Works in Firefox/Chrome/Safari, at least: {F123296} {F123297} {F123298} Reviewers: btrahan, chad Reviewed By: chad CC: chad, aran Differential Revision: https://secure.phabricator.com/D8430
2014-03-06 20:28:24 +01:00
'rsrc/css/diviner/diviner-shared.css' => '38813222',
Add support for ".woff2" resources Summary: Ref T7210. Not sure if this fixes things, but it's definitely //an// issue. Test Plan: - Not able to reproduce issue locally yet. - These get into the map now, at least? - Saw `.woff2` URIs transform in CSS. - Loaded a `.woff2` file. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7210 Differential Revision: https://secure.phabricator.com/D11720
2015-02-09 17:12:47 +01:00
'rsrc/css/font/font-awesome.css' => 'ae9a7b4d',
Modernize file storage engine selection Summary: Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend. This mechanism predates widespread use of `PhutilSymbolLoader` to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined). Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the `Selector`, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods). Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster. This uses D12051 to add UI to make it easier to understand the state of storage engines. Test Plan: Used new UI panel to assess storage engines: {F336270} - Uploaded a small file, saw it go to MySQL engine. - Uploaded a larger file, saw it go to S3 engine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5843 Differential Revision: https://secure.phabricator.com/D12053
2015-03-12 21:28:53 +01:00
'rsrc/css/font/font-source-sans-pro.css' => '4a2430d7',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'rsrc/css/font/phui-font-icon-base.css' => '3dad2ae3',
[Redesign] Update Filetree CSS Summary: Tweaks colors, updates icons Test Plan: Tested a filetree view, clicked and hovered. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9335
2014-05-30 01:04:50 +02:00
'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/layout/phabricator-hovercard-view.css' => '44394670',
Revamp Projects with new navigation Summary: A refresh of Projects including a new navigations UI. - New Navigation UI. - Auto switch default page if Workboard has been initialized - Move Feed to it's own page - Increase 'tasks' on Project Home to 50 over 10 - Fix various display bugs on Workboards - Remove 'crumbs' from Project portal (unneeded). Test Plan: - clicked a link for a project with no workboard and saw the profile - clicked a link for a project with a workboard and saw the workboard - navigated around the various edit pages, inspecting links and making sure things linked back to the new profile uri {F266460} {F266461} {F266462} {F266463} {F266464} Reviewers: epriestley, btrahan Reviewed By: epriestley, btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11272
2015-01-12 19:04:01 +01:00
'rsrc/css/layout/phabricator-side-menu-view.css' => '7e8c6341',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'rsrc/css/layout/phabricator-source-code-view.css' => '2ceee894',
Calendar upgrades Summary: Does a handful of things to make Calendar significantly more useful - Enabled overlapping events - Profile has a 'week view' of the user - Profile has a 'month view' of the users - Multiple users on a calendar are color coded - Browse view slightly more useful This stops short of implementing the new 'home' view on Calendar, mostly this is a big step though to make that happen next. Test Plan: Make lots of events on diffent users. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T2897, T4375 Differential Revision: https://secure.phabricator.com/D8317
2014-02-24 19:04:23 +01:00
'rsrc/css/phui/calendar/phui-calendar-day.css' => 'de035c8a',
'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1d0ca59',
Fixing z-index on calendar date badges. Summary: Fixes T4787, decreased z-index on calendar badges so that they don't sit on top of notification dropdowns when dropdowns are expanded. Not sure why the badges had z-index 10, but please let me know if there was a more substantial reason for this. Test Plan: If neither notification dropdowns have content, create enough messages to populate at least 5 rows, open calendar, expand messages dropdown, verify that underlying calendar date badges do not appear over the dropdown. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4787 Differential Revision: https://secure.phabricator.com/D8770
2014-04-13 17:18:16 +02:00
'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a92e47d2',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
Make default and hidden columns in Workboards more clear Summary: Fixes T6469. Changes the default icon into text instead. Added the text to hidden boards and now display when reordering as well. Test Plan: Moved a bunch of columns, tested reordering. Seems more clear. {F229626} {F229627} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6469 Differential Revision: https://secure.phabricator.com/D10784
2014-11-04 20:11:15 +01:00
'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'rsrc/css/phui/phui-action-list.css' => '4f4d09f2',
Correct logic in PHUIActionPanelView Summary: We should only be adding space then a status is set, not a state. Test Plan: Test on UIExamples, still renders as expected. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11844
2015-02-21 15:38:27 +01:00
'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'rsrc/css/phui/phui-box.css' => '7b3a2eed',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/phui/phui-button.css' => 'f780e520',
Clean up mobile crumbs with multiple levels Summary: Before the redesign, these levels were hidden. This recreates that behavior. Test Plan: Test nested Phriction pages {F281114} {F281115} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11621
2015-02-02 19:34:42 +01:00
'rsrc/css/phui/phui-crumbs-view.css' => '594d719e',
Move ToC in Phriction to it's own column Summary: Adds additional CSS to make the Table of Contents into it's own column (if one exists). Test Plan: Tested a page with and without a table of contents. Tested tablet, mobile, and desktop breakpoints. Tested Conpherence, scrolling seemed fine still on trackpad and mouse. {F370973} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12417
2015-04-15 01:02:30 +02:00
'rsrc/css/phui/phui-document.css' => '94d5dcd8',
Remove 1x AppIcons, use FontIcons instead Summary: Removes the 1x application icons, and uses the fonticons instead. Feed was only known location. Test Plan: feed, dashboards, grep for use {F275636} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11496
2015-01-25 23:14:41 +01:00
'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
Modernize file storage engine selection Summary: Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend. This mechanism predates widespread use of `PhutilSymbolLoader` to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined). Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the `Selector`, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods). Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster. This uses D12051 to add UI to make it easier to understand the state of storage engines. Test Plan: Used new UI panel to assess storage engines: {F336270} - Uploaded a small file, saw it go to MySQL engine. - Uploaded a larger file, saw it go to S3 engine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5843 Differential Revision: https://secure.phabricator.com/D12053
2015-03-12 21:28:53 +01:00
'rsrc/css/phui/phui-fontkit.css' => '1fa79503',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/phui/phui-form-view.css' => 'b147d2ed',
Make base font a Celerity CSS variable Summary: For consistency, we switch back to base font in a few places when using alternate fonts like source-sans or monospace, this makes sure the base font is consistently reset. Test Plan: Review a Document, a Diff, and a Legalpad form Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11891
2015-02-26 18:26:36 +01:00
'rsrc/css/phui/phui-form.css' => 'f535f938',
Normalize ActionList dropdowns Summary: Normalizes the display of the ActionList menu on mobile and tablet, shifts them to being actual menu dropdowns instead of an inline list. Test Plan: Verify DocumentView, Profiles, and Tasks all display the Action Menu in an identical way. {F368091} {F368092} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12373
2015-04-12 22:29:27 +02:00
'rsrc/css/phui/phui-header-view.css' => 'da4586b1',
Standardize spacing when icons have text Summary: Our standard icon -> button spacing is 4px, not 8px. Test Plan: Review search icon in Conpherence Full Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12365
2015-04-12 06:25:36 +02:00
'rsrc/css/phui/phui-icon.css' => 'bc766998',
CSS polish, Pholio Summary: Minor things - Fades out comment icon on hover - Adds hover to inline comment images - moves mask position to just the image, and not the transparent border Test Plan: Tested all of these items on various mocks Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9631
2014-06-19 20:28:01 +02:00
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'rsrc/css/phui/phui-info-view.css' => 'c6f0aef8',
Conpherence - Implement edit rules for rooms Summary: Fixes T7586. If you can't edit a room, the pertinent UI is greyed out. One exception is the title of the room in the full viewer; this crumb is not disabled as it would be hard to read. Otherwise though, everything is disabled nicely. Test Plan: tried to add participants when I wasn't allowed to and got an error. added participants otherwise okay. tried to edit title when i wasn't allowed and got an error. otherwise okay. left conpherence threads / rooms successfully. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7586 Differential Revision: https://secure.phabricator.com/D12161
2015-03-25 19:48:22 +01:00
'rsrc/css/phui/phui-list.css' => '2e25ebfb',
Normalize ActionList dropdowns Summary: Normalizes the display of the ActionList menu on mobile and tablet, shifts them to being actual menu dropdowns instead of an inline list. Test Plan: Verify DocumentView, Profiles, and Tasks all display the Action Menu in an identical way. {F368091} {F368092} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12373
2015-04-12 22:29:27 +02:00
'rsrc/css/phui/phui-object-box.css' => '7d160002',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'rsrc/css/phui/phui-object-item-list-view.css' => '9db65899',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'rsrc/css/phui/phui-pinboard-view.css' => 'eaab2b1b',
Fix clone input on device breakpoints in Diffusion Summary: The float wasn't getting reset on the definition list, so clone URI (so important on mobile!) looked terrible. Test Plan: Tested Diffusion, Herald, and Maniphest property lists. Seems good. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12331
2015-04-08 19:12:31 +02:00
'rsrc/css/phui/phui-property-list-view.css' => '5b671934',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
Remove negative margin in phui-status Summary: Fixes T6334, the negative margin is no longer needed to align tables. Test Plan: review table item alignment in commit message Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6334 Differential Revision: https://secure.phabricator.com/D10716
2014-10-16 22:12:03 +02:00
'rsrc/css/phui/phui-status.css' => '888cedb8',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'rsrc/css/phui/phui-tag-view.css' => '402691cc',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'rsrc/css/phui/phui-text.css' => 'cf019f54',
Automatically make timeline + objectbox sit flush Summary: Right now you have to know to setFlush on an ObjectBox preceding a timeline, we can make that automatic with CSS. Test Plan: Test some Diffusion commit pages, boxes now site flush under timeline. Check Maniphest and Differential, no changes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11617
2015-02-02 18:40:46 +01:00
'rsrc/css/phui/phui-timeline-view.css' => 'b0fbc4d7',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'rsrc/css/phui/phui-workboard-view.css' => '3279cbbf',
Minor indentation fixes Summary: Some CSS files are indented inconsistently, with a single space instead of two. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11061
2014-12-30 11:48:53 +01:00
'rsrc/css/phui/phui-workpanel-view.css' => 'e495a5cc',
Move ActionHeaders to PHUI, add ObjectBox Support, new Colors Summary: Moves PhabricatorActionHeaderView to PHUIActionHeaderView, adds Red, Green, and Violet colors and extend ObjectBox to take colors and action headers. Test Plan: Tested new Welcome layout as well as UIExamples, Workboards, and Hovercards {F169669} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9707
2014-06-24 18:39:32 +02:00
'rsrc/css/sprite-gradient.css' => '4bdb98a7',
Fixed MediaWiki logo in login sprite sheets. Summary: I've been advised that that the MediaWiki flower needs to appear with the square brackets for proper MediaWiki trademark presentation. See https://phabricator.wikimedia.org/T543 for relevant discussion. Test Plan: view login page with MediaWiki oauth plugin enabled, see that the logo includes square brackets around the flower Reviewers: epriestley, qgil, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: Korvin, epriestley Projects: #auth, #wikimedia Differential Revision: https://secure.phabricator.com/D10752
2014-10-29 23:06:15 +01:00
'rsrc/css/sprite-login.css' => 'a355d921',
Add "Blindigo" header color Summary: Adds a new header color. Test Plan: Select new header color, see new header color. {F326502} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11918
2015-03-01 21:03:02 +01:00
'rsrc/css/sprite-main-header.css' => '28d01b0b',
Increase height of logo Summary: This increases the transparent space around the Phabricator logo. The logo itself is the same size. This allows for adding of other logos more easily without needing to alter the space provided. (Like Phacility) Test Plan: Reload page, screenshot logo, pull into Photoshop and verify spacing top and bottom. {F309985} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11828
2015-02-19 23:43:33 +01:00
'rsrc/css/sprite-menu.css' => '9ef76324',
Rename group to users in project icons Summary: Fixes T6972. Test Plan: Set icon to typeahead icon in edit project image Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6972 Differential Revision: https://secure.phabricator.com/D11391
2015-01-14 19:49:36 +01:00
'rsrc/css/sprite-projects.css' => 'b0d9e24f',
Mail icon for email lists in typeahead Summary: Adds a mail icon to use in the typeahead Also, can we add a special class per obj-type? (May want to special color projects, etc) Will try to live without them. Test Plan: photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8259
2014-02-17 19:06:16 +01:00
'rsrc/css/sprite-tokens.css' => '1706b943',
Update to FontAwesome 4.3 Summary: New icons, woff2 Test Plan: visit UIExamples and click on icons. weeee Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11488
2015-01-25 17:09:41 +01:00
'rsrc/externals/font/fontawesome/fontawesome-webfont.eot' => '5fb6fb0e',
'rsrc/externals/font/fontawesome/fontawesome-webfont.ttf' => 'a653cb11',
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff' => '80526fc8',
Add support for ".woff2" resources Summary: Ref T7210. Not sure if this fixes things, but it's definitely //an// issue. Test Plan: - Not able to reproduce issue locally yet. - These get into the map now, at least? - Saw `.woff2` URIs transform in CSS. - Loaded a `.woff2` file. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7210 Differential Revision: https://secure.phabricator.com/D11720
2015-02-09 17:12:47 +01:00
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff2' => '4924d54d',
'rsrc/externals/font/sourcesans/SourceSansPro-Bold.woff2' => '165f5f74',
Add Source Sans Pro Italic Fonts Summary: Improves Source Sans Pro italics rendering Test Plan: Tested a Phriction document with normal and bold italics. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11572
2015-01-29 23:48:41 +01:00
'rsrc/externals/font/sourcesans/SourceSansPro-BoldIt.woff' => 'd09a7d54',
Add support for ".woff2" resources Summary: Ref T7210. Not sure if this fixes things, but it's definitely //an// issue. Test Plan: - Not able to reproduce issue locally yet. - These get into the map now, at least? - Saw `.woff2` URIs transform in CSS. - Loaded a `.woff2` file. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7210 Differential Revision: https://secure.phabricator.com/D11720
2015-02-09 17:12:47 +01:00
'rsrc/externals/font/sourcesans/SourceSansPro-BoldIt.woff2' => 'd2e33102',
Add Source Sans Pro Italic Fonts Summary: Improves Source Sans Pro italics rendering Test Plan: Tested a Phriction document with normal and bold italics. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11572
2015-01-29 23:48:41 +01:00
'rsrc/externals/font/sourcesans/SourceSansPro-It.woff' => '3f21af52',
Add support for ".woff2" resources Summary: Ref T7210. Not sure if this fixes things, but it's definitely //an// issue. Test Plan: - Not able to reproduce issue locally yet. - These get into the map now, at least? - Saw `.woff2` URIs transform in CSS. - Loaded a `.woff2` file. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7210 Differential Revision: https://secure.phabricator.com/D11720
2015-02-09 17:12:47 +01:00
'rsrc/externals/font/sourcesans/SourceSansPro-It.woff2' => '30a7cf60',
'rsrc/externals/font/sourcesans/SourceSansPro-Regular.woff2' => 'e89b04b1',
Add Glyphicons Halflings Font and Examples Summary: This adds in the Glyphicons Halflings Font/Iconset as an option for PHUIIconView along with a standard set of 10 colors. This will be a replacement for the standard action icon set in upcoming diffs, as well as obviously give us more flexibility, less KB, and less design resource time managing images. Test Plan: UIExamples, Diviner Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8798
2014-04-18 02:31:23 +02:00
'rsrc/externals/font/sourcesans/SourceSansPro.woff' => '3614608c',
'rsrc/externals/font/sourcesans/SourceSansProBold.woff' => 'cbf46566',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/core/Event.js' => '85ea0626',
Use dot notation in some places Summary: Use `x.y` in favor of `x['y']` in //some// JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick `PhabricatorJavelinLinter`. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11442
2015-01-28 21:42:05 +01:00
'rsrc/externals/javelin/core/Stratcom.js' => '6c53634d',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js' => '717554e4',
'rsrc/externals/javelin/core/__tests__/install.js' => 'c432ee85',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
Scroll the chat column to the bottom when images load Summary: Fixes T7558. This might not be 100% perfect but should solve most of the issue. I briefly looked at things like `MutationObserver` (some fancy next-gen browser junk) but couldn't immediately get it working. Other methods for handling this kind of thing involve polling, complicated polyfills, etc. We could give `MutationObserver` a more serious effort if this is too leaky. Test Plan: - In a thread with some images, reloaded the page and saw the scrollbar stay at the bottom. - Tested with and without USB devices attached. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7558 Differential Revision: https://secure.phabricator.com/D12191
2015-03-28 16:35:12 +01:00
'rsrc/externals/javelin/core/init.js' => '3010e992',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/core/init_node.js' => 'c234aded',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/core/install.js' => '05270951',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/docs/Base.js' => '74676256',
'rsrc/externals/javelin/docs/onload.js' => 'e819c479',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
'rsrc/externals/javelin/ext/fx/FX.js' => '54b612ba',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/reactor/core/DynVal.js' => 'f6555212',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/reactor/core/Reactor.js' => '2b8de964',
'rsrc/externals/javelin/ext/reactor/core/ReactorNode.js' => '1ad0a787',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js' => '76f4ebed',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/reactor/dom/RDOM.js' => 'c90a04fc',
'rsrc/externals/javelin/ext/view/HTMLView.js' => 'fe287620',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/view/View.js' => '0f764c35',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/view/ViewInterpreter.js' => 'f829edb3',
'rsrc/externals/javelin/ext/view/ViewPlaceholder.js' => '47830651',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/view/ViewRenderer.js' => '6c2b09a2',
'rsrc/externals/javelin/ext/view/ViewVisitor.js' => 'efe49472',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/view/__tests__/HTMLView.js' => 'f92d7bcb',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/ext/view/__tests__/View.js' => '6450b38b',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => '7a94d6a5',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '6ea96ac9',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/lib/Cookie.js' => '62dfea03',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/externals/javelin/lib/DOM.js' => '6f7962d5',
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'rsrc/externals/javelin/lib/History.js' => 'd4505101',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
Fix an undefined variable Summary: Identifed by linting with JSHint. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11433
2015-01-22 21:22:26 +01:00
'rsrc/externals/javelin/lib/Leader.js' => '331b1611',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/Mask.js' => '8a41885b',
Quicksand - make notification and message counts update as you navigate around Summary: Ref T7573. Unify code to fetch these counts and do some light formatting since we're going to need to do the same thing for some conpherence-specific ajax in the durable column (See T7708). Test Plan: loaded up two tabs, one with a durable column on and one without. in the without browser, i read some messages, decrementing my unread count. when i navigated again in the durable column browser, the count updated correctly. with no notifications, commented on a task with another user to get a notification and it showed up properly. visited the task by clicking not the notification and the bubble count decremented correctly Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7573 Differential Revision: https://secure.phabricator.com/D12498
2015-04-22 00:46:36 +02:00
'rsrc/externals/javelin/lib/Quicksand.js' => '517545ab',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/Request.js' => '94b750d2',
'rsrc/externals/javelin/lib/Resource.js' => '44959b73',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/externals/javelin/lib/Routable.js' => 'b3e7d692',
'rsrc/externals/javelin/lib/Router.js' => '29274e2b',
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'rsrc/externals/javelin/lib/Scrollbar.js' => 'eaa5b321',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'rsrc/externals/javelin/lib/Sound.js' => '949c0fe5',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/URI.js' => '6eff08aa',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/externals/javelin/lib/Vector.js' => '2caa8fb8',
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'rsrc/externals/javelin/lib/WebSocket.js' => 'e292eaf4',
Improve Conpherence column textarea JS behaviors Summary: - Don't show a loading state on the whole column while sending chat. We could show some kind of minor loading state, but standard JX.Busy stuff will kick in after a couple seconds anyway. - Blank the textarea immediately on submit so you can start typing more text. - Don't disable the form while submiting; disabling it prevents you from typing more text. - Hide the placeholder while the textarea is focused. If we don't do this, the placeholder reappearing after submitting text feels weird to me. Test Plan: - Sent a lot of text. - Real fast. - Focused and unfocused the area. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12086
2015-03-14 20:00:17 +01:00
'rsrc/externals/javelin/lib/Workflow.js' => '5b2e3e2b',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/lib/__tests__/Cookie.js' => '5ed109e8',
'rsrc/externals/javelin/lib/__tests__/DOM.js' => 'c984504b',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/__tests__/JSON.js' => '837a7d68',
Remove an unused variable Summary: This variable is unused. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11440
2015-01-20 11:25:17 +01:00
'rsrc/externals/javelin/lib/__tests__/URI.js' => '1e45fda9',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/lib/__tests__/behavior.js' => '1ea62783',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/behavior.js' => '61cbc29a',
Support tokenizer functions in Diffusion Summary: Ref T4100. Ref T5595. Support tokenizer functions + edgelogic for repositories. Test Plan: Searched for repositories. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5595, T4100 Differential Revision: https://secure.phabricator.com/D12533
2015-04-23 17:25:17 +02:00
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => 'ab5f468d',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => '70baed2f',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'e6e25838',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '503e17fd',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '8b3fd187',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => '2818f5ce',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '316b8fa1',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/raphael/g.raphael.js' => '40dde778',
'rsrc/externals/raphael/g.raphael.line.js' => '40da039e',
'rsrc/externals/raphael/raphael.js' => '51ee6b43',
Add HiDPI favicons Summary: Fixes T5939. Specifically, 16, 32, and 64 bit pngs are in the .ico file. Apple icons are added to support non-Retina and Retina iPad and iPhone. Follows roughly Apple guidelines here: https://developer.apple.com/library/ios/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html Test Plan: Tested Chrome, Firefox on Mac. Much cleaner on Retina. {F230715,size=full} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T5939 Differential Revision: https://secure.phabricator.com/D10796
2014-11-08 02:07:38 +01:00
'rsrc/favicons/apple-touch-icon-120x120.png' => '43742962',
'rsrc/favicons/apple-touch-icon-152x152.png' => '669eaec3',
'rsrc/favicons/apple-touch-icon-76x76.png' => 'ecdef672',
'rsrc/favicons/favicon-128.png' => '47cdff03',
'rsrc/favicons/favicon-16x16.png' => 'ee2523ac',
'rsrc/favicons/favicon-32x32.png' => 'b6a8150e',
'rsrc/favicons/favicon-96x96.png' => '8f7ea177',
Use pixel as background of timeline Summary: Makes the line in timeline a background "image" instead. Test Plan: Tested Desktop, Mobile, and Tablet breakpoints with lots of content. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8221
2014-02-14 00:15:58 +01:00
'rsrc/image/BFCFDA.png' => 'd5ec91f4',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/actions/edit.png' => '2fc41442',
Tweak Psyduck Summary: Use our standard blue background. Test Plan: Quack Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin, chad Differential Revision: https://secure.phabricator.com/D8629
2014-03-28 03:36:51 +01:00
'rsrc/image/avatar.png' => '3eb28cd9',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/checker_dark.png' => 'd8e65881',
'rsrc/image/checker_light.png' => 'a0155918',
Switch Pholio over to lighter layout. Summary: Gets rid of all the dark css. Test Plan: Do it live. {F166665} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9545
2014-06-15 16:44:12 +02:00
'rsrc/image/checker_lighter.png' => 'd5da91b6',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/darkload.gif' => '1ffd3ec6',
'rsrc/image/divot.png' => '94dded62',
PHUIImageMask Summary: Adds a PHUI class for display images on a center point, with or without a mask. Test Plan: I am bad a math, so like, check that for me please. I tested using Photoshop. Class may need tweaked depending how we store the inline-comment coords. {F167829} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9614
2014-06-18 23:09:37 +02:00
'rsrc/image/examples/hero.png' => '979a86ae',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/grippy_texture.png' => 'aca81e2f',
'rsrc/image/icon/fatcow/arrow_branch.png' => '2537c01c',
'rsrc/image/icon/fatcow/arrow_merge.png' => '21b660e0',
'rsrc/image/icon/fatcow/bullet_black.png' => 'ff190031',
'rsrc/image/icon/fatcow/bullet_orange.png' => 'e273e5bb',
'rsrc/image/icon/fatcow/bullet_red.png' => 'c0b75434',
'rsrc/image/icon/fatcow/calendar_edit.png' => '24632275',
'rsrc/image/icon/fatcow/document_black.png' => '45fe1c60',
'rsrc/image/icon/fatcow/flag_blue.png' => 'a01abb1d',
'rsrc/image/icon/fatcow/flag_finish.png' => '67825cee',
'rsrc/image/icon/fatcow/flag_ghost.png' => '20ca8783',
'rsrc/image/icon/fatcow/flag_green.png' => '7e0eaa7a',
'rsrc/image/icon/fatcow/flag_orange.png' => '9e73df66',
'rsrc/image/icon/fatcow/flag_pink.png' => '7e92f3b2',
'rsrc/image/icon/fatcow/flag_purple.png' => 'cc517522',
'rsrc/image/icon/fatcow/flag_red.png' => '04ec726f',
'rsrc/image/icon/fatcow/flag_yellow.png' => '73946fd4',
'rsrc/image/icon/fatcow/folder.png' => '95a435af',
'rsrc/image/icon/fatcow/folder_go.png' => '001cbc94',
'rsrc/image/icon/fatcow/key_question.png' => '52a0c26a',
'rsrc/image/icon/fatcow/link.png' => '7afd4d5e',
'rsrc/image/icon/fatcow/page_white_edit.png' => '39a2eed8',
'rsrc/image/icon/fatcow/page_white_link.png' => 'a90023c7',
'rsrc/image/icon/fatcow/page_white_put.png' => '08c95a0c',
'rsrc/image/icon/fatcow/page_white_text.png' => '1e1f79c3',
'rsrc/image/icon/fatcow/source/conduit.png' => '4ea01d2f',
'rsrc/image/icon/fatcow/source/email.png' => '9bab3239',
'rsrc/image/icon/fatcow/source/fax.png' => '04195e68',
'rsrc/image/icon/fatcow/source/mobile.png' => 'f1321264',
'rsrc/image/icon/fatcow/source/tablet.png' => '49396799',
'rsrc/image/icon/fatcow/source/web.png' => '136ccb5d',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/default.p100.png' => '7d490b01',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/default160x120.png' => 'f2e8a2eb',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/default280x210.png' => '43e8926a',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/default60x45.png' => '0118abed',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/image.p100.png' => 'da23cf97',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/image160x120.png' => '79bb556a',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/image280x210.png' => '91ae054a',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/image60x45.png' => 'c5e1685e',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/pdf.p100.png' => '87d5e065',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/pdf160x120.png' => 'ac9edbf5',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/pdf280x210.png' => '1c585653',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/pdf60x45.png' => 'c0db4143',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/zip.p100.png' => '6ea5aae4',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/zip160x120.png' => '75f9cd0f',
Reduce Pholio brokenness for non-image files Summary: Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable: - Provide thumbs in the required sizes. - Predict the thumb size of these files correctly. - Disable inline comments. - Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5359 Differential Revision: https://secure.phabricator.com/D9548
2014-06-15 17:03:04 +02:00
'rsrc/image/icon/fatcow/thumbnails/zip280x210.png' => 'dfda5b8e',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/icon/fatcow/thumbnails/zip60x45.png' => 'af11bf3e',
'rsrc/image/icon/lightbox/close-2.png' => 'cc40e7c8',
'rsrc/image/icon/lightbox/close-hover-2.png' => 'fb5d6d9e',
'rsrc/image/icon/lightbox/left-arrow-2.png' => '8426133b',
'rsrc/image/icon/lightbox/left-arrow-hover-2.png' => '701e5ee3',
'rsrc/image/icon/lightbox/right-arrow-2.png' => '6d5519a0',
'rsrc/image/icon/lightbox/right-arrow-hover-2.png' => '3a04aa21',
'rsrc/image/icon/subscribe.png' => 'd03ed5a5',
'rsrc/image/icon/tango/attachment.png' => 'ecc8022e',
'rsrc/image/icon/tango/edit.png' => '929a1363',
'rsrc/image/icon/tango/go-down.png' => '96d95e43',
'rsrc/image/icon/tango/log.png' => 'b08cc63a',
'rsrc/image/icon/tango/upload.png' => '7bbb7984',
'rsrc/image/icon/unsubscribe.png' => '25725013',
Use more common styles for setup issue CSS Summary: Updates setup CSS to use more common colors, spacing. Test Plan: review a fatal, a common error, and uiexample Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8006
2014-01-18 17:31:47 +01:00
'rsrc/image/lightblue-header.png' => '5c168b6d',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/loading.gif' => '75d384cc',
'rsrc/image/loading/boating_24.gif' => '5c90f086',
'rsrc/image/loading/compass_24.gif' => 'b36b4f46',
'rsrc/image/loading/loading_24.gif' => '26bc9adc',
'rsrc/image/loading/loading_48.gif' => '6a4994c7',
'rsrc/image/loading/loading_d48.gif' => 'cdcbe900',
'rsrc/image/loading/loading_w24.gif' => '7662fa2b',
'rsrc/image/main_texture.png' => '29a2c5ad',
'rsrc/image/menu_texture.png' => '5a17580d',
'rsrc/image/people/harding.png' => '45aa614e',
'rsrc/image/people/jefferson.png' => 'afca0e53',
'rsrc/image/people/lincoln.png' => '9369126d',
'rsrc/image/people/mckinley.png' => 'fb8f16ce',
'rsrc/image/people/taft.png' => 'd7bc402c',
'rsrc/image/people/washington.png' => '40dd301c',
'rsrc/image/phrequent_active.png' => 'a466a8ed',
'rsrc/image/phrequent_inactive.png' => 'bfc15a69',
'rsrc/image/search-white.png' => '64cc0d45',
'rsrc/image/search.png' => '82625a7e',
Move ActionHeaders to PHUI, add ObjectBox Support, new Colors Summary: Moves PhabricatorActionHeaderView to PHUIActionHeaderView, adds Red, Green, and Violet colors and extend ObjectBox to take colors and action headers. Test Plan: Tested new Welcome layout as well as UIExamples, Workboards, and Hovercards {F169669} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9707
2014-06-24 18:39:32 +02:00
'rsrc/image/sprite-gradient.png' => 'ec15a417',
Fixed MediaWiki logo in login sprite sheets. Summary: I've been advised that that the MediaWiki flower needs to appear with the square brackets for proper MediaWiki trademark presentation. See https://phabricator.wikimedia.org/T543 for relevant discussion. Test Plan: view login page with MediaWiki oauth plugin enabled, see that the logo includes square brackets around the flower Reviewers: epriestley, qgil, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: Korvin, epriestley Projects: #auth, #wikimedia Differential Revision: https://secure.phabricator.com/D10752
2014-10-29 23:06:15 +01:00
'rsrc/image/sprite-login-X2.png' => '5ae6de3a',
'rsrc/image/sprite-login.png' => '07f2c67c',
Add "Blindigo" header color Summary: Adds a new header color. Test Plan: Select new header color, see new header color. {F326502} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11918
2015-03-01 21:03:02 +01:00
'rsrc/image/sprite-main-header.png' => '39419fa6',
Increase height of logo Summary: This increases the transparent space around the Phabricator logo. The logo itself is the same size. This allows for adding of other logos more easily without needing to alter the space provided. (Like Phacility) Test Plan: Reload page, screenshot logo, pull into Photoshop and verify spacing top and bottom. {F309985} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11828
2015-02-19 23:43:33 +01:00
'rsrc/image/sprite-menu-X2.png' => '1c90d7bc',
'rsrc/image/sprite-menu.png' => '619781ee',
Rename group to users in project icons Summary: Fixes T6972. Test Plan: Set icon to typeahead icon in edit project image Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6972 Differential Revision: https://secure.phabricator.com/D11391
2015-01-14 19:49:36 +01:00
'rsrc/image/sprite-projects-X2.png' => '8c91c839',
'rsrc/image/sprite-projects.png' => 'ef9dc9b5',
Mail icon for email lists in typeahead Summary: Adds a mail icon to use in the typeahead Also, can we add a special class per obj-type? (May want to special color projects, etc) Will try to live without them. Test Plan: photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8259
2014-02-17 19:06:16 +01:00
'rsrc/image/sprite-tokens-X2.png' => 'b4776580',
'rsrc/image/sprite-tokens.png' => '25b75533',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/texture/card-gradient.png' => '815f26e8',
'rsrc/image/texture/dark-menu-hover.png' => '5fa7ece8',
'rsrc/image/texture/dark-menu.png' => '7e22296e',
'rsrc/image/texture/grip.png' => '719404f3',
'rsrc/image/texture/panel-header-gradient.png' => 'e3b8dcfe',
'rsrc/image/texture/phlnx-bg.png' => '8d819209',
'rsrc/image/texture/pholio-background.gif' => 'ba29239c',
'rsrc/image/texture/table_header.png' => '5c433037',
'rsrc/image/texture/table_header_hover.png' => '038ec3b9',
'rsrc/image/texture/table_header_tall.png' => 'd56b434f',
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'rsrc/js/application/aphlict/Aphlict.js' => '30a6303c',
Use a typeahead for "document types" in global search Summary: - Now that we have "browse", this is a much more reasonable control for random sets of things. - The new explicit search scope selector reduces the need to fiddle with this field manually, too. Test Plan: {F379292} {F379293} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12510
2015-04-23 00:25:34 +02:00
'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => 'ee37f73a',
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => 'b1a59974',
Minor tidying of Aphlict code Summary: Just some housekeeping... mostly just removing some unused variables. Test Plan: Checked that I was still about to receive notifications from `/notification/status/`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11398
2015-01-14 22:08:08 +01:00
'rsrc/js/application/aphlict/behavior-aphlict-status.js' => 'ea681761',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
Conpherence - improve stack re: non-update updates Summary: Fixes T7761. Fixes T7318. When we send an empty message to the server, pretend its just a request to load the page. Make load a bit smarter such that if we don't get back any transactions, rather than error like the fool, just send down to the client the notion of a 'non_update'. Instrument the client to just turn off the appropriate loading state, etc for a non update. T7318 is a tricky beast since we don't know exactly how to reproduce it but if / when it occurs again it would be some other bizarre application behavior maybe? We won't be getting the execption anymore, that's for sure. Test Plan: removed code in `ConpherenceThreadManager.sendMessage` that protects against sending empty messages. sent empty messages (non updates) like whoa and everything worked on both durable column and main column view. re-added the code in `ConpherenceThreadManager.sendMessage` and noted empty messages did not send while any text including a space sent up nicely Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7318, T7761 Differential Revision: https://secure.phabricator.com/D12339
2015-04-10 00:07:12 +02:00
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '0a5192c4',
Quicksand - update title while navigating about Summary: Fixes T7744. Also fixes a bug where we were copying the response object erroneously; that's not necessary to move around since we cleanly initialize it for each load Test Plan: from user profile, clicked feed tab and saw new title. clicked calendar tab and saw new title. clicked back and saw feed title and page render. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7744 Differential Revision: https://secure.phabricator.com/D12487
2015-04-21 20:01:05 +02:00
'rsrc/js/application/conpherence/behavior-durable-column.js' => '657c2b50',
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'rsrc/js/application/conpherence/behavior-menu.js' => '077a1dab',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
Conpherence - get #anchor links to messages working Summary: Ref T7757. Oddities include: - not working in column view, since the generic anchor technology conflicts once you navigate to a page with a transaction timeline view - not working if you are linking to a message not included in initial load Remaining work is addressing these oddities. - make column view timestamp link to full conpherence correctly? - make back end load from hyperlinked transaction forward? or do it more like application transactions and have the client keep requesting stuff until it gets it? Open to suggestions! :D Test Plan: played around in conpherence full and stuff looked okay. noted no changes as intended in column view. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7757 Differential Revision: https://secure.phabricator.com/D12402
2015-04-14 00:24:48 +02:00
'rsrc/js/application/conpherence/behavior-widget-pane.js' => '93568464',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'rsrc/js/application/countdown/timer.js' => 'e4cc26b3',
Dashboards - add remove functionality Summary: To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084. Test Plan: removed some panels to much success Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078, T5084 Differential Revision: https://secure.phabricator.com/D9156
2014-05-19 23:04:26 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => '469c0d9e',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
Don't highlight very large files by default Summary: Ref T5644. See some discussion in D8040. When a file is very large (more than 64KB of text), don't activate syntax highlighting by default. This should prevent us from wasting resources running `pygmentize` on enormous files. Users who want the file highlighted can still select "Highlight As...". The tricky part of this diff is separating the headers into "changeset" headers and "undershield" (rendering) headers. Specifically, a file might have these headers/shields: - "This file is newly added." - "This file is generated. Show Changes" - "Highlighting is disabled for this large file." In this case, I want the user to see "added" and "generated" when they load the page, and only see "highlighting disabled" after they click "Show Changes". So there are several categories: - "Changeset" headers, which discuss the changeset as a whole (binary file, image file, moved, added, deleted, etc.) - "Property" headers, which describe metadata changes (not relevant here). - "Shields", which hide files from view by default. - "Undershield" headers, which provide rendering information that is only relevant if there is no shield on the file. Test Plan: - Viewed a diff with the library map, clicked "show changes", got a "highlighting disabled" header back with highlighting disabled. - Enabled highlighting explicitly (this currently restores the shield, which it probably shouldn't, but that feels out of scope for this change). The deshielded file is highlighted per the user's request. - Loaded context on normal files. Reviewers: btrahan Reviewed By: btrahan Subscribers: joshuaspence, epriestley Maniphest Tasks: T5644 Differential Revision: https://secure.phabricator.com/D12132
2014-06-29 21:07:46 +02:00
'rsrc/js/application/differential/ChangesetViewManager.js' => '58562350',
Touch up PHP/JS interactions for inline comments Summary: Ref T1460. Overall: - Pass `objectOwnerPHID` consistently. - Pass viewer consistently. - Set the correct draft state for checkboxes on the client. Test Plan: - Made inline comments in Differential. - Made inline comments in Diffusion. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12186
2015-03-28 01:08:31 +01:00
'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '2529c82d',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
When deleting inline comments, offer "undo" instead of prompting Summary: Ref T2009. Ref T1460. Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete". Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure. Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes. Test Plan: - Deleted and undid deletion of inlines from main view and preview. - Clicked "View" on inlines. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6464, T4999, T2618, T1460, T2009 Differential Revision: https://secure.phabricator.com/D12032
2015-03-10 01:27:51 +01:00
'rsrc/js/application/differential/behavior-comment-preview.js' => '8e1389b5',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
Make "Show Context" persist rendering, whitespace, encoding, etc Summary: Ref T2009. Currently, we do not persist view parameters when making context rendering requests. The big one is the renderer (1up vs 2up). This makes context on unified diffs come in with too many columns. However, it impacts other parameters too. For example, at HEAD, if you change highlighting to "rainbow" and then load more context, the context uses the original highlighter instead of the rainbow highlighter. This moves context loads into ChangesetViewManager, which maintains view parameters and can provide them correctly. - This removes "ref"; it is no longer required, as the ChangesetViewManager tracks it. - This removes URI management from `behavior-show-more`; it is no longer required, since the ChangesetViewManager knows how to render. - This removes "whitespace" since this is handled properly by the view manager. Test Plan: - Used "Show Top" / "Show All" / "Show Bottom" in 1-up and 2-up views. - Changed file highlighting to rainbow, loaded stuff, saw rainbow stick. - Used "Show Entire File" in 1-up and 2-up views. - Saw loading chrome. - No loading chrome normally. - Made inlines, verified `copyRows()` code runs. - Poked around Diffusion -- it is missing some parameter handling, but works OK. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11977
2015-03-05 23:03:00 +01:00
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '2035b9cb',
Track a "Done" state on inline comments Summary: Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc. Specifically, these are the behaviors: - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider.."). - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff. - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold: - Be consistent with how inlines work. - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories. - The actual bit where done-ness publishes isn't implemented. - UI is bare bones. - No integration with the rest of the UI yet. Test Plan: Clicked some checkboxes. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: paulshen, chasemp, epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12033
2015-03-10 02:41:47 +01:00
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => 'e723c323',
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'rsrc/js/application/differential/behavior-populate.js' => '8694b1df',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/differential/behavior-show-field-details.js' => 'bba9eedf',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/differential/behavior-toggle-files.js' => 'ca3f91eb',
'rsrc/js/application/differential/behavior-user-select.js' => 'a8d8459d',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => 'b42eddc7',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'd835b03a',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/application/diffusion/behavior-commit-branches.js' => 'bdaf4d04',
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'rsrc/js/application/diffusion/behavior-commit-graph.js' => '9007c197',
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'rsrc/js/application/diffusion/behavior-jump-to.js' => '73d09eef',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/diffusion/behavior-load-blame.js' => '42126667',
Git did not 3-way merge this quite correctly.
2014-05-13 23:09:00 +02:00
'rsrc/js/application/diffusion/behavior-locate-file.js' => '6d3e1947',
Vegetables have vitamins.
2014-05-12 20:53:31 +02:00
'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => '2b228192',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/herald/HeraldRuleEditor.js' => '9229e764',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f5d1233b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
Fix Maniphest Reports scrolling issues Summary: Fixes T7099, also picked some new colors. Raphael can bind the graph to a dom element, which resolved the scrolling issue. Test Plan: Tested scrolling on my laptop, desktop. Seems resolved. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Maniphest Tasks: T7099 Differential Revision: https://secure.phabricator.com/D11879
2015-02-24 18:41:37 +01:00
'rsrc/js/application/maniphest/behavior-line-chart.js' => '88f0c5b3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '84845b5b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/maniphest/behavior-transaction-controls.js' => '44168bad',
'rsrc/js/application/maniphest/behavior-transaction-expand.js' => '5fefb143',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/maniphest/behavior-transaction-preview.js' => 'f8248bc5',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/owners/OwnersPathEditor.js' => 'aa1733d0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/owners/owners-path-editor.js' => '7a68dda3',
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'rsrc/js/application/passphrase/passphrase-credential-control.js' => '3cb0b2fc',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/phame/phame-post-preview.js' => 'be807912',
'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '9c2623f4',
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => 'e58bf807',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
'rsrc/js/application/policy/behavior-policy-control.js' => 'f3fef818',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/ponder/behavior-votebox.js' => '4e9b766b',
Move general workboard actions to "Manage Board" dropdown Summary: See D9719. Test Plan: - Used hide/show columns. - Used "add column". - Filtered board. {F170133} Reviewers: chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D9726
2014-06-25 21:30:53 +02:00
'rsrc/js/application/projects/behavior-boards-dropdown.js' => '0ec56e1d',
Add JX.Leader: synchronization over localStorage Summary: Ref T6559. Adds a "JX.Leader" primitive to replace the synchronization over Flash. This does a couple of things: - Offers an "onBecomeLeader" event, which we can use to open the WebSocket. - Offers an "onReceiveMessage" event, which we can use to dispatch notifications and handle requests to play sounds and send desktop notifications. - Offers a "broadcast()" method, which we can use to send desktop notification and sound requests. Test Plan: Added some code like this: ``` if (!statics.leader) { statics.leader = true; JX.Leader.listen('onBecomeLeader', function() { JX.log("This tab is now the leader."); }); JX.Leader.listen('onReceiveBroadcast', function(message, is_leader) { JX.log('[' + (is_leader ? 'As Leader' : 'Not Leader') + '] ' + message); }); JX.Leader.start(); } ``` Then: - Saw first tab open become leader reliably in Safari, Chrome, Firefox. - Saw new tab become leader reliably when the first tab was closed. - Saw broadcast() work as documented and deliver messages with correct leadership-flag and uniqueness. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6559 Differential Revision: https://secure.phabricator.com/D11235
2015-01-07 02:50:40 +01:00
'rsrc/js/application/projects/behavior-project-boards.js' => '87cb6b51',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'rsrc/js/application/releeph/releeph-request-state-change.js' => 'a0b57eb8',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/repository/repository-crossreference.js' => 'f9539603',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6',
Remove ajaxey comment magic in Pholio, and also some bugs Summary: Fixes T5424. - One concrete issue: drafts were not being cleared properly because `__draft__` was not set on submission. This (mostly) fixes phantom drafts. - This ajax comment magic feels weird and floaty and generally has problems. For example, if you add subscribers or inlines, all the stuff on the page which represents those won't update automatically. Instead, just reload. Maybe we'll ajax this stuff some day, but it feels like a net negative for now. - Also remove it from other applications where it's currently used. - Fix an issue with inline previews. Test Plan: Made some comments on a mock, everything worked normally like I expected it to. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5424 Differential Revision: https://secure.phabricator.com/D9649
2014-06-21 21:50:40 +02:00
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/uiexample/ReactorButtonExample.js' => 'd19198c8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/uiexample/ReactorCheckboxExample.js' => '519705ea',
'rsrc/js/application/uiexample/ReactorFocusExample.js' => '40a6a403',
'rsrc/js/application/uiexample/ReactorInputExample.js' => '886fd850',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/uiexample/ReactorMouseoverExample.js' => '47c794d8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/uiexample/ReactorRadioExample.js' => '988040b4',
'rsrc/js/application/uiexample/ReactorSelectExample.js' => 'a155550f',
'rsrc/js/application/uiexample/ReactorSendClassExample.js' => '1def2711',
'rsrc/js/application/uiexample/ReactorSendPropertiesExample.js' => 'b1f0ccee',
'rsrc/js/application/uiexample/busy-example.js' => '60479091',
'rsrc/js/application/uiexample/gesture-example.js' => '558829c2',
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'rsrc/js/core/Busy.js' => '59a7976a',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'rsrc/js/core/DragAndDropFileUpload.js' => '07de8873',
Fix three issues with scrolling while dragging items (e.g., on workboards) Summary: Fixes T5979. There are three issues here: - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls. - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list. - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this. Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5979 Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 23:20:27 +02:00
'rsrc/js/core/DraggableList.js' => 'a16ec1c6',
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'rsrc/js/core/FileUpload.js' => '477359c8',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/core/Hovercard.js' => '7e8468ae',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'rsrc/js/core/KeyboardShortcutManager.js' => 'c1700f6f',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/core/Notification.js' => '0c6946e7',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'rsrc/js/core/Prefab.js' => '6920d200',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
Clean up image file diffs UI Summary: Uses AphrontTable now, cleans up interactions. Fixes T5874, Fixes T4910 Test Plan: tested a large image {F192585} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4910, T5874 Differential Revision: https://secure.phabricator.com/D10296
2014-08-19 23:46:37 +02:00
'rsrc/js/core/TextAreaUtils.js' => '5c93c52c',
Don't revert Conpherence page titles when updating notifications Summary: Fixes T7709. `JX.Title` deals with adding `(1)`, etc., counts, so send updates through it. Test Plan: Clicked between some threads in Conpherence, no title flickering. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7709 Differential Revision: https://secure.phabricator.com/D12260
2015-04-02 22:41:48 +02:00
'rsrc/js/core/Title.js' => 'df5e11d2',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/js/core/ToolTip.js' => '1d298e3a',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-active-nav.js' => 'e379b58e',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-audio-source.js' => '59b251eb',
'rsrc/js/core/behavior-autofocus.js' => '7319e029',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
'rsrc/js/core/behavior-choose-control.js' => '6153c708',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-crop.js' => 'fa0f4fc2',
Quicksand - remove code not ready for production re: dark console Summary: goofed and slipped this into D12499 as I was working on T7700 too. Test Plan: noted console.log output not there Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12513
2015-04-23 02:12:58 +02:00
'rsrc/js/core/behavior-dark-console.js' => '08883e8b',
Improve column device behaviors Summary: Fixes T7062. When the column is open, we only want to consider the screen width which is avilable for content when computing responsive breakpoints. Specificially, if you have a 1000px wide browser window (normally "desktop") but the column is open (300px) so you only have 700px free for content (normally "tablet"), we should drop to the tablet breakpoint. This lets you have a narrow column of "tablet" content next to the chat column, instead of a really squished column of "desktop" contnet. This also means the chat column can't directly use JX.Device to hide itself. Test Plan: Resized screen with column open, saw content go from Desktop + Column -> Tablet + Column -> Tablet -> Mobile. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7062 Differential Revision: https://secure.phabricator.com/D12189
2015-03-28 14:54:23 +01:00
'rsrc/js/core/behavior-device.js' => 'a205cf28',
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '6d49590e',
Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063
2014-12-30 11:51:31 +01:00
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
Modernize DatePicker Summary: Fixes T5893. Uses more standard colors / spacing / shadows / icons. Test Plan: pick dates {F191310} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5893 Differential Revision: https://secure.phabricator.com/D10285
2014-08-16 23:55:22 +02:00
'rsrc/js/core/behavior-fancy-datepicker.js' => 'c51ae228',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-file-tree.js' => '88236f00',
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'rsrc/js/core/behavior-form.js' => '5c54cbf3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-gesture.js' => '3ab51e2c',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'rsrc/js/core/behavior-global-drag-and-drop.js' => '3f6075ff',
Modernize user activity logs (ApplicationSearch, policies) Summary: Ref T4398. Ref T4842. I want to let users review their own account activity, partly as a general security measure and partly to make some of the multi-factor stuff easier to build and debug. To support this, implement modern policies and application search. I also removed the "old" and "new" columns from this output, since they had limited utility and revealed email addresses to administrators for some actions. We don't let administrators access email addresses from other UIs, and the value of doing so here seems very small. Test Plan: Used interface to issue a bunch of queries against user logs, got reasonable/expected results. Reviewers: btrahan Reviewed By: btrahan Subscribers: keir, epriestley Maniphest Tasks: T4842, T4398 Differential Revision: https://secure.phabricator.com/D8856
2014-04-28 02:31:35 +02:00
'rsrc/js/core/behavior-high-security-warning.js' => '8fc1c918',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-history-install.js' => '7ee2b591',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-hovercard.js' => 'f36e01af',
'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-keyboard-shortcuts.js' => 'd75709e6',
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'rsrc/js/core/behavior-lightbox-attachments.js' => 'f8ba29d7',
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'rsrc/js/core/behavior-line-linker.js' => '1499a8cb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-more.js' => 'a80d0378',
Include object url in object selector selection Summary: Fixes T6452, provides actual href instead of just # Test Plan: Control click and open link in new window, is correct task. Click and see item added to selection list. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6452 Differential Revision: https://secure.phabricator.com/D10774
2014-11-03 17:20:15 +01:00
'rsrc/js/core/behavior-object-selector.js' => '49b73b36',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/core/behavior-oncopy.js' => '2926fff2',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-phabricator-nav.js' => '14d7a8b8',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'e32d14ab',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/js/core/behavior-refresh-csrf.js' => '7814b593',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-remarkup-preview.js' => 'f7379f45',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-reorder-applications.js' => '76b9fc3e',
'rsrc/js/core/behavior-reveal-content.js' => '60821bc7',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'rsrc/js/core/behavior-search-typeahead.js' => 'c5172d25',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/js/core/behavior-toggle-class.js' => 'e566f52c',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-tokenizer.js' => 'b3a4b884',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
'rsrc/js/core/behavior-tooltip.js' => '3ee3408b',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/js/core/behavior-watch-anchor.js' => '9f36c42d',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/js/core/behavior-workflow.js' => '0a3f3021',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/phtize.js' => 'd254d646',
Fix tabs losing scroll position Summary: we were missing an e.kill(). Fixes T5754. Test Plan: looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved! Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5754 Differential Revision: https://secure.phabricator.com/D10111
2014-08-01 21:29:48 +02:00
'rsrc/js/phui/behavior-phui-object-box-tabs.js' => '2bfa2836',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js' => '4d94d9c3',
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'symbols' => array(
Allow Almanac service types to define default properties Summary: Ref T5833. This allows Almanac ServiceTypes to define default properties for a service, which show up in the UI and are more easily editable. Overall, this makes it much easier to make structured/usable/consistent service records: you can check a checkbox that says "prevent new allocations" instead of needing to know the meaning of a key. Test Plan: {F251593} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5833 Differential Revision: https://secure.phabricator.com/D10996
2014-12-17 20:10:50 +01:00
'almanac-css' => 'dbb9b3af',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'aphront-bars' => '231ac33c',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'aphront-dark-console-css' => '6378ef3d',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'aphront-dialog-view-css' => '9fddf890',
AphrontFilterView should have 8px spacing on tablet Summary: Adds a tablet breakpoint CSS for better filter alignment on tablet. Test Plan: Review desktop, tablet, and mobile breakpoints on an ApplicationSearch Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12332
2015-04-08 19:44:11 +02:00
'aphront-list-filter-view-css' => 'b2161041',
Send on enter in Conpherence chat column Summary: Ref T7538. We can figure out whether to backport this to main Conpherence later and/or remove buttons, etc., but this behavior seems pretty clearly good. Test Plan: - Pressed enter (sent message). - Pressed shift+enter (newline). Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7538 Differential Revision: https://secure.phabricator.com/D12085
2015-03-14 19:16:47 +01:00
'aphront-multi-column-view-css' => 'fd18389d',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'aphront-pager-view-css' => '2e3539af',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'aphront-panel-view-css' => '8427b78d',
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'aphront-table-view-css' => '59e2c0f8',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'aphront-tokenizer-control-css' => '86a13f7f',
Add some spacing around jx-tooltips Summary: Using tooltips with icons is problematic because we currently draw the arrow after the tooltip location, meaning it goes 5px into the container. This gives a 5px padding around the outer container to better account for this. Test Plan: tested tooltips in remarkup bar, project icon nav, and in durable column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12184
2015-03-27 18:38:28 +01:00
'aphront-tooltip-css' => '7672b60f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'aphront-two-column-view-css' => '16ab3ad2',
Minor indentation fixes Summary: Some CSS files are indented inconsistently, with a single space instead of two. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11061
2014-12-30 11:48:53 +01:00
'aphront-typeahead-control-css' => '0e403212',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'auth-css' => '1e655982',
Don't highlight very large files by default Summary: Ref T5644. See some discussion in D8040. When a file is very large (more than 64KB of text), don't activate syntax highlighting by default. This should prevent us from wasting resources running `pygmentize` on enormous files. Users who want the file highlighted can still select "Highlight As...". The tricky part of this diff is separating the headers into "changeset" headers and "undershield" (rendering) headers. Specifically, a file might have these headers/shields: - "This file is newly added." - "This file is generated. Show Changes" - "Highlighting is disabled for this large file." In this case, I want the user to see "added" and "generated" when they load the page, and only see "highlighting disabled" after they click "Show Changes". So there are several categories: - "Changeset" headers, which discuss the changeset as a whole (binary file, image file, moved, added, deleted, etc.) - "Property" headers, which describe metadata changes (not relevant here). - "Shields", which hide files from view by default. - "Undershield" headers, which provide rendering information that is only relevant if there is no shield on the file. Test Plan: - Viewed a diff with the library map, clicked "show changes", got a "highlighting disabled" header back with highlighting disabled. - Enabled highlighting explicitly (this currently restores the shield, which it probably shouldn't, but that feels out of scope for this change). The deshielded file is highlighted per the user's request. - Loaded context on normal files. Reviewers: btrahan Reviewed By: btrahan Subscribers: joshuaspence, epriestley Maniphest Tasks: T5644 Differential Revision: https://secure.phabricator.com/D12132
2014-06-29 21:07:46 +02:00
'changeset-view-manager' => '58562350',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'config-options-css' => '7fedf08b',
New Admin Welcome Screen Summary: Somewhat easier to parse and present information, with ICONS. Test Plan: Rebuilt current view with new layout. Tested toggling on and off some of the entries. {F327816} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11938
2015-03-03 00:42:25 +01:00
'config-welcome-css' => '6abd79be',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'conpherence-durable-column-view' => '5faebda3',
Move Conpherence when warning is present Summary: Turns out only Conpherence/Durable Column still have issues. Workboards is OK. Simple 2 new CSS classes and punt the issue down the road. Test Plan: Test Workboards, Conpherence, Durable Column with a setup check issue. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12394
2015-04-13 19:30:13 +02:00
'conpherence-menu-css' => 'f389e048',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'conpherence-message-pane-css' => 'e7c09fda',
Reduce subtitle length in Conpherence menu Summary: If you have a subtitle that is long and a new count indicator, they overlap. This gives a little space. Test Plan: fake a count Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12429
2015-04-16 01:19:18 +02:00
'conpherence-notification-css' => 'd208f806',
Conpherence - improve stack re: non-update updates Summary: Fixes T7761. Fixes T7318. When we send an empty message to the server, pretend its just a request to load the page. Make load a bit smarter such that if we don't get back any transactions, rather than error like the fool, just send down to the client the notion of a 'non_update'. Instrument the client to just turn off the appropriate loading state, etc for a non update. T7318 is a tricky beast since we don't know exactly how to reproduce it but if / when it occurs again it would be some other bizarre application behavior maybe? We won't be getting the execption anymore, that's for sure. Test Plan: removed code in `ConpherenceThreadManager.sendMessage` that protects against sending empty messages. sent empty messages (non updates) like whoa and everything worked on both durable column and main column view. re-added the code in `ConpherenceThreadManager.sendMessage` and noted empty messages did not send while any text including a space sent up nicely Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7318, T7761 Differential Revision: https://secure.phabricator.com/D12339
2015-04-10 00:07:12 +02:00
'conpherence-thread-manager' => '0a5192c4',
Greens
2015-04-14 22:06:53 +02:00
'conpherence-transaction-css' => '25138b7f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'conpherence-update-css' => '1099a660',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'conpherence-widget-pane-css' => '2af42ebe',
Likely fix for spooky scrollbar in Firefox Summary: Fixes T7690. Test Plan: This fix worked when I applied it in the DOM inspector. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7690 Differential Revision: https://secure.phabricator.com/D12211
2015-03-30 21:06:40 +02:00
'differential-changeset-view-css' => 'e19cfd6e',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'differential-core-view-css' => '7ac3cabc',
Touch up PHP/JS interactions for inline comments Summary: Ref T1460. Overall: - Pass `objectOwnerPHID` consistently. - Pass viewer consistently. - Set the correct draft state for checkboxes on the client. Test Plan: - Made inline comments in Differential. - Made inline comments in Diffusion. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12186
2015-03-28 01:08:31 +01:00
'differential-inline-comment-editor' => '2529c82d',
Fix mobile CSS for lint/unit results table Summary: Removes nowrap when on mobile devices. Test Plan: Test Lint/Unit layout on mobile and table layouts Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10608
2014-09-30 18:47:54 +02:00
'differential-results-table-css' => '181aa9d9',
Revamp inline commenting UI Summary: Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns: **To the author:** - The author of the diff should be able to easily identify what comments are done and not done. - We keep undone comments yellow - Clicking done turns comment block into 'unsubmitted state' **To the reviewer:** - Easier understanding of unsubmitted states - All conversations to be yellow/important **Todo** - Not all color CSS states correct - Unpulished checkbox support Test Plan: Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states. From the Diff Author's perspective: {F352094} For a Diff commenter's perspective: {F352095} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T1460, T7660, T7503 Differential Revision: https://secure.phabricator.com/D12171
2015-03-28 00:00:09 +01:00
'differential-revision-add-comment-css' => 'c47f8c40',
'differential-revision-comment-css' => '024dda6b',
Fibrous vegeables.
2014-03-12 21:53:04 +01:00
'differential-revision-history-css' => '0e8eb855',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'differential-revision-list-css' => 'f3c47d33',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'differential-table-of-contents-css' => '63f3ef4a',
Remove double border on tables in object boxes Summary: The CSS rule tends to miss many tables, make the rule more universal and add borders as needed. Test Plan: Test a Revision and Diffusion Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9516
2014-06-13 20:36:01 +02:00
'diffusion-icons-css' => '9c5828da',
Send Markdown in Diffusion through SourceSans Summary: This moves Markdown rendering from normal fonts to PHUIDocumentView with Source Sans improving readability of this longer form text. Test Plan: Test libphutil and Phabricator readmes in my sandbox. {F363483} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12330
2015-04-08 18:41:56 +02:00
'diffusion-readme-css' => '2106ea08',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'diffusion-source-css' => '66fdf661',
Support WOFF files in Celerity and add Source Sans Pro Summary: - Allow Celerity to map and serve WOFF files. - Add Source Sans Pro, Source Sans Pro Bold, and the corresponding LICENSE. - Add a `font-source-sans-pro` resource for the font. Test Plan: - Changed body `font-face` to `'Source Sans Pro'`. - Added `require_celerity_resource('font-source-sans-pro')` in StandardPageView. Works in Firefox/Chrome/Safari, at least: {F123296} {F123297} {F123298} Reviewers: btrahan, chad Reviewed By: chad CC: chad, aran Differential Revision: https://secure.phabricator.com/D8430
2014-03-06 20:28:24 +01:00
'diviner-shared-css' => '38813222',
Add support for ".woff2" resources Summary: Ref T7210. Not sure if this fixes things, but it's definitely //an// issue. Test Plan: - Not able to reproduce issue locally yet. - These get into the map now, at least? - Saw `.woff2` URIs transform in CSS. - Loaded a `.woff2` file. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7210 Differential Revision: https://secure.phabricator.com/D11720
2015-02-09 17:12:47 +01:00
'font-fontawesome' => 'ae9a7b4d',
Modernize file storage engine selection Summary: Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend. This mechanism predates widespread use of `PhutilSymbolLoader` to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined). Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the `Selector`, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods). Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster. This uses D12051 to add UI to make it easier to understand the state of storage engines. Test Plan: Used new UI panel to assess storage engines: {F336270} - Uploaded a small file, saw it go to MySQL engine. - Uploaded a larger file, saw it go to S3 engine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5843 Differential Revision: https://secure.phabricator.com/D12053
2015-03-12 21:28:53 +01:00
'font-source-sans-pro' => '4a2430d7',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'global-drag-and-drop-css' => '697324ad',
Hide empty build logs Summary: This automatically hides any empty build logs from Harbormaster, so that they do not appear. Test Plan: Viewed a build plan where the logs were empty and didn't see them appear. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D10091
2014-08-06 02:28:13 +02:00
'harbormaster-css' => '49d64eb4',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'herald-css' => '826075fa',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'herald-rule-editor' => '9229e764',
Moderize Herald UI Summary: Removes many tables and uses PropertyLists and ObjectItemList when possible. Adds cleaner CSS, makes mobile editing more possible. Test Plan: Test new UI on desktop and mobile. Verify all functionality still exists. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4272 Differential Revision: https://secure.phabricator.com/D8860
2014-04-27 20:18:48 +02:00
'herald-test-css' => '778b008e',
Fix Workboard task spacing Summary: Restricts the padding change to homepage only. Derped this. Test Plan: View Homepage, View Workboard. Proper layouts ensue. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11534
2015-01-28 17:45:23 +01:00
'homepage-panel-css' => 'e34bf140',
Update InlineCommentSummary UI Summary: Minor spring cleaning, improve the visual feel of the comments table, more consistent structure. Test Plan: Test multiple comments, long comments, short comments, and multiple lines. {F282462} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11666
2015-02-09 17:38:51 +01:00
'inline-comment-summary-css' => 'eb5f8e8c',
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'javelin-aphlict' => '30a6303c',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-behavior' => '61cbc29a',
Use a typeahead for "document types" in global search Summary: - Now that we have "browse", this is a much more reasonable control for random sets of things. - The new explicit search scope selector reduces the need to fiddle with this field manually, too. Test Plan: {F379292} {F379293} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12510
2015-04-23 00:25:34 +02:00
'javelin-behavior-aphlict-dropdown' => 'ee37f73a',
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'javelin-behavior-aphlict-listen' => 'b1a59974',
Minor tidying of Aphlict code Summary: Just some housekeeping... mostly just removing some unused variables. Test Plan: Checked that I was still about to receive notifications from `/notification/status/`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11398
2015-01-14 22:08:08 +01:00
'javelin-behavior-aphlict-status' => 'ea681761',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-aphront-basic-tokenizer' => 'b3a4b884',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-aphront-crop' => 'fa0f4fc2',
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'javelin-behavior-aphront-drag-and-drop-textarea' => '6d49590e',
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'javelin-behavior-aphront-form-disable-on-submit' => '5c54cbf3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-aphront-more' => 'a80d0378',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-audio-source' => '59b251eb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-audit-preview' => 'd835b03a',
Move general workboard actions to "Manage Board" dropdown Summary: See D9719. Test Plan: - Used hide/show columns. - Used "add column". - Filtered board. {F170133} Reviewers: chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D9726
2014-06-25 21:30:53 +02:00
'javelin-behavior-boards-dropdown' => '0ec56e1d',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
'javelin-behavior-choose-control' => '6153c708',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-config-reorder-fields' => '14a827de',
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'javelin-behavior-conpherence-menu' => '077a1dab',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'javelin-behavior-conpherence-pontificate' => '21ba5861',
Conpherence - get #anchor links to messages working Summary: Ref T7757. Oddities include: - not working in column view, since the generic anchor technology conflicts once you navigate to a page with a transaction timeline view - not working if you are linking to a message not included in initial load Remaining work is addressing these oddities. - make column view timestamp link to full conpherence correctly? - make back end load from hyperlinked transaction forward? or do it more like application transactions and have the client keep requesting stuff until it gets it? Open to suggestions! :D Test Plan: played around in conpherence full and stuff looked okay. noted no changes as intended in column view. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7757 Differential Revision: https://secure.phabricator.com/D12402
2015-04-14 00:24:48 +02:00
'javelin-behavior-conpherence-widget-pane' => '93568464',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-behavior-countdown-timer' => 'e4cc26b3',
Quicksand - remove code not ready for production re: dark console Summary: goofed and slipped this into D12499 as I was working on T7700 too. Test Plan: noted console.log output not there Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12513
2015-04-23 02:12:58 +02:00
'javelin-behavior-dark-console' => '08883e8b',
Dashboards - add remove functionality Summary: To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084. Test Plan: removed some panels to much success Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078, T5084 Differential Revision: https://secure.phabricator.com/D9156
2014-05-19 23:04:26 +02:00
'javelin-behavior-dashboard-async-panel' => '469c0d9e',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-dashboard-move-panels' => '82439934',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
'javelin-behavior-dashboard-query-panel-select' => '453c5375',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-dashboard-tab-panel' => 'd4eecc63',
Improve column device behaviors Summary: Fixes T7062. When the column is open, we only want to consider the screen width which is avilable for content when computing responsive breakpoints. Specificially, if you have a 1000px wide browser window (normally "desktop") but the column is open (300px) so you only have 700px free for content (normally "tablet"), we should drop to the tablet breakpoint. This lets you have a narrow column of "tablet" content next to the chat column, instead of a really squished column of "desktop" contnet. This also means the chat column can't directly use JX.Device to hide itself. Test Plan: Resized screen with column open, saw content go from Desktop + Column -> Tablet + Column -> Tablet -> Mobile. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7062 Differential Revision: https://secure.phabricator.com/D12189
2015-03-28 14:54:23 +01:00
'javelin-behavior-device' => 'a205cf28',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'javelin-behavior-differential-comment-jump' => '4fdb476d',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
Make "Show Context" persist rendering, whitespace, encoding, etc Summary: Ref T2009. Currently, we do not persist view parameters when making context rendering requests. The big one is the renderer (1up vs 2up). This makes context on unified diffs come in with too many columns. However, it impacts other parameters too. For example, at HEAD, if you change highlighting to "rainbow" and then load more context, the context uses the original highlighter instead of the rainbow highlighter. This moves context loads into ChangesetViewManager, which maintains view parameters and can provide them correctly. - This removes "ref"; it is no longer required, as the ChangesetViewManager tracks it. - This removes URI management from `behavior-show-more`; it is no longer required, since the ChangesetViewManager knows how to render. - This removes "whitespace" since this is handled properly by the view manager. Test Plan: - Used "Show Top" / "Show All" / "Show Bottom" in 1-up and 2-up views. - Changed file highlighting to rainbow, loaded stuff, saw rainbow stick. - Used "Show Entire File" in 1-up and 2-up views. - Saw loading chrome. - No loading chrome normally. - Made inlines, verified `copyRows()` code runs. - Poked around Diffusion -- it is missing some parameter handling, but works OK. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11977
2015-03-05 23:03:00 +01:00
'javelin-behavior-differential-dropdown-menus' => '2035b9cb',
Track a "Done" state on inline comments Summary: Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc. Specifically, these are the behaviors: - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider.."). - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff. - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold: - Be consistent with how inlines work. - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories. - The actual bit where done-ness publishes isn't implemented. - UI is bare bones. - No integration with the rest of the UI yet. Test Plan: Clicked some checkboxes. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: paulshen, chasemp, epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12033
2015-03-10 02:41:47 +01:00
'javelin-behavior-differential-edit-inline-comments' => 'e723c323',
When deleting inline comments, offer "undo" instead of prompting Summary: Ref T2009. Ref T1460. Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete". Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure. Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes. Test Plan: - Deleted and undid deletion of inlines from main view and preview. - Clicked "View" on inlines. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6464, T4999, T2618, T1460, T2009 Differential Revision: https://secure.phabricator.com/D12032
2015-03-10 01:27:51 +01:00
'javelin-behavior-differential-feedback-preview' => '8e1389b5',
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'javelin-behavior-differential-populate' => '8694b1df',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-differential-show-field-details' => 'bba9eedf',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-differential-toggle-files' => 'ca3f91eb',
'javelin-behavior-differential-user-select' => 'a8d8459d',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-diffusion-commit-branches' => 'bdaf4d04',
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'javelin-behavior-diffusion-commit-graph' => '9007c197',
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'javelin-behavior-diffusion-jump-to' => '73d09eef',
Git did not 3-way merge this quite correctly.
2014-05-13 23:09:00 +02:00
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
Vegetables have vitamins.
2014-05-12 20:53:31 +02:00
'javelin-behavior-diffusion-pull-lastmodified' => '2b228192',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-doorkeeper-tag' => 'e5822781',
Quicksand - update title while navigating about Summary: Fixes T7744. Also fixes a bug where we were copying the response object erroneously; that's not necessary to move around since we cleanly initialize it for each load Test Plan: from user profile, clicked feed tab and saw new title. clicked calendar tab and saw new title. clicked back and saw feed title and page render. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7744 Differential Revision: https://secure.phabricator.com/D12487
2015-04-21 20:01:05 +02:00
'javelin-behavior-durable-column' => '657c2b50',
Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063
2014-12-30 11:51:31 +01:00
'javelin-behavior-error-log' => '6882e80a',
Modernize DatePicker Summary: Fixes T5893. Uses more standard colors / spacing / shadows / icons. Test Plan: pick dates {F191310} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5893 Differential Revision: https://secure.phabricator.com/D10285
2014-08-16 23:55:22 +02:00
'javelin-behavior-fancy-datepicker' => 'c51ae228',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'javelin-behavior-global-drag-and-drop' => '3f6075ff',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-herald-rule-editor' => '7ebaeed3',
Modernize user activity logs (ApplicationSearch, policies) Summary: Ref T4398. Ref T4842. I want to let users review their own account activity, partly as a general security measure and partly to make some of the multi-factor stuff easier to build and debug. To support this, implement modern policies and application search. I also removed the "old" and "new" columns from this output, since they had limited utility and revealed email addresses to administrators for some actions. We don't let administrators access email addresses from other UIs, and the value of doing so here seems very small. Test Plan: Used interface to issue a bunch of queries against user logs, got reasonable/expected results. Reviewers: btrahan Reviewed By: btrahan Subscribers: keir, epriestley Maniphest Tasks: T4842, T4398 Differential Revision: https://secure.phabricator.com/D8856
2014-04-28 02:31:35 +02:00
'javelin-behavior-high-security-warning' => '8fc1c918',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-history-install' => '7ee2b591',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-icon-composer' => '8ef9ab58',
'javelin-behavior-launch-icon-composer' => '48086888',
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
Fix Maniphest Reports scrolling issues Summary: Fixes T7099, also picked some new colors. Raphael can bind the graph to a dom element, which resolved the scrolling issue. Test Plan: Tested scrolling on my laptop, desktop. Seems resolved. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Maniphest Tasks: T7099 Differential Revision: https://secure.phabricator.com/D11879
2015-02-24 18:41:37 +01:00
'javelin-behavior-line-chart' => '88f0c5b3',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-load-blame' => '42126667',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-behavior-maniphest-batch-editor' => 'f5d1233b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-maniphest-transaction-controls' => '44168bad',
'javelin-behavior-maniphest-transaction-expand' => '5fefb143',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-maniphest-transaction-preview' => 'f8248bc5',
'javelin-behavior-owners-path-editor' => '7a68dda3',
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'javelin-behavior-passphrase-credential-control' => '3cb0b2fc',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-persona-login' => '9414ff18',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-active-nav' => 'e379b58e',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-phabricator-autofocus' => '7319e029',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-busy-example' => '60479091',
'javelin-behavior-phabricator-file-tree' => '88236f00',
'javelin-behavior-phabricator-gesture' => '3ab51e2c',
'javelin-behavior-phabricator-gesture-example' => '558829c2',
'javelin-behavior-phabricator-hovercards' => 'f36e01af',
'javelin-behavior-phabricator-keyboard-pager' => 'a8da01f0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-phabricator-keyboard-shortcuts' => 'd75709e6',
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'javelin-behavior-phabricator-line-linker' => '1499a8cb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-nav' => '14d7a8b8',
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'javelin-behavior-phabricator-notification-example' => '8ce821c5',
Include object url in object selector selection Summary: Fixes T6452, provides actual href instead of just # Test Plan: Control click and open link in new window, is correct task. Click and see item added to selection list. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6452 Differential Revision: https://secure.phabricator.com/D10774
2014-11-03 17:20:15 +01:00
'javelin-behavior-phabricator-object-selector' => '49b73b36',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'javelin-behavior-phabricator-oncopy' => '2926fff2',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'javelin-behavior-phabricator-remarkup-assist' => 'e32d14ab',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-reveal-content' => '60821bc7',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'javelin-behavior-phabricator-search-typeahead' => 'c5172d25',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-behavior-phabricator-show-older-transactions' => 'dbbf48b6',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
'javelin-behavior-phabricator-tooltips' => '3ee3408b',
Remove ajaxey comment magic in Pholio, and also some bugs Summary: Fixes T5424. - One concrete issue: drafts were not being cleared properly because `__draft__` was not set on submission. This (mostly) fixes phantom drafts. - This ajax comment magic feels weird and floaty and generally has problems. For example, if you add subscribers or inlines, all the stuff on the page which represents those won't update automatically. Instead, just reload. Maybe we'll ajax this stuff some day, but it feels like a net negative for now. - Also remove it from other applications where it's currently used. - Fix an issue with inline previews. Test Plan: Made some comments on a mock, everything worked normally like I expected it to. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5424 Differential Revision: https://secure.phabricator.com/D9649
2014-06-21 21:50:40 +02:00
'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb',
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'javelin-behavior-phabricator-transaction-list' => '13c739ea',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-behavior-phabricator-watch-anchor' => '9f36c42d',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phame-post-preview' => 'be807912',
'javelin-behavior-pholio-mock-edit' => '9c2623f4',
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'javelin-behavior-pholio-mock-view' => 'e58bf807',
Fix tabs losing scroll position Summary: we were missing an e.kill(). Fixes T5754. Test Plan: looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved! Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5754 Differential Revision: https://secure.phabricator.com/D10111
2014-08-01 21:29:48 +02:00
'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
'javelin-behavior-policy-control' => 'f3fef818',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-behavior-policy-rule-editor' => '5e9f347c',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-ponder-votebox' => '4e9b766b',
Add JX.Leader: synchronization over localStorage Summary: Ref T6559. Adds a "JX.Leader" primitive to replace the synchronization over Flash. This does a couple of things: - Offers an "onBecomeLeader" event, which we can use to open the WebSocket. - Offers an "onReceiveMessage" event, which we can use to dispatch notifications and handle requests to play sounds and send desktop notifications. - Offers a "broadcast()" method, which we can use to send desktop notification and sound requests. Test Plan: Added some code like this: ``` if (!statics.leader) { statics.leader = true; JX.Leader.listen('onBecomeLeader', function() { JX.log("This tab is now the leader."); }); JX.Leader.listen('onReceiveBroadcast', function(message, is_leader) { JX.log('[' + (is_leader ? 'As Leader' : 'Not Leader') + '] ' + message); }); JX.Leader.start(); } ``` Then: - Saw first tab open become leader reliably in Safari, Chrome, Firefox. - Saw new tab become leader reliably when the first tab was closed. - Saw broadcast() work as documented and deliver messages with correct leadership-flag and uniqueness. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6559 Differential Revision: https://secure.phabricator.com/D11235
2015-01-07 02:50:40 +01:00
'javelin-behavior-project-boards' => '87cb6b51',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-project-create' => '065227cc',
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'javelin-behavior-quicksand-blacklist' => '7927a7d3',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'javelin-behavior-refresh-csrf' => '7814b593',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'javelin-behavior-releeph-request-state-change' => 'a0b57eb8',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-behavior-releeph-request-typeahead' => 'de2e896f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-remarkup-preview' => 'f7379f45',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-reorder-applications' => '76b9fc3e',
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'javelin-behavior-reorder-columns' => 'e1d25dfb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-repository-crossreference' => 'f9539603',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'javelin-behavior-scrollbar' => '834a1173',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-search-reorder-queries' => 'e9581f08',
'javelin-behavior-select-on-click' => '4e3e79a6',
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'javelin-behavior-slowvote-embed' => '887ad43f',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
'javelin-behavior-test-payment-form' => 'fc91ab6c',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-behavior-toggle-class' => 'e566f52c',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-behavior-typeahead-browse' => '635de1ec',
'javelin-behavior-typeahead-search' => '93d0c9e3',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-behavior-view-placeholder' => '47830651',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'javelin-behavior-workflow' => '0a3f3021',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-color' => '7e41274a',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'javelin-cookie' => '62dfea03',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'javelin-diffusion-locate-file-source' => 'b42eddc7',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-dom' => '6f7962d5',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-dynval' => 'f6555212',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-event' => '85ea0626',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-fx' => '54b612ba',
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'javelin-history' => 'd4505101',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-install' => '05270951',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-json' => '69adf288',
Fix an undefined variable Summary: Identifed by linting with JSHint. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11433
2015-01-22 21:22:26 +01:00
'javelin-leader' => '331b1611',
Scroll the chat column to the bottom when images load Summary: Fixes T7558. This might not be 100% perfect but should solve most of the issue. I briefly looked at things like `MutationObserver` (some fancy next-gen browser junk) but couldn't immediately get it working. Other methods for handling this kind of thing involve polling, complicated polyfills, etc. We could give `MutationObserver` a more serious effort if this is too leaky. Test Plan: - In a thread with some images, reloaded the page and saw the scrollbar stay at the bottom. - Tested with and without USB devices attached. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7558 Differential Revision: https://secure.phabricator.com/D12191
2015-03-28 16:35:12 +01:00
'javelin-magical-init' => '3010e992',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-mask' => '8a41885b',
Quicksand - make notification and message counts update as you navigate around Summary: Ref T7573. Unify code to fetch these counts and do some light formatting since we're going to need to do the same thing for some conpherence-specific ajax in the durable column (See T7708). Test Plan: loaded up two tabs, one with a durable column on and one without. in the without browser, i read some messages, decrementing my unread count. when i navigated again in the durable column browser, the count updated correctly. with no notifications, commented on a task with another user to get a notification and it showed up properly. visited the task by clicking not the notification and the bubble count decremented correctly Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7573 Differential Revision: https://secure.phabricator.com/D12498
2015-04-22 00:46:36 +02:00
'javelin-quicksand' => '517545ab',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactor' => '2b8de964',
'javelin-reactor-dom' => 'c90a04fc',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-reactor-node-calmer' => '76f4ebed',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactornode' => '1ad0a787',
'javelin-request' => '94b750d2',
'javelin-resource' => '44959b73',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'javelin-routable' => 'b3e7d692',
'javelin-router' => '29274e2b',
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'javelin-scrollbar' => 'eaa5b321',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'javelin-sound' => '949c0fe5',
Use dot notation in some places Summary: Use `x.y` in favor of `x['y']` in //some// JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick `PhabricatorJavelinLinter`. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11442
2015-01-28 21:42:05 +01:00
'javelin-stratcom' => '6c53634d',
Support tokenizer functions in Diffusion Summary: Ref T4100. Ref T5595. Support tokenizer functions + edgelogic for repositories. Test Plan: Searched for repositories. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5595, T4100 Differential Revision: https://secure.phabricator.com/D12533
2015-04-23 17:25:17 +02:00
'javelin-tokenizer' => 'ab5f468d',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-typeahead' => '70baed2f',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-typeahead-composite-source' => '503e17fd',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-typeahead-normalizer' => 'e6e25838',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-typeahead-ondemand-source' => '8b3fd187',
'javelin-typeahead-preloaded-source' => '54f314a0',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'javelin-typeahead-source' => '2818f5ce',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-typeahead-static-source' => '316b8fa1',
'javelin-uri' => '6eff08aa',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'javelin-util' => '93cc50d6',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-vector' => '2caa8fb8',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-view' => '0f764c35',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-view-html' => 'fe287620',
'javelin-view-interpreter' => 'f829edb3',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-view-renderer' => '6c2b09a2',
'javelin-view-visitor' => 'efe49472',
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'javelin-websocket' => 'e292eaf4',
Improve Conpherence column textarea JS behaviors Summary: - Don't show a loading state on the whole column while sending chat. We could show some kind of minor loading state, but standard JX.Busy stuff will kick in after a couple seconds anyway. - Blank the textarea immediately on submit so you can start typing more text. - Don't disable the form while submiting; disabling it prevents you from typing more text. - Hide the placeholder while the textarea is focused. If we don't do this, the placeholder reappearing after submitting text feels weird to me. Test Plan: - Sent a lot of text. - Real fast. - Focused and unfocused the area. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12086
2015-03-14 20:00:17 +01:00
'javelin-workflow' => '5b2e3e2b',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'lightbox-attachment-css' => '7acac05d',
'maniphest-batch-editor' => '8f380ebc',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'maniphest-report-css' => 'f6931fdf',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'maniphest-task-edit-css' => '8e23031b',
Clean up various mobile spacing Summary: Things on mobile should be 8px gutter. Test Plan: view in smaller browser windows Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11525
2015-01-27 19:24:28 +01:00
'maniphest-task-summary-css' => 'ab2fc691',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'multirow-row-manager' => 'b5d57730',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'owners-path-editor' => 'aa1733d0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'owners-path-editor-css' => '2f00933b',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'paste-css' => 'eb997ddd',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'path-typeahead' => 'f7fc67ec',
Fix slowvote exception when viewing description diff Summary: Fixes T6937. We weren't passing required parameters. Test Plan: Followed repro steps in task. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6937 Differential Revision: https://secure.phabricator.com/D11346
2015-01-12 16:20:20 +01:00
'people-profile-css' => '25970776',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'phabricator-action-list-view-css' => '4f4d09f2',
Roll out more FontIcons Summary: Sidenav launcher, search typeahead results, apps launcher Test Plan: Used each of these items {F275814} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11499
2015-01-26 17:19:22 +01:00
'phabricator-application-launch-view-css' => '16ca323f',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'phabricator-busy' => '59a7976a',
Make chatlog bg white Summary: More white, less whitesmoke. Test Plan: rload chatlg Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8207
2014-02-12 18:55:53 +01:00
'phabricator-chatlog-css' => '852140ff',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-content-source-view-css' => '4b8b05d4',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'phabricator-core-css' => '76e8ee93',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-countdown-css' => '86b7b0a0',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phabricator-dashboard-css' => '17937d22',
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'phabricator-drag-and-drop-file-upload' => '07de8873',
Fix three issues with scrolling while dragging items (e.g., on workboards) Summary: Fixes T5979. There are three issues here: - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls. - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list. - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this. Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5979 Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 23:20:27 +02:00
'phabricator-draggable-list' => 'a16ec1c6',
Make base font a Celerity CSS variable Summary: For consistency, we switch back to base font in a few places when using alternate fonts like source-sans or monospace, this makes sure the base font is consistently reset. Test Plan: Review a Document, a Diff, and a Legalpad form Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11891
2015-02-26 18:26:36 +01:00
'phabricator-fatal-config-template-css' => '8e6c6fcd',
Minor fixes for CSS linter issues Summary: Fixes a few line length linter issues with CSS resources. Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11060
2014-12-30 11:48:26 +01:00
'phabricator-feed-css' => 'b513b5f4',
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'phabricator-file-upload' => '477359c8',
[Redesign] Update Filetree CSS Summary: Tweaks colors, updates icons Test Plan: Tested a filetree view, clicked and hovered. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9335
2014-05-30 01:04:50 +02:00
'phabricator-filetree-view-css' => 'fccf9f82',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'phabricator-flag-css' => '5337623f',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'phabricator-hovercard' => '7e8468ae',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'phabricator-hovercard-view-css' => '44394670',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-keyboard-shortcut' => '1ae869f2',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
Carrots are awesome with vegetables Summary: Use an angle-down icon instead of hard edged caret for search bar. I tested replacing this globally, but it didn't hold up as well. Test Plan: hover states, desktop, tablet, mobile. {F379596} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12521
2015-04-23 05:30:51 +02:00
'phabricator-main-menu-view' => 'c75df9ed',
Minor fixes for CSS linter issues Summary: Fixes a few line length linter issues with CSS resources. Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11060
2014-12-30 11:48:26 +01:00
'phabricator-nav-view-css' => '7aeaf435',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'phabricator-notification' => '0c6946e7',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'phabricator-notification-css' => '9c279160',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'phabricator-notification-menu-css' => '3c9d8aa1',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-object-selector-css' => '029a133d',
'phabricator-phtize' => 'd254d646',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'phabricator-prefab' => '6920d200',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phabricator-profile-css' => '1a20dcbf',
Move ToC in Phriction to it's own column Summary: Adds additional CSS to make the Table of Contents into it's own column (if one exists). Test Plan: Tested a page with and without a table of contents. Tested tablet, mobile, and desktop breakpoints. Tested Conpherence, scrolling seemed fine still on trackpad and mouse. {F370973} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12417
2015-04-15 01:02:30 +02:00
'phabricator-remarkup-css' => 'e10512ff',
Clean up copy detection code a bit Summary: Ref T1266. This doesn't change any behaviors, but some of this code has a lot of really complicated conditionals and I tried to break that up a bit. Also, reexpress this stuff in terms of the "structured" parser in D12144. Test Plan: Unit tests still pass. They aren't hugely comprehensive but did reliably fail when I screwed stuff up. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1266 Differential Revision: https://secure.phabricator.com/D12145
2015-03-24 21:12:09 +01:00
'phabricator-search-results-css' => '15c71110',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'phabricator-shaped-request' => '7cbe244b',
Revamp Projects with new navigation Summary: A refresh of Projects including a new navigations UI. - New Navigation UI. - Auto switch default page if Workboard has been initialized - Move Feed to it's own page - Increase 'tasks' on Project Home to 50 over 10 - Fix various display bugs on Workboards - Remove 'crumbs' from Project portal (unneeded). Test Plan: - clicked a link for a project with no workboard and saw the profile - clicked a link for a project with a workboard and saw the workboard - navigated around the various edit pages, inspecting links and making sure things linked back to the new profile uri {F266460} {F266461} {F266462} {F266463} {F266464} Reviewers: epriestley, btrahan Reviewed By: epriestley, btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11272
2015-01-12 19:04:01 +01:00
'phabricator-side-menu-view-css' => '7e8c6341',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-slowvote-css' => '266df6a1',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'phabricator-source-code-view-css' => '2ceee894',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'phabricator-standard-page-view' => 'd3e1abe9',
Clean up image file diffs UI Summary: Uses AphrontTable now, cleans up interactions. Fixes T5874, Fixes T4910 Test Plan: tested a large image {F192585} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4910, T5874 Differential Revision: https://secure.phabricator.com/D10296
2014-08-19 23:46:37 +02:00
'phabricator-textareautils' => '5c93c52c',
Don't revert Conpherence page titles when updating notifications Summary: Fixes T7709. `JX.Title` deals with adding `(1)`, etc., counts, so send updates through it. Test Plan: Clicked between some threads in Conpherence, no title flickering. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7709 Differential Revision: https://secure.phabricator.com/D12260
2015-04-02 22:41:48 +02:00
'phabricator-title' => 'df5e11d2',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'phabricator-tooltip' => '1d298e3a',
Clean up FontAwesome / Timeline CSS Summary: Normalize FA CSS, expand timeline icons to 14px, fix mobile browsers, give attribution in uiexamples Test Plan: tested iOS simulator, chrome, ie Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8845
2014-04-23 03:29:14 +02:00
'phabricator-ui-example-css' => '528b19de',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-uiexample-javelin-view' => 'd4a14807',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'phabricator-uiexample-reactor-button' => 'd19198c8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'phabricator-uiexample-reactor-checkbox' => '519705ea',
'phabricator-uiexample-reactor-focus' => '40a6a403',
'phabricator-uiexample-reactor-input' => '886fd850',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'phabricator-uiexample-reactor-mouseover' => '47c794d8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'phabricator-uiexample-reactor-radio' => '988040b4',
'phabricator-uiexample-reactor-select' => 'a155550f',
'phabricator-uiexample-reactor-sendclass' => '1def2711',
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
Move setup warning callout above the nav-drag div Summary: See {T7830} Test Plan: I manually set this to `5` in Chrome inspector and checked a few pages. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12481
2015-04-20 19:52:51 +02:00
'phabricator-zindex-css' => '5a2b9d9d',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phame-css' => '88bd4705',
Update Pholio to use pink instead of indigo Summary: We recently shipping a more color correct version of Indigo, which means Pholio should use Pink for highlights. Test Plan: Review Pholio Comments, Hovers. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D10732
2014-10-21 19:06:10 +02:00
'pholio-css' => '95174bdd',
Make Pholio work a little better on mobile Summary: Ref T2644. This adjusts thumb sizing so the "X" button is visible, and hides the uploader on devices for now. The thumb stuff I'm sort of hacking (we'll cut off a little bit of wide thumbs on the iPhone), but it looks fine, is usable, and works a little better in landscape mode and at tablet sizes. Test Plan: {F167022} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2644 Differential Revision: https://secure.phabricator.com/D9562
2014-06-16 00:00:43 +02:00
'pholio-edit-css' => '3ad9d1ee',
Add spacing under Pholio Inline Comments Summary: Adds a bit of space Test Plan: View 2 or more inline comments on same transaction. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9712
2014-06-25 00:23:57 +02:00
'pholio-inline-comments-css' => '8e545e49',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phortune-credit-card-form' => '2290aeef',
Make it easier to add payment methods for subscription autopay Summary: Fixes T7424. Ref T6308. Currently, there's no option to just add a card directly from the autopay UI. Add a button so this works. Also, chip away at T6308 a bit. This isn't perfect but looks a little less out of place. Test Plan: {F327637} - Added a payment method, then set it as autopay. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6308, T7424 Differential Revision: https://secure.phabricator.com/D11935
2015-03-02 22:01:08 +01:00
'phortune-credit-card-form-css' => '8391eb02',
Make Phortune checkout UI a little less bad Summary: Ref T2787. There were some mega-uggo buttons and such; reduce the uggo-ness by a hair. Test Plan: {F179686} Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10006
2014-07-23 19:36:37 +02:00
'phortune-css' => '9149f103',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'phrequent-css' => 'ffc185ad',
Leafy vegetables
2015-02-27 21:04:41 +01:00
'phriction-document-css' => '0d16bc9a',
Make default and hidden columns in Workboards more clear Summary: Fixes T6469. Changes the default icon into text instead. Added the text to hidden boards and now display when reordering as well. Test Plan: Moved a bunch of columns, tested reordering. Seems more clear. {F229626} {F229627} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6469 Differential Revision: https://secure.phabricator.com/D10784
2014-11-04 20:11:15 +01:00
'phui-action-header-view-css' => '89c497e7',
Correct logic in PHUIActionPanelView Summary: We should only be adding space then a status is set, not a state. Test Plan: Test on UIExamples, still renders as expected. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11844
2015-02-21 15:38:27 +01:00
'phui-action-panel-css' => '3ee9afd5',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'phui-box-css' => '7b3a2eed',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'phui-button-css' => 'f780e520',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'phui-calendar-css' => '8675968e',
Calendar upgrades Summary: Does a handful of things to make Calendar significantly more useful - Enabled overlapping events - Profile has a 'week view' of the user - Profile has a 'month view' of the users - Multiple users on a calendar are color coded - Browse view slightly more useful This stops short of implementing the new 'home' view on Calendar, mostly this is a big step though to make that happen next. Test Plan: Make lots of events on diffent users. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T2897, T4375 Differential Revision: https://secure.phabricator.com/D8317
2014-02-24 19:04:23 +01:00
'phui-calendar-day-css' => 'de035c8a',
'phui-calendar-list-css' => 'c1d0ca59',
Fixing z-index on calendar date badges. Summary: Fixes T4787, decreased z-index on calendar badges so that they don't sit on top of notification dropdowns when dropdowns are expanded. Not sure why the badges had z-index 10, but please let me know if there was a more substantial reason for this. Test Plan: If neither notification dropdowns have content, create enough messages to populate at least 5 rows, open calendar, expand messages dropdown, verify that underlying calendar date badges do not appear over the dropdown. Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4787 Differential Revision: https://secure.phabricator.com/D8770
2014-04-13 17:18:16 +02:00
'phui-calendar-month-css' => 'a92e47d2',
Clean up mobile crumbs with multiple levels Summary: Before the redesign, these levels were hidden. This recreates that behavior. Test Plan: Test nested Phriction pages {F281114} {F281115} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11621
2015-02-02 19:34:42 +01:00
'phui-crumbs-view-css' => '594d719e',
Move ToC in Phriction to it's own column Summary: Adds additional CSS to make the Table of Contents into it's own column (if one exists). Test Plan: Tested a page with and without a table of contents. Tested tablet, mobile, and desktop breakpoints. Tested Conpherence, scrolling seemed fine still on trackpad and mouse. {F370973} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12417
2015-04-15 01:02:30 +02:00
'phui-document-view-css' => '94d5dcd8',
Remove 1x AppIcons, use FontIcons instead Summary: Removes the 1x application icons, and uses the fonticons instead. Feed was only known location. Test Plan: feed, dashboards, grep for use {F275636} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11496
2015-01-25 23:14:41 +01:00
'phui-feed-story-css' => 'c9f3a0b5',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'phui-font-icon-base-css' => '3dad2ae3',
Modernize file storage engine selection Summary: Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend. This mechanism predates widespread use of `PhutilSymbolLoader` to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined). Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the `Selector`, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods). Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster. This uses D12051 to add UI to make it easier to understand the state of storage engines. Test Plan: Used new UI panel to assess storage engines: {F336270} - Uploaded a small file, saw it go to MySQL engine. - Uploaded a larger file, saw it go to S3 engine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5843 Differential Revision: https://secure.phabricator.com/D12053
2015-03-12 21:28:53 +01:00
'phui-fontkit-css' => '1fa79503',
Make base font a Celerity CSS variable Summary: For consistency, we switch back to base font in a few places when using alternate fonts like source-sans or monospace, this makes sure the base font is consistently reset. Test Plan: Review a Document, a Diff, and a Legalpad form Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11891
2015-02-26 18:26:36 +01:00
'phui-form-css' => 'f535f938',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'phui-form-view-css' => 'b147d2ed',
Normalize ActionList dropdowns Summary: Normalizes the display of the ActionList menu on mobile and tablet, shifts them to being actual menu dropdowns instead of an inline list. Test Plan: Verify DocumentView, Profiles, and Tasks all display the Action Menu in an identical way. {F368091} {F368092} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12373
2015-04-12 22:29:27 +02:00
'phui-header-view-css' => 'da4586b1',
Standardize spacing when icons have text Summary: Our standard icon -> button spacing is 4px, not 8px. Test Plan: Review search icon in Conpherence Full Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12365
2015-04-12 06:25:36 +02:00
'phui-icon-view-css' => 'bc766998',
CSS polish, Pholio Summary: Minor things - Fades out comment icon on hover - Adds hover to inline comment images - moves mask position to just the image, and not the transparent border Test Plan: Tested all of these items on various mocks Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9631
2014-06-19 20:28:01 +02:00
'phui-image-mask-css' => '5a8b09c8',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phui-info-panel-css' => '27ea50a1',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'phui-info-view-css' => 'c6f0aef8',
Track ghostly inlines across file moves Summary: Ref T7447. Ref T7870. - Forward: When rendering some file "B" which was moved from "A", port ghosts for both "A" and "B" to it. - Backward: When porting a comment on "X" which was moved from some "Y", allow it to port to a file named "Y" if it can't find a file named "X". Test Plan: Before: {F377809} After: {F377806} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7447, T7870 Differential Revision: https://secure.phabricator.com/D12493
2015-04-21 17:26:00 +02:00
'phui-inline-comment-view-css' => '7adedadb',
Conpherence - Implement edit rules for rooms Summary: Fixes T7586. If you can't edit a room, the pertinent UI is greyed out. One exception is the title of the room in the full viewer; this crumb is not disabled as it would be hard to read. Otherwise though, everything is disabled nicely. Test Plan: tried to add participants when I wasn't allowed to and got an error. added participants otherwise okay. tried to edit title when i wasn't allowed and got an error. otherwise okay. left conpherence threads / rooms successfully. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7586 Differential Revision: https://secure.phabricator.com/D12161
2015-03-25 19:48:22 +01:00
'phui-list-view-css' => '2e25ebfb',
Normalize ActionList dropdowns Summary: Normalizes the display of the ActionList menu on mobile and tablet, shifts them to being actual menu dropdowns instead of an inline list. Test Plan: Verify DocumentView, Profiles, and Tasks all display the Action Menu in an identical way. {F368091} {F368092} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12373
2015-04-12 22:29:27 +02:00
'phui-object-box-css' => '7d160002',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phui-object-item-list-view-css' => '9db65899',
Move base drop shadow into CelerityResourceTransformer Summary: Simplifies some common CSS rules. Test Plan: Test some dialogs and menus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12406
2015-04-14 18:48:59 +02:00
'phui-pinboard-view-css' => 'eaab2b1b',
Fix clone input on device breakpoints in Diffusion Summary: The float wasn't getting reset on the definition list, so clone URI (so important on mobile!) looked terrible. Test Plan: Tested Diffusion, Herald, and Maniphest property lists. Seems good. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12331
2015-04-08 19:12:31 +02:00
'phui-property-list-view-css' => '5b671934',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
Remove negative margin in phui-status Summary: Fixes T6334, the negative margin is no longer needed to align tables. Test Plan: review table item alignment in commit message Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6334 Differential Revision: https://secure.phabricator.com/D10716
2014-10-16 22:12:03 +02:00
'phui-status-list-view-css' => '888cedb8',
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'phui-tag-view-css' => '402691cc',
Add Pink, correct Indigo in base colors Summary: Fixes T6307 Test Plan: Test UIExamples Color Pallete and Icon samples. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6307 Differential Revision: https://secure.phabricator.com/D10707
2014-10-15 19:33:26 +02:00
'phui-text-css' => 'cf019f54',
Automatically make timeline + objectbox sit flush Summary: Right now you have to know to setFlush on an ObjectBox preceding a timeline, we can make that automatic with CSS. Test Plan: Test some Diffusion commit pages, boxes now site flush under timeline. Check Maniphest and Differential, no changes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11617
2015-02-02 18:40:46 +01:00
'phui-timeline-view-css' => 'b0fbc4d7',
Move setup issue callout to under the header Summary: Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans. Test Plan: Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc. {F375821} {F375822} {F375823} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7830 Differential Revision: https://secure.phabricator.com/D12466
2015-04-19 16:15:59 +02:00
'phui-workboard-view-css' => '3279cbbf',
Minor indentation fixes Summary: Some CSS files are indented inconsistently, with a single space instead of two. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley, chad Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11061
2014-12-30 11:48:53 +01:00
'phui-workpanel-view-css' => 'e495a5cc',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'phuix-action-list-view' => 'b5c256b8',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'phuix-action-view' => '8cf6d262',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'phuix-dropdown-menu' => 'bd4c8dca',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'policy-css' => '957ea14c',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'policy-edit-css' => '815c66f7',
Notifications - add a "Clear All Notifications" link to dropdown Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links? Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2576 Differential Revision: https://secure.phabricator.com/D8894
2014-04-29 19:43:38 +02:00
'policy-transaction-detail-css' => '82100a43',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'ponder-comment-table-css' => '6cdccea7',
'ponder-feed-view-css' => 'e62615b6',
Update Conpherence CSS to handle multiple edits better Summary: Fixes T7655. We'll set tighter spacing around edit clusters. Also darkened up the date marker and remove unused `phabricator-transaction-view` CSS that was still scattered around the site. Test Plan: Test a full and column multi-edit spam. Visited Ponder and Diffusion, noticed no issues using those apps. Grepped for other users of `phabricator-transaction-view` Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Maniphest Tasks: T7655 Differential Revision: https://secure.phabricator.com/D12148
2015-03-26 20:56:58 +01:00
'ponder-post-css' => '9d415218',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'ponder-vote-css' => '8ed6ed8b',
Dashboard CSS updates Summary: Updates ObjectList dashboarda and tweaks minor css items elsewhere. Test Plan: Test my dashboard, editing, and standalone Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9275
2014-05-24 06:48:15 +02:00
'project-icon-css' => 'c2ecb7f1',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'raphael-core' => '51ee6b43',
'raphael-g' => '40dde778',
'raphael-g-line' => '40da039e',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'releeph-core' => '9b3c5733',
Remove ReleephProjectController Summary: Ref T3657. General changes here: - Removes `ReleephProjectController`, which is the source of T3657. - Mostly moves requests from "RQ" as a monogram to "Y" (looks like a merge, mnemonic for "yank"?, we don't have too many characters left). This should be essentially only cosmetic. This reduces ambiguity with "rQ" and "R123", which are current and future repository monograms. This will continue in the next few diffs. - Makes requests implement policies correctly. Test Plan: Created, edited, browsed requests. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3657 Differential Revision: https://secure.phabricator.com/D8766
2014-04-14 21:06:56 +02:00
'releeph-preview-branch' => 'b7a6f4a5',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'releeph-request-differential-create-dialog' => '8d8b92cd',
'releeph-request-typeahead-css' => '667a48ae',
ConfigIssueView minor tweaks Summary: Minor, adds border, reduces greys, etc. Test Plan: View a number of config issues, see new colors. {F282035} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11650
2015-02-03 18:07:00 +01:00
'setup-issue-css' => '22270af2',
Move ActionHeaders to PHUI, add ObjectBox Support, new Colors Summary: Moves PhabricatorActionHeaderView to PHUIActionHeaderView, adds Red, Green, and Violet colors and extend ObjectBox to take colors and action headers. Test Plan: Tested new Welcome layout as well as UIExamples, Workboards, and Hovercards {F169669} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9707
2014-06-24 18:39:32 +02:00
'sprite-gradient-css' => '4bdb98a7',
Fixed MediaWiki logo in login sprite sheets. Summary: I've been advised that that the MediaWiki flower needs to appear with the square brackets for proper MediaWiki trademark presentation. See https://phabricator.wikimedia.org/T543 for relevant discussion. Test Plan: view login page with MediaWiki oauth plugin enabled, see that the logo includes square brackets around the flower Reviewers: epriestley, qgil, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: Korvin, epriestley Projects: #auth, #wikimedia Differential Revision: https://secure.phabricator.com/D10752
2014-10-29 23:06:15 +01:00
'sprite-login-css' => 'a355d921',
Add "Blindigo" header color Summary: Adds a new header color. Test Plan: Select new header color, see new header color. {F326502} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11918
2015-03-01 21:03:02 +01:00
'sprite-main-header-css' => '28d01b0b',
Increase height of logo Summary: This increases the transparent space around the Phabricator logo. The logo itself is the same size. This allows for adding of other logos more easily without needing to alter the space provided. (Like Phacility) Test Plan: Reload page, screenshot logo, pull into Photoshop and verify spacing top and bottom. {F309985} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11828
2015-02-19 23:43:33 +01:00
'sprite-menu-css' => '9ef76324',
Rename group to users in project icons Summary: Fixes T6972. Test Plan: Set icon to typeahead icon in edit project image Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6972 Differential Revision: https://secure.phabricator.com/D11391
2015-01-14 19:49:36 +01:00
'sprite-projects-css' => 'b0d9e24f',
Mail icon for email lists in typeahead Summary: Adds a mail icon to use in the typeahead Also, can we add a special class per obj-type? (May want to special color projects, etc) Will try to live without them. Test Plan: photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8259
2014-02-17 19:06:16 +01:00
'sprite-tokens-css' => '1706b943',
Apple remarkup-code padding to child spans as well. Summary: Fixes T6440. The issue is when a nested span appears, we don't apply the spacing. Test Plan: Test a new diff in my sandbox that exhibits the issue. Ensure spacing now aligns. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6440 Differential Revision: https://secure.phabricator.com/D10768
2014-10-31 18:45:11 +01:00
'syntax-highlighting-css' => '56c1ba38',
Make tokens more accessible to assitive technologies Summary: Ref T4843. - The token award buttons are just icons. - The tokens themselves are just icons. - Also spread the tokens out a tiny bit, they feel a little tight to me right now. Test Plan: Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4843 Differential Revision: https://secure.phabricator.com/D8982
2014-05-05 19:54:34 +02:00
'tokens-css' => '3d0f239e',
Tweak browse-more CSS Summary: Just adds some space, color. Test Plan: test a long browse list Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12471
2015-04-20 19:19:39 +02:00
'typeahead-browse-css' => 'd8581d2c',
Basic style for exception page Summary: Fixes T6846, cleans up spacing, makes it look scary red. Test Plan: Fake an exception, see new layout Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6846 Differential Revision: https://secure.phabricator.com/D11161
2015-01-02 22:48:18 +01:00
'unhandled-exception-css' => '37d4f9a2',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'requires' => array(
'029a133d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'aphront-dialog-view-css',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'05270951' => array(
'javelin-util',
'javelin-magical-init',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'065227cc' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'077a1dab' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'javelin-behavior-device',
'javelin-history',
'javelin-vector',
'javelin-scrollbar',
'phabricator-title',
'phabricator-shaped-request',
'conpherence-thread-manager',
),
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'07de8873' => array(
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-dom',
'javelin-uri',
'phabricator-file-upload',
),
Quicksand - remove code not ready for production re: dark console Summary: goofed and slipped this into D12499 as I was working on T7700 too. Test Plan: noted console.log output not there Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12513
2015-04-23 02:12:58 +02:00
'08883e8b' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-util',
'javelin-dom',
'javelin-request',
'phabricator-keyboard-shortcut',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0a3f3021' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'javelin-router',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Conpherence - improve stack re: non-update updates Summary: Fixes T7761. Fixes T7318. When we send an empty message to the server, pretend its just a request to load the page. Make load a bit smarter such that if we don't get back any transactions, rather than error like the fool, just send down to the client the notion of a 'non_update'. Instrument the client to just turn off the appropriate loading state, etc for a non update. T7318 is a tricky beast since we don't know exactly how to reproduce it but if / when it occurs again it would be some other bizarre application behavior maybe? We won't be getting the execption anymore, that's for sure. Test Plan: removed code in `ConpherenceThreadManager.sendMessage` that protects against sending empty messages. sent empty messages (non updates) like whoa and everything worked on both durable column and main column view. re-added the code in `ConpherenceThreadManager.sendMessage` and noted empty messages did not send while any text including a space sent up nicely Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7318, T7761 Differential Revision: https://secure.phabricator.com/D12339
2015-04-10 00:07:12 +02:00
'0a5192c4' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-workflow',
'javelin-router',
'javelin-behavior-device',
'javelin-vector',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0c6946e7' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
'phabricator-notification-css',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0ec56e1d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phuix-dropdown-menu',
Move general workboard actions to "Manage Board" dropdown Summary: See D9719. Test Plan: - Used hide/show columns. - Used "add column". - Filtered board. {F170133} Reviewers: chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D9726
2014-06-25 21:30:53 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0f764c35' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'13c739ea' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'javelin-uri',
'phabricator-textareautils',
),
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'1499a8cb' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-history',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'14a827de' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-json',
'phabricator-draggable-list',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'14d7a8b8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-dom',
'javelin-magical-init',
'javelin-vector',
'javelin-request',
'javelin-util',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'1ad0a787' => array(
Fix variable reference Summary: What do you think this is, PHP? Test Plan: Eyeball it. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11361
2015-01-13 21:03:48 +01:00
'javelin-install',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactor',
'javelin-util',
'javelin-reactor-node-calmer',
Fix variable reference Summary: What do you think this is, PHP? Test Plan: Eyeball it. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11361
2015-01-13 21:03:48 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'1ae869f2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'phabricator-keyboard-shortcut-manager',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'1d298e3a' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-vector',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'1def2711' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Substantially support character encodings and "Highlight As" in changesets Summary: Ref T5179. Ref T4045. Ref T832. We can now write non-utf8 hunks into the database, so try to do more reasonable things with them in the UI. Test Plan: (See screenshots...) Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T832, T4045, T5179 Differential Revision: https://secure.phabricator.com/D9294
2014-06-20 20:49:41 +02:00
),
Make "Show Context" persist rendering, whitespace, encoding, etc Summary: Ref T2009. Currently, we do not persist view parameters when making context rendering requests. The big one is the renderer (1up vs 2up). This makes context on unified diffs come in with too many columns. However, it impacts other parameters too. For example, at HEAD, if you change highlighting to "rainbow" and then load more context, the context uses the original highlighter instead of the rainbow highlighter. This moves context loads into ChangesetViewManager, which maintains view parameters and can provide them correctly. - This removes "ref"; it is no longer required, as the ChangesetViewManager tracks it. - This removes URI management from `behavior-show-more`; it is no longer required, since the ChangesetViewManager knows how to render. - This removes "whitespace" since this is handled properly by the view manager. Test Plan: - Used "Show Top" / "Show All" / "Show Bottom" in 1-up and 2-up views. - Changed file highlighting to rainbow, loaded stuff, saw rainbow stick. - Used "Show Entire File" in 1-up and 2-up views. - Saw loading chrome. - No loading chrome normally. - Made inlines, verified `copyRows()` code runs. - Poked around Diffusion -- it is missing some parameter handling, but works OK. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11977
2015-03-05 23:03:00 +01:00
'2035b9cb' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'phabricator-phtize',
'changeset-view-manager',
),
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'21ba5861' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-stratcom',
'conpherence-thread-manager',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'2290aeef' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-json',
'javelin-workflow',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Touch up PHP/JS interactions for inline comments Summary: Ref T1460. Overall: - Pass `objectOwnerPHID` consistently. - Pass viewer consistently. - Set the correct draft state for checkboxes on the client. Test Plan: - Made inline comments in Differential. - Made inline comments in Diffusion. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12186
2015-03-28 01:08:31 +01:00
'2529c82d' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-request',
'javelin-workflow',
),
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'2818f5ce' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-typeahead-normalizer',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'2926fff2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'29274e2b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'2b228192' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-json',
Vegetables have vitamins.
2014-05-12 20:53:31 +02:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'2b8de964' => array(
'javelin-install',
'javelin-util',
),
Fix tabs losing scroll position Summary: we were missing an e.kill(). Fixes T5754. Test Plan: looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved! Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5754 Differential Revision: https://secure.phabricator.com/D10111
2014-08-01 21:29:48 +02:00
'2bfa2836' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'2c426492' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-keyboard-shortcut',
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'2caa8fb8' => array(
Make scroll keys active immediately upon page load Summary: When JX.Scrollbar activates, the page needs to be clicked before scrolling keys work. Instead, set focus into the content after we set the page frame (if something else isn't already focused). Also fixes T7042. Test Plan: In Safari, Chrome and Firefox, scrolling with key commands is now immediately active. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7042 Differential Revision: https://secure.phabricator.com/D11508
2015-01-26 18:34:57 +01:00
'javelin-install',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-event',
Make scroll keys active immediately upon page load Summary: When JX.Scrollbar activates, the page needs to be clicked before scrolling keys work. Instead, set focus into the content after we set the page frame (if something else isn't already focused). Also fixes T7042. Test Plan: In Safari, Chrome and Firefox, scrolling with key commands is now immediately active. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7042 Differential Revision: https://secure.phabricator.com/D11508
2015-01-26 18:34:57 +01:00
),
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'30a6303c' => array(
'javelin-install',
'javelin-util',
'javelin-websocket',
'javelin-leader',
'javelin-json',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'316b8fa1' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-typeahead-source',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Fix an undefined variable Summary: Identifed by linting with JSHint. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11433
2015-01-22 21:22:26 +01:00
'331b1611' => array(
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'3ab51e2c' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-magical-init',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'3cb0b2fc' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'javelin-uri',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'3ee3408b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'phabricator-tooltip',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'3f5d6dbf' => array(
'javelin-behavior',
'javelin-dom',
'phortune-credit-card-form',
),
Quicksand - make things work correctly with global drag and drop upload Summary: Fixes T7685. This required making the global drag and drop behavior able to "uninstall" itself so to speak, and then it re-installs it self as necessary. Test Plan: Did the following all successfully - uploaded a file to homepage - homepage -> differential -- no way to upload via drag and drop - homepage -> differential -> homepage -- uploaded a file - homepage -> differential -> browser back button to homepage -- uploaded a file Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7685 Differential Revision: https://secure.phabricator.com/D12534
2015-04-24 00:08:35 +02:00
'3f6075ff' => array(
'javelin-behavior',
'javelin-dom',
'javelin-uri',
'javelin-mask',
'phabricator-drag-and-drop-file-upload',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'40a6a403' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Make query panels editable by normal humans Summary: Ref T4986. Instead of requiring you to know engine class names and copy/paste URLs, provide select dropdowns that use SCARY JAVASCRIPT to do magical things. I think this is mostly reasonable, the only issue is that it's hard to create a panel out of a completely ad-hoc query (you'd have to save it, then create a panel out of the saved query, then remove the saved query). Once we develop T5307 we can do a better job of this. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T4986 Differential Revision: https://secure.phabricator.com/D9572
2014-06-16 21:27:12 +02:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
42126667 => array(
'javelin-behavior',
'javelin-dom',
'javelin-request',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'44168bad' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'phabricator-prefab',
Hide tooltips on any keypress Summary: Fixes T4586, where a keystroke like "return" to submit a form could remove DOM nodes rendering a tooltip, leaving the user with a permanent phantom tooltip. (@spicyj, if you come up with anything better than this feel free to send a followup, but I //think// this is a reasonable fix.) A nice side effect of this is that it hides any tooltips obscuring a text input when you start typing. Test Plan: Hovered over a tooltip, pressed a key, tip vanished. Reviewers: spicyj, btrahan Reviewed By: btrahan Subscribers: aran, spicyj, epriestley Maniphest Tasks: T4586 Differential Revision: https://secure.phabricator.com/D8497
2014-03-12 19:29:48 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'44959b73' => array(
'javelin-util',
'javelin-uri',
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'453c5375' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'469c0d9e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-workflow',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'477359c8' => array(
'javelin-install',
'javelin-dom',
'phabricator-notification',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
47830651 => array(
'javelin-behavior',
'javelin-dom',
'javelin-view-renderer',
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'47c794d8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
48086888 => array(
'javelin-behavior',
'javelin-dom',
'javelin-workflow',
),
Include object url in object selector selection Summary: Fixes T6452, provides actual href instead of just # Test Plan: Control click and open link in new window, is correct task. Click and see item added to selection list. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6452 Differential Revision: https://secure.phabricator.com/D10774
2014-11-03 17:20:15 +01:00
'49b73b36' => array(
'javelin-behavior',
'javelin-dom',
'javelin-request',
'javelin-util',
),
Modernize file storage engine selection Summary: Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend. This mechanism predates widespread use of `PhutilSymbolLoader` to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined). Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the `Selector`, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods). Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster. This uses D12051 to add UI to make it easier to understand the state of storage engines. Test Plan: Used new UI panel to assess storage engines: {F336270} - Uploaded a small file, saw it go to MySQL engine. - Uploaded a larger file, saw it go to S3 engine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5843 Differential Revision: https://secure.phabricator.com/D12053
2015-03-12 21:28:53 +01:00
'4a2430d7' => array(
'phui-fontkit-css',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4d94d9c3' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phuix-dropdown-menu',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4e3e79a6' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4e9b766b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4fdb476d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'503e17fd' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-typeahead-source',
'javelin-util',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Quicksand - make notification and message counts update as you navigate around Summary: Ref T7573. Unify code to fetch these counts and do some light formatting since we're going to need to do the same thing for some conpherence-specific ajax in the durable column (See T7708). Test Plan: loaded up two tabs, one with a durable column on and one without. in the without browser, i read some messages, decrementing my unread count. when i navigated again in the durable column browser, the count updated correctly. with no notifications, commented on a task with another user to get a notification and it showed up properly. visited the task by clicking not the notification and the bubble count decremented correctly Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7573 Differential Revision: https://secure.phabricator.com/D12498
2015-04-22 00:46:36 +02:00
'517545ab' => array(
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'519705ea' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'54b612ba' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-color',
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'54f314a0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-typeahead-source',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'558829c2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-stratcom',
'javelin-behavior',
'javelin-vector',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Don't highlight very large files by default Summary: Ref T5644. See some discussion in D8040. When a file is very large (more than 64KB of text), don't activate syntax highlighting by default. This should prevent us from wasting resources running `pygmentize` on enormous files. Users who want the file highlighted can still select "Highlight As...". The tricky part of this diff is separating the headers into "changeset" headers and "undershield" (rendering) headers. Specifically, a file might have these headers/shields: - "This file is newly added." - "This file is generated. Show Changes" - "Highlighting is disabled for this large file." In this case, I want the user to see "added" and "generated" when they load the page, and only see "highlighting disabled" after they click "Show Changes". So there are several categories: - "Changeset" headers, which discuss the changeset as a whole (binary file, image file, moved, added, deleted, etc.) - "Property" headers, which describe metadata changes (not relevant here). - "Shields", which hide files from view by default. - "Undershield" headers, which provide rendering information that is only relevant if there is no shield on the file. Test Plan: - Viewed a diff with the library map, clicked "show changes", got a "highlighting disabled" header back with highlighting disabled. - Enabled highlighting explicitly (this currently restores the shield, which it probably shouldn't, but that feels out of scope for this change). The deshielded file is highlighted per the user's request. - Loaded context on normal files. Reviewers: btrahan Reviewed By: btrahan Subscribers: joshuaspence, epriestley Maniphest Tasks: T5644 Differential Revision: https://secure.phabricator.com/D12132
2014-06-29 21:07:46 +02:00
58562350 => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-workflow',
'javelin-router',
'javelin-behavior-device',
'javelin-vector',
),
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'59a7976a' => array(
'javelin-install',
'javelin-dom',
'javelin-fx',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'59b251eb' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Improve Conpherence column textarea JS behaviors Summary: - Don't show a loading state on the whole column while sending chat. We could show some kind of minor loading state, but standard JX.Busy stuff will kick in after a couple seconds anyway. - Blank the textarea immediately on submit so you can start typing more text. - Don't disable the form while submiting; disabling it prevents you from typing more text. - Hide the placeholder while the textarea is focused. If we don't do this, the placeholder reappearing after submitting text feels weird to me. Test Plan: - Sent a lot of text. - Real fast. - Focused and unfocused the area. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12086
2015-03-14 20:00:17 +01:00
'5b2e3e2b' => array(
'javelin-stratcom',
'javelin-request',
'javelin-dom',
'javelin-vector',
'javelin-install',
'javelin-util',
'javelin-mask',
'javelin-uri',
'javelin-routable',
),
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'5c54cbf3' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Clean up image file diffs UI Summary: Uses AphrontTable now, cleans up interactions. Fixes T5874, Fixes T4910 Test Plan: tested a large image {F192585} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4910, T5874 Differential Revision: https://secure.phabricator.com/D10296
2014-08-19 23:46:37 +02:00
'5c93c52c' => array(
'javelin-install',
'javelin-dom',
'javelin-vector',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'5e9f347c' => array(
'javelin-behavior',
'multirow-row-manager',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
'javelin-json',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'5fefb143' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-workflow',
'javelin-stratcom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
60479091 => array(
'phabricator-busy',
'javelin-behavior',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'60821bc7' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6153c708' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-workflow',
Move project icon editing into "Edit Details" Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead. Test Plan: {F170528} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5482 Differential Revision: https://secure.phabricator.com/D9743
2014-06-26 18:41:07 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'61cbc29a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-magical-init',
'javelin-util',
Make JX.Aphlict a real singleton with a more sensible initialization order Summary: Ref T5373. The control flow between `aphlict-listener` and `JX.Aphlict` is pretty weird right now, where the listener (which is the highest-level component) has intimate knowledge of how to put the SWF on the page. Instead: - Make `JX.Aphlict` a real singleton. - Instantiate it sooner. - Have it handle the flash setup handshake. Test Plan: Loaded page in debug mode, saw normal flow take place. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T5373 Differential Revision: https://secure.phabricator.com/D9699
2014-06-24 00:19:34 +02:00
),
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'62dfea03' => array(
'javelin-install',
'javelin-util',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'635de1ec' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
),
Quicksand - update title while navigating about Summary: Fixes T7744. Also fixes a bug where we were copying the response object erroneously; that's not necessary to move around since we cleanly initialize it for each load Test Plan: from user profile, clicked feed tab and saw new title. clicked calendar tab and saw new title. clicked back and saw feed title and page render. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7744 Differential Revision: https://secure.phabricator.com/D12487
2015-04-21 20:01:05 +02:00
'657c2b50' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-behavior-device',
'javelin-scrollbar',
'javelin-quicksand',
'phabricator-keyboard-shortcut',
'conpherence-thread-manager',
),
Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063
2014-12-30 11:51:31 +01:00
'6882e80a' => array(
'javelin-dom',
),
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'6920d200' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-typeahead',
'javelin-tokenizer',
'javelin-typeahead-preloaded-source',
'javelin-typeahead-ondemand-source',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'69adf288' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Internet Explorer compatibility fixes Summary: A few fixes for IE that makes this work in IE9+ and at least you can drag things and have it fail horribly in IE8 now. Ref T5023. - try / catch around getBoundingClientRect because IE throws if the object is not attached to the DOM. The correct value can be inferred in these cases as 0,0 - turns out IE has different values for button here (1,2,4) than other browsers. special case this by using the other IE fact that 'which' will be null Test Plan: dragged and dropped tasks successfully in IE9, IE10, and IE11 on Windows 7. dragged and dropped tasks unsuccessfully in IE8 on Windows 7 - they always "drop" to the 2nd position or so as I think the ondrag code isn't firing properly or something Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5023 Differential Revision: https://secure.phabricator.com/D9118
2014-05-14 17:53:11 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6c2b09a2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use dot notation in some places Summary: Use `x.y` in favor of `x['y']` in //some// JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick `PhabricatorJavelinLinter`. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11442
2015-01-28 21:42:05 +01:00
'6c53634d' => array(
'javelin-install',
'javelin-event',
'javelin-util',
'javelin-magical-init',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6d3e1947' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-diffusion-locate-file-source',
'javelin-dom',
'javelin-typeahead',
'javelin-uri',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Support HTML5 / Javascript chunked file uploads Summary: Ref T7149. This adds chunking support to drag-and-drop uploads. It never activates right now unless you hack things up, since the chunk engine is still hard-coded as disabled. The overall approach is the same as `arc upload` in D12061, with some slight changes to the API return values to avoid a few extra HTTP calls. Test Plan: - Enabled chunk engine. - Uploaded some READMEs in a bunch of tiny 32 byte chunks. - Worked out of the box in Safari, Chrome, Firefox. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7149 Differential Revision: https://secure.phabricator.com/D12066
2015-03-13 19:30:36 +01:00
'6d49590e' => array(
'javelin-behavior',
'javelin-dom',
'phabricator-drag-and-drop-file-upload',
'phabricator-textareautils',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6eff08aa' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-stratcom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'6f7962d5' => array(
'javelin-magical-init',
'javelin-install',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'70baed2f' => array(
'javelin-install',
'javelin-dom',
'javelin-vector',
'javelin-util',
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
'7319e029' => array(
'javelin-behavior',
'javelin-dom',
),
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'73d09eef' => array(
'javelin-behavior',
'javelin-vector',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'76b9fc3e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'76f4ebed' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactor',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7814b593' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-request',
'javelin-behavior',
'javelin-dom',
'javelin-router',
'javelin-util',
'phabricator-busy',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'7927a7d3' => array(
'javelin-behavior',
'javelin-quicksand',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7a68dda3' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'owners-path-editor',
'javelin-behavior',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7b98d7c5' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7cbe244b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-router',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7e41274a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7e8468ae' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-vector',
'javelin-request',
'javelin-uri',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7ebaeed3' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'herald-rule-editor',
'javelin-behavior',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7ee2b591' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-history',
Fix some issues where Conpherence would make to many draft requests Summary: A few minor fixes: - When we build a tag with `"meta" => null`, strip the attribute like we do for all other attributes. Previously, we would actually set the metadata to `null`. This happened with the Conpherence form. - Just respond to the draft request with an empty (but valid) response, instead of building a dialog. - `PhabricatorShapedRequest` is confusingly named and I should have caught this in review, but the basic shape of it is: - You make one object. - You call `trigger()` when stuff changes (e.g., a keystroke). - It manages making a small number of requests (e.g., one request after the user stops typing for a moment). - The way it was being used previously would incorrectly send a request for every keystroke. I think I'm going to simplify `ShapedRequest` and merge it into some larger queue for T430. Test Plan: Typed some text, no longer saw a flurry of requests. Reloaded page, still saw draft text. Reviewers: btrahan, chad Reviewed By: chad CC: aran, chad Differential Revision: https://secure.phabricator.com/D8380
2014-03-01 20:23:08 +01:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
82439934 => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
),
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'834a1173' => array(
'javelin-behavior',
'javelin-scrollbar',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'84845b5b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'85ea0626' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'8694b1df' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-tooltip',
'changeset-view-manager',
),
Give Phortune carts a proper `isInvoice` flag Summary: See some earlier discussion in D11593: > One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client. > We might need an `isInvoice` flag eventually, but `subscriptionPHID` is a reasonable stand-in for now. This adds such a flag. Test Plan: - Generated an ad-hoc invoice and verified it showed up in the right place. - Used `bin/phortune invoice` to invoice a subscription and verified it worked correctly. - Paid an invoice and saw it leave "pending invoices" status. {F377029} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12480
2015-04-20 19:05:44 +02:00
'86a13f7f' => array(
'aphront-typeahead-control-css',
'phui-tag-view-css',
),
Add JX.Leader: synchronization over localStorage Summary: Ref T6559. Adds a "JX.Leader" primitive to replace the synchronization over Flash. This does a couple of things: - Offers an "onBecomeLeader" event, which we can use to open the WebSocket. - Offers an "onReceiveMessage" event, which we can use to dispatch notifications and handle requests to play sounds and send desktop notifications. - Offers a "broadcast()" method, which we can use to send desktop notification and sound requests. Test Plan: Added some code like this: ``` if (!statics.leader) { statics.leader = true; JX.Leader.listen('onBecomeLeader', function() { JX.log("This tab is now the leader."); }); JX.Leader.listen('onReceiveBroadcast', function(message, is_leader) { JX.log('[' + (is_leader ? 'As Leader' : 'Not Leader') + '] ' + message); }); JX.Leader.start(); } ``` Then: - Saw first tab open become leader reliably in Safari, Chrome, Firefox. - Saw new tab become leader reliably when the first tab was closed. - Saw broadcast() work as documented and deliver messages with correct leadership-flag and uniqueness. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6559 Differential Revision: https://secure.phabricator.com/D11235
2015-01-07 02:50:40 +01:00
'87cb6b51' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'88236f00' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'phabricator-keyboard-shortcut',
'javelin-stratcom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'886fd850' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactor-dom',
'javelin-view-html',
'javelin-view-interpreter',
'javelin-view-renderer',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'887ad43f' => array(
'javelin-behavior',
'javelin-request',
'javelin-stratcom',
'javelin-dom',
),
Fix Maniphest Reports scrolling issues Summary: Fixes T7099, also picked some new colors. Raphael can bind the graph to a dom element, which resolved the scrolling issue. Test Plan: Tested scrolling on my laptop, desktop. Seems resolved. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Maniphest Tasks: T7099 Differential Revision: https://secure.phabricator.com/D11879
2015-02-24 18:41:37 +01:00
'88f0c5b3' => array(
'javelin-behavior',
'javelin-dom',
'javelin-vector',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'8a41885b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'8b3fd187' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-typeahead-source',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'8ce821c5' => array(
'phabricator-notification',
'javelin-stratcom',
'javelin-behavior',
),
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'8cf6d262' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
),
When deleting inline comments, offer "undo" instead of prompting Summary: Ref T2009. Ref T1460. Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete". Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure. Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes. Test Plan: - Deleted and undid deletion of inlines from main view and preview. - Clicked "View" on inlines. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6464, T4999, T2618, T1460, T2009 Differential Revision: https://secure.phabricator.com/D12032
2015-03-10 01:27:51 +01:00
'8e1389b5' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-request',
'javelin-util',
'phabricator-shaped-request',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'8ef9ab58' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
CSS polish, Pholio Summary: Minor things - Fades out comment icon on hover - Adds hover to inline comment images - moves mask position to just the image, and not the transparent border Test Plan: Tested all of these items on various mocks Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9631
2014-06-19 20:28:01 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'8fc1c918' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-uri',
'phabricator-notification',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Make taller tables the default for AphrontTableView Summary: I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh. Test Plan: Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12328
2015-04-08 17:38:15 +02:00
'9007c197' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'9229e764' => array(
'multirow-row-manager',
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-stratcom',
'javelin-json',
'phabricator-prefab',
),
Conpherence - get #anchor links to messages working Summary: Ref T7757. Oddities include: - not working in column view, since the generic anchor technology conflicts once you navigate to a page with a transaction timeline view - not working if you are linking to a message not included in initial load Remaining work is addressing these oddities. - make column view timestamp link to full conpherence correctly? - make back end load from hyperlinked transaction forward? or do it more like application transactions and have the client keep requesting stuff until it gets it? Open to suggestions! :D Test Plan: played around in conpherence full and stuff looked okay. noted no changes as intended in column view. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7757 Differential Revision: https://secure.phabricator.com/D12402
2015-04-14 00:24:48 +02:00
93568464 => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'phabricator-notification',
'javelin-behavior-device',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'conpherence-thread-manager',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'93d0c9e3' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'9414ff18' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-resource',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'949c0fe5' => array(
'javelin-install',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'94b750d2' => array(
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
'javelin-install',
'javelin-stratcom',
'javelin-util',
'javelin-behavior',
'javelin-json',
'javelin-dom',
'javelin-resource',
'javelin-routable',
),
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'988040b4' => array(
'javelin-install',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-dom',
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'javelin-reactor-dom',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'9c2623f4' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-workflow',
'phabricator-phtize',
'phabricator-drag-and-drop-file-upload',
'phabricator-draggable-list',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'9f36c42d' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'9f7309fb' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-request',
'phabricator-shaped-request',
Remove ajaxey comment magic in Pholio, and also some bugs Summary: Fixes T5424. - One concrete issue: drafts were not being cleared properly because `__draft__` was not set on submission. This (mostly) fixes phantom drafts. - This ajax comment magic feels weird and floaty and generally has problems. For example, if you add subscribers or inlines, all the stuff on the page which represents those won't update automatically. Instead, just reload. Maybe we'll ajax this stuff some day, but it feels like a net negative for now. - Also remove it from other applications where it's currently used. - Fix an issue with inline previews. Test Plan: Made some comments on a mock, everything worked normally like I expected it to. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5424 Differential Revision: https://secure.phabricator.com/D9649
2014-06-21 21:50:40 +02:00
),
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'a0b57eb8' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'phabricator-keyboard-shortcut',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a155550f' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Fix three issues with scrolling while dragging items (e.g., on workboards) Summary: Fixes T5979. There are three issues here: - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls. - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list. - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this. Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5979 Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 23:20:27 +02:00
'a16ec1c6' => array(
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
'javelin-vector',
'javelin-magical-init',
),
Improve column device behaviors Summary: Fixes T7062. When the column is open, we only want to consider the screen width which is avilable for content when computing responsive breakpoints. Specificially, if you have a 1000px wide browser window (normally "desktop") but the column is open (300px) so you only have 700px free for content (normally "tablet"), we should drop to the tablet breakpoint. This lets you have a narrow column of "tablet" content next to the chat column, instead of a really squished column of "desktop" contnet. This also means the chat column can't directly use JX.Device to hide itself. Test Plan: Resized screen with column open, saw content go from Desktop + Column -> Tablet + Column -> Tablet -> Mobile. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7062 Differential Revision: https://secure.phabricator.com/D12189
2015-03-28 14:54:23 +01:00
'a205cf28' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a80d0378' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a8d8459d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a8da01f0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-uri',
'phabricator-keyboard-shortcut',
Remove application small/hidden tiles Summary: Ref T5176. This paves the way for the redesign by making the homepage editor thing a little more manageable/coherent. Not perfect, but we can clean it up a bit after the new design. Test Plan: Home page: {F162093} New "Pinned Applications" settings panel (this supports drag-and-drop to reorder): {F162094} Pin an app: {F162095} Unpin an app: {F162096} Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5176 Differential Revision: https://secure.phabricator.com/D9332
2014-05-29 23:20:16 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a9f88de2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-fx',
'javelin-util',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'aa1733d0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'multirow-row-manager',
'javelin-install',
'path-typeahead',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Support tokenizer functions in Diffusion Summary: Ref T4100. Ref T5595. Support tokenizer functions + edgelogic for repositories. Test Plan: Searched for repositories. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5595, T4100 Differential Revision: https://secure.phabricator.com/D12533
2015-04-23 17:25:17 +02:00
'ab5f468d' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
),
Quicksand - make page object notifications work properly with quicksand Summary: Fixes T7680. Make it so the listen behavior can be initialized multiple times from the server by having the behavior only update a few static data variables on subsequent initializations. Test Plan: visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. Reloaded and navigated to /maniphest/ with user A and had user B leave another comment on TX - no "reload" bubble and correct "TX updated" bubble. Navigated to TX again with user A and had user B leave a comment and got the "reload" and "TX updated" bubbles. visited TX with user A and left a comment with user B and got the "reload" and "TX updated" bubbles. navigated away with user A and the "reload" bubble was automagically closed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7680 Differential Revision: https://secure.phabricator.com/D12448
2015-04-21 01:43:32 +02:00
'b1a59974' => array(
'javelin-behavior',
'javelin-aphlict',
'javelin-stratcom',
'javelin-request',
'javelin-uri',
'javelin-dom',
'javelin-json',
'javelin-router',
'javelin-util',
'javelin-leader',
'javelin-sound',
'phabricator-notification',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b1f0ccee' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b2b4fbaf' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-uri',
'javelin-request',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b3a4b884' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'phabricator-prefab',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b3e7d692' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b42eddc7' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-typeahead-preloaded-source',
'javelin-util',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b5c256b8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
),
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'b5d57730' => array(
'javelin-install',
'javelin-stratcom',
'javelin-dom',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'bba9eedf' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'bd4c8dca' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-vector',
'javelin-stratcom',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'bdaf4d04' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'be807912' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-shaped-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Conpherence - implement join / view rules for rooms Summary: Ref T7585. This implements everything specified, with a few caveats - since rooms you have yet to join can't be viewed in the column yet, the column view has some bugs and isn't expected to work. - the room you're looking at is just pre-pending to the top of the "recent" list Test Plan: made a room that no one could join. verified when viewing that there was no comment ui. made a room that others could join. verified folks who had yet to join had a "join" button with an area for text. tried joining with / without message text and it worked in both cases Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7585 Differential Revision: https://secure.phabricator.com/D12149
2015-03-25 02:38:16 +01:00
'c1700f6f' => array(
'javelin-install',
'javelin-util',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
),
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'c5172d25' => array(
'javelin-behavior',
'javelin-typeahead-ondemand-source',
'javelin-typeahead',
'javelin-dom',
'javelin-uri',
'javelin-util',
'javelin-stratcom',
'phabricator-prefab',
),
Modernize DatePicker Summary: Fixes T5893. Uses more standard colors / spacing / shadows / icons. Test Plan: pick dates {F191310} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5893 Differential Revision: https://secure.phabricator.com/D10285
2014-08-16 23:55:22 +02:00
'c51ae228' => array(
'javelin-behavior',
'javelin-util',
'javelin-dom',
'javelin-stratcom',
'javelin-vector',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'c90a04fc' => array(
'javelin-dom',
'javelin-dynval',
'javelin-reactor',
'javelin-reactornode',
'javelin-install',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'ca3f91eb' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-phtize',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd19198c8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-dynval',
'javelin-reactor-dom',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd254d646' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-util',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'd4505101' => array(
'javelin-stratcom',
'javelin-install',
'javelin-uri',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd4a14807' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-view',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd4eecc63' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd75709e6' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-workflow',
'javelin-json',
'javelin-dom',
'phabricator-keyboard-shortcut',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd835b03a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-shaped-request',
Workboards - make priority changes less aggressive and generally better Summary: Fixes T4641. Test Plan: Dragged a "normal" task between "high" and "low" tasks and it stayed as "normal". Generally seems correct when playing around. Reviewers: epriestley Reviewed By: epriestley Subscribers: mbishopim3, Beltran-rubo, epriestley, Korvin Maniphest Tasks: T4641 Differential Revision: https://secure.phabricator.com/D8622
2014-03-27 18:50:54 +01:00
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'dbbf48b6' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phabricator-busy',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'de2e896f' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-typeahead',
'javelin-typeahead-ondemand-source',
'javelin-dom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Don't revert Conpherence page titles when updating notifications Summary: Fixes T7709. `JX.Title` deals with adding `(1)`, etc., counts, so send updates through it. Test Plan: Clicked between some threads in Conpherence, no title flickering. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7709 Differential Revision: https://secure.phabricator.com/D12260
2015-04-02 22:41:48 +02:00
'df5e11d2' => array(
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e10f8e18' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'phabricator-prefab',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Likely fix for spooky scrollbar in Firefox Summary: Fixes T7690. Test Plan: This fix worked when I applied it in the DOM inspector. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7690 Differential Revision: https://secure.phabricator.com/D12211
2015-03-30 21:06:40 +02:00
'e19cfd6e' => array(
'phui-inline-comment-view-css',
),
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'e1d25dfb' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e1ff79b1' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'e292eaf4' => array(
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e32d14ab' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phabricator-phtize',
'phabricator-textareautils',
'javelin-workflow',
'javelin-vector',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e379b58e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-uri',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'e4cc26b3' => array(
'javelin-behavior',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e566f52c' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e5822781' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-json',
'javelin-workflow',
'javelin-magical-init',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'e58bf807' => array(
'javelin-behavior',
'javelin-util',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
'javelin-magical-init',
'javelin-request',
'javelin-history',
'javelin-workflow',
'javelin-mask',
'javelin-behavior-device',
'phabricator-keyboard-shortcut',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'e6e25838' => array(
'javelin-install',
),
Track a "Done" state on inline comments Summary: Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc. Specifically, these are the behaviors: - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider.."). - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff. - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold: - Be consistent with how inlines work. - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories. - The actual bit where done-ness publishes isn't implemented. - UI is bare bones. - No integration with the rest of the UI yet. Test Plan: Clicked some checkboxes. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: paulshen, chasemp, epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12033
2015-03-10 02:41:47 +01:00
'e723c323' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-util',
'javelin-vector',
'differential-inline-comment-editor',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e9581f08' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Conpherence - fix a typo Summary: this typo broke (at least) renaming the thread from the durable column. Test Plan: renamed a thread from durable column and it worked Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12104
2015-03-18 01:01:33 +01:00
'ea681761' => array(
'javelin-behavior',
'javelin-aphlict',
'phabricator-phtize',
'javelin-dom',
),
Clean up some Conpherence beahviors with a mouse Summary: Fixes T7825. If JX.Scrollbar activates, we sometimes target the wrong node. (We don't have this issue in the column because it rebuilds a new JX.Scrollbar every time.) Test Plan: - Sent messages, no spooky text. - Loaded page, got scroll to bottom. - Unplugged all USB devices, restarted browser, repeated. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7825 Differential Revision: https://secure.phabricator.com/D12413
2015-04-14 22:04:22 +02:00
'eaa5b321' => array(
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-vector',
),
Use a typeahead for "document types" in global search Summary: - Now that we have "browse", this is a much more reasonable control for random sets of things. - The new explicit search scope selector reduces the need to fiddle with this field manually, too. Test Plan: {F379292} {F379293} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12510
2015-04-23 00:25:34 +02:00
'ee37f73a' => array(
'javelin-behavior',
'javelin-request',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-uri',
'javelin-behavior-device',
'phabricator-title',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'efe49472' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f36e01af' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-vector',
'phabricator-hovercard',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f3fef818' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'javelin-workflow',
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'f5d1233b' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
'multirow-row-manager',
'javelin-json',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f6555212' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactornode',
'javelin-util',
'javelin-reactor',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f7379f45' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-shaped-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f7fc67ec' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-typeahead',
'javelin-dom',
'javelin-request',
'javelin-typeahead-ondemand-source',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f8248bc5' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-json',
'javelin-stratcom',
'phabricator-shaped-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'f829edb3' => array(
'javelin-view',
'javelin-install',
'javelin-dom',
),
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'f8ba29d7' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-mask',
'javelin-util',
'phabricator-busy',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f9539603' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-uri',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'fa0f4fc2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-vector',
'javelin-magical-init',
Despecialize status handling in Maniphest Reports Summary: Ref T1812. This is mega gross but Facts is too far away to do this right for now. Test Plan: bleh gross Looked at reports, saw same data as before. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1812 Differential Revision: https://secure.phabricator.com/D8580
2014-03-25 21:49:33 +01:00
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'fc91ab6c' => array(
'javelin-behavior',
'javelin-dom',
'phortune-credit-card-form',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'fe287620' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-view-visitor',
'javelin-util',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
),
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'packages' => array(
'core.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-core-css',
'phabricator-zindex-css',
'phui-button-css',
'phabricator-standard-page-view',
'aphront-dialog-view-css',
'phui-form-view-css',
'aphront-panel-view-css',
'aphront-table-view-css',
'aphront-tokenizer-control-css',
'aphront-typeahead-control-css',
'aphront-list-filter-view-css',
'phabricator-remarkup-css',
'syntax-highlighting-css',
'aphront-pager-view-css',
'aphront-tooltip-css',
'phabricator-flag-css',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phui-info-view-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'sprite-gradient-css',
'sprite-menu-css',
'phabricator-main-menu-view',
'phabricator-notification-css',
'phabricator-notification-menu-css',
'lightbox-attachment-css',
'phui-header-view-css',
'phabricator-filetree-view-css',
'phabricator-nav-view-css',
'phabricator-side-menu-view-css',
Move Conduit client construction logic into Repository Summary: Ref T7020. I need this elsewhere, and it's relatively internal anyway. Test Plan: Browsed around my local, cluster-configured install and saw everything working fine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7020 Differential Revision: https://secure.phabricator.com/D11474
2015-01-23 22:30:00 +01:00
'phui-crumbs-view-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phui-object-item-list-view-css',
'global-drag-and-drop-css',
'phui-spacing-css',
'phui-form-css',
'phui-icon-view-css',
'phabricator-application-launch-view-css',
'phabricator-action-list-view-css',
'phui-property-list-view-css',
'phui-tag-view-css',
'phui-list-view-css',
'font-fontawesome',
'phui-font-icon-base-css',
'sprite-main-header-css',
'phui-box-css',
'phui-object-box-css',
'phui-timeline-view-css',
'sprite-tokens-css',
'tokens-css',
'phui-status-list-view-css',
Rewrite Aphlict to use Websockets Summary: Fixes T6559. No more flash, use Websockets. This is less aggressive than the earlier version, and retains more server logic. - Support "wss". - Make the client work. - Remove "notification.user" entirely. - Seems ok? Test Plan: In Safari, Firefox and Chrome, saw the browsers connect. Made a bunch of comments/updates and saw notifications. Notable holes in the test plan: - Haven't tested "wss" yet. I'll do this on secure. - Notifications are //too fast// now, locally. I get them after I hit submit but before the page reloads. - There are probably some other rough edges, this is a fairly big patch. Reviewers: joshuaspence, btrahan Reviewed By: joshuaspence, btrahan Subscribers: fabe, btrahan, epriestley Maniphest Tasks: T6713, T6559 Differential Revision: https://secure.phabricator.com/D11143
2015-01-08 19:03:00 +01:00
'phui-feed-story-css',
'phabricator-feed-css',
'phabricator-dashboard-css',
'aphront-multi-column-view-css',
'phui-action-header-view-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'core.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-util',
'javelin-install',
'javelin-event',
'javelin-stratcom',
'javelin-behavior',
'javelin-resource',
'javelin-request',
'javelin-vector',
'javelin-dom',
'javelin-json',
'javelin-uri',
'javelin-workflow',
'javelin-mask',
'javelin-typeahead',
'javelin-typeahead-normalizer',
'javelin-typeahead-source',
'javelin-typeahead-preloaded-source',
'javelin-typeahead-ondemand-source',
'javelin-tokenizer',
'javelin-history',
'javelin-router',
'javelin-routable',
'javelin-behavior-aphront-basic-tokenizer',
'javelin-behavior-workflow',
'javelin-behavior-aphront-form-disable-on-submit',
'phabricator-keyboard-shortcut-manager',
'phabricator-keyboard-shortcut',
'javelin-behavior-phabricator-keyboard-shortcuts',
'javelin-behavior-refresh-csrf',
'javelin-behavior-phabricator-watch-anchor',
'javelin-behavior-phabricator-autofocus',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'phabricator-phtize',
'javelin-behavior-phabricator-oncopy',
'phabricator-tooltip',
'javelin-behavior-phabricator-tooltips',
'phabricator-prefab',
'javelin-behavior-device',
'javelin-behavior-toggle-class',
'javelin-behavior-lightbox-attachments',
'phabricator-busy',
'javelin-aphlict',
'phabricator-notification',
'javelin-behavior-aphlict-listen',
'javelin-behavior-phabricator-search-typeahead',
'javelin-behavior-aphlict-dropdown',
'javelin-behavior-history-install',
'javelin-behavior-phabricator-gesture',
'javelin-behavior-phabricator-active-nav',
'javelin-behavior-phabricator-nav',
'javelin-behavior-phabricator-remarkup-assist',
'phabricator-textareautils',
'phabricator-file-upload',
'javelin-behavior-global-drag-and-drop',
'javelin-behavior-phabricator-reveal-content',
'phabricator-hovercard',
'javelin-behavior-phabricator-hovercards',
'javelin-color',
'javelin-fx',
'phabricator-draggable-list',
'javelin-behavior-phabricator-transaction-list',
Transactions - kill the old "show all" code pathways Summary: we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite... Test Plan: viewed a task with a lot of transactions. clicked "show older" and it worked! Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4712 Differential Revision: https://secure.phabricator.com/D10926
2014-12-04 23:55:18 +01:00
'javelin-behavior-phabricator-show-older-transactions',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-phui-timeline-dropdown-menu',
'javelin-behavior-doorkeeper-tag',
Rewrite Aphlict to use Websockets Summary: Fixes T6559. No more flash, use Websockets. This is less aggressive than the earlier version, and retains more server logic. - Support "wss". - Make the client work. - Remove "notification.user" entirely. - Seems ok? Test Plan: In Safari, Firefox and Chrome, saw the browsers connect. Made a bunch of comments/updates and saw notifications. Notable holes in the test plan: - Haven't tested "wss" yet. I'll do this on secure. - Notifications are //too fast// now, locally. I get them after I hit submit but before the page reloads. - There are probably some other rough edges, this is a fairly big patch. Reviewers: joshuaspence, btrahan Reviewed By: joshuaspence, btrahan Subscribers: fabe, btrahan, epriestley Maniphest Tasks: T6713, T6559 Differential Revision: https://secure.phabricator.com/D11143
2015-01-08 19:03:00 +01:00
'phabricator-title',
'javelin-leader',
'javelin-websocket',
'javelin-behavior-dashboard-async-panel',
'javelin-behavior-dashboard-tab-panel',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'darkconsole.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-dark-console',
'javelin-behavior-error-log',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'differential.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'differential-core-view-css',
'differential-changeset-view-css',
'differential-results-table-css',
'differential-revision-history-css',
'differential-revision-list-css',
'differential-table-of-contents-css',
'differential-revision-comment-css',
'differential-revision-add-comment-css',
'phabricator-object-selector-css',
'phabricator-content-source-view-css',
'inline-comment-summary-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'differential.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-drag-and-drop-file-upload',
'phabricator-shaped-request',
'javelin-behavior-differential-feedback-preview',
'javelin-behavior-differential-edit-inline-comments',
'javelin-behavior-differential-populate',
'javelin-behavior-differential-diff-radios',
'javelin-behavior-differential-comment-jump',
'javelin-behavior-differential-add-reviewers-and-ccs',
'javelin-behavior-differential-keyboard-navigation',
'javelin-behavior-aphront-drag-and-drop-textarea',
'javelin-behavior-phabricator-object-selector',
'javelin-behavior-repository-crossreference',
'javelin-behavior-load-blame',
'differential-inline-comment-editor',
'javelin-behavior-differential-dropdown-menus',
'javelin-behavior-differential-toggle-files',
'javelin-behavior-differential-user-select',
'javelin-behavior-aphront-more',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'diffusion.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'diffusion-icons-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'diffusion.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-diffusion-pull-lastmodified',
'javelin-behavior-diffusion-commit-graph',
'javelin-behavior-audit-preview',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'maniphest.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'maniphest-task-summary-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'maniphest.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-maniphest-batch-selector',
'javelin-behavior-maniphest-transaction-controls',
'javelin-behavior-maniphest-transaction-preview',
'javelin-behavior-maniphest-transaction-expand',
'javelin-behavior-maniphest-subpriority-editor',
'javelin-behavior-maniphest-list-editor',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
),
);
Copy permalink