2011-03-08 23:29:02 +01:00
|
|
|
<?php
|
|
|
|
|
2012-03-13 19:18:11 +01:00
|
|
|
final class DiffusionGitRequest extends DiffusionRequest {
|
2011-03-08 23:29:02 +01:00
|
|
|
|
Fix many encoding and architecture problems in Diffusion request and URI handling
Summary:
Diffusion request/uri handling is currently a big, hastily ported mess. In particular, it has:
- Tons and tons of duplicated code.
- Bugs with handling unusual branch and file names.
- An excessively large (and yet insufficiently expressive) API on DiffusionRequest, including a nonsensical concrete base class.
- Other tools were doing hacky things like passing ":" branch names.
This diff attempts to fix these issues.
- Make the base class abstract (it was concrete ONLY for "/diffusion/").
- Move all URI generation to DiffusionRequest. Make the core static. Add unit tests.
- Delete the 300 copies of URI generation code throughout Diffusion.
- Move all URI parsing to DiffusionRequest. Make the core static. Add unit tests.
- Add an appropriate static initializer for other callers.
- Convert all code calling `newFromAphrontRequestDictionary` outside of Diffusion to the new `newFromDictionary` API.
- Refactor static initializers to be sensibly-sized.
- Refactor derived DiffusionRequest classes to remove duplicated code.
- Properly encode branch names (fixes branches with "/", see <https://github.com/facebook/phabricator/issues/100>).
- Properly encode path names (fixes issues in D1742).
- Properly escape delimiter characters ";" and "$" in path names so files like "$100" are not interpreted as "line 100".
- Fix a couple warnings.
- Fix a couple lint issues.
- Fix a bug where we would not parse filenames with spaces in them correctly in the Git browse query.
- Fix a bug where Git change queries would fail unnecessarily.
- Provide or improve some documentation.
This thing is pretty gigantic but also kind of hard to split up. If it's unreasonably difficult to review, let me know and I can take a stab at it though.
This supplants D1742.
Test Plan:
- Used home, repository, branch, browse, change, history, diff (ajax), lastmodified (ajax) views of Diffusion.
- Used Owners typeaheads and search.
- Used diffusion.getrecentcommitsbypath method.
- Pushed a change to an absurdly-named file on an absurdly-named branch, everything worked properly.
{F9185}
Reviewers: nh, vrana, btrahan
Reviewed By: btrahan
CC: aran, epriestley
Differential Revision: https://secure.phabricator.com/D1921
2012-03-20 03:52:14 +01:00
|
|
|
protected function getSupportsBranches() {
|
|
|
|
return true;
|
|
|
|
}
|
2011-03-08 23:29:02 +01:00
|
|
|
|
2014-05-13 22:52:48 +02:00
|
|
|
protected function isStableCommit($symbol) {
|
|
|
|
return preg_match('/^[a-f0-9]{40}\z/', $symbol);
|
2011-03-08 23:29:02 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getBranch() {
|
|
|
|
if ($this->branch) {
|
|
|
|
return $this->branch;
|
|
|
|
}
|
|
|
|
if ($this->repository) {
|
2012-05-20 23:50:43 +02:00
|
|
|
return $this->repository->getDefaultBranch();
|
2011-03-08 23:29:02 +01:00
|
|
|
}
|
|
|
|
throw new Exception("Unable to determine branch!");
|
|
|
|
}
|
|
|
|
|
2013-11-06 00:09:08 +01:00
|
|
|
protected function getResolvableBranchName($branch) {
|
2013-10-30 21:06:03 +01:00
|
|
|
if ($this->repository->isWorkingCopyBare()) {
|
2013-11-06 00:09:08 +01:00
|
|
|
return $branch;
|
2013-10-30 21:06:03 +01:00
|
|
|
} else {
|
2014-01-18 01:10:56 +01:00
|
|
|
$remote = DiffusionGitBranch::DEFAULT_GIT_REMOTE;
|
2013-11-06 00:09:08 +01:00
|
|
|
return $remote.'/'.$branch;
|
2013-10-30 21:06:03 +01:00
|
|
|
}
|
2011-03-08 23:29:02 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|