1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 20:40:56 +01:00

Add "final" to more classes

Summary: No big surprises here, delted the unused "DarkConsole" class.

Test Plan: Ran 'testEverythingImplemented' to verify I wasn't finalizing anything we extend.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1876
This commit is contained in:
epriestley 2012-03-13 11:18:11 -07:00
parent 49366559af
commit 11cccb98c2
126 changed files with 222 additions and 229 deletions

View file

@ -169,7 +169,6 @@ phutil_register_library_map(array(
'ConduitAPI_user_info_Method' => 'applications/conduit/method/user/info',
'ConduitAPI_user_whoami_Method' => 'applications/conduit/method/user/whoami',
'ConduitException' => 'applications/conduit/protocol/exception',
'DarkConsole' => 'aphront/console/api',
'DarkConsoleConfigPlugin' => 'aphront/console/plugin/config',
'DarkConsoleController' => 'aphront/console/controller',
'DarkConsoleCore' => 'aphront/console/core',

View file

@ -1,24 +0,0 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/**
* @group console
*/
class DarkConsole {
}

View file

@ -1,10 +0,0 @@
<?php
/**
* This file is automatically generated. Lint this module to rebuild it.
* @generated
*/
phutil_require_source('DarkConsole.php');

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleConfigPlugin extends DarkConsolePlugin {
final class DarkConsoleConfigPlugin extends DarkConsolePlugin {
public function getName() {
return 'Config';

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
public function getName() {
$count = count($this->getData());

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleErrorLogPluginAPI {
final class DarkConsoleErrorLogPluginAPI {
private static $errors = array();

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleEventPlugin extends DarkConsolePlugin {
final class DarkConsoleEventPlugin extends DarkConsolePlugin {
public function getName() {
return 'Events';

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleEventPluginAPI extends PhutilEventListener {
final class DarkConsoleEventPluginAPI extends PhutilEventListener {
private static $events = array();
private static $discardMode = false;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleRequestPlugin extends DarkConsolePlugin {
final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
public function getName() {
return 'Request';

View file

@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleServicesPlugin extends DarkConsolePlugin {
final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
protected $observations;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group console
*/
class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
protected $xhprofID;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License.
*/
class AphrontException extends Exception {
abstract class AphrontException extends Exception {
}

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License.
*/
class AphrontCSRFException extends AphrontException {
final class AphrontCSRFException extends AphrontException {
}

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,10 @@
* limitations under the License.
*/
class AphrontRedirectException extends AphrontException {
/**
* TODO: Remove this entirely? We have no callsites.
*/
final class AphrontRedirectException extends AphrontException {
private $uri;

View file

@ -22,7 +22,7 @@
*
* @group aphront
*/
class AphrontRequest {
final class AphrontRequest {
const TYPE_AJAX = '__ajax__';
const TYPE_FORM = '__form__';

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class AphrontRequestTestCase extends PhabricatorTestCase {
final class AphrontRequestTestCase extends PhabricatorTestCase {
public function testRequestDataAccess() {
$r = new AphrontRequest('http://example.com/', '/');

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group aphront
*/
class Aphront304Response extends AphrontResponse {
final class Aphront304Response extends AphrontResponse {
public function getHTTPResponseCode() {
return 304;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group aphront
*/
class Aphront400Response extends AphrontResponse {
final class Aphront400Response extends AphrontResponse {
public function getHTTPResponseCode() {
return 400;

View file

@ -19,7 +19,7 @@
/**
* @group aphront
*/
class Aphront403Response extends AphrontWebpageResponse {
final class Aphront403Response extends AphrontWebpageResponse {
private $forbiddenText;
public function setForbiddenText($text) {

View file

@ -19,7 +19,7 @@
/**
* @group aphront
*/
class Aphront404Response extends AphrontWebpageResponse {
final class Aphront404Response extends AphrontWebpageResponse {
public function getHTTPResponseCode() {
return 404;

View file

@ -19,7 +19,7 @@
/**
* @group aphront
*/
class AphrontFileResponse extends AphrontResponse {
final class AphrontFileResponse extends AphrontResponse {
private $content;
private $mimeType;

View file

@ -19,7 +19,7 @@
/**
* @group aphront
*/
class AphrontPlainTextResponse extends AphrontResponse {
final class AphrontPlainTextResponse extends AphrontResponse {
public function setContent($content) {
$this->content = $content;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -17,6 +17,8 @@
*/
/**
* TODO: Should be final but isn't because of AphrontReloadResponse.
*
* @group aphront
*/
class AphrontRedirectResponse extends AphrontResponse {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -24,7 +24,7 @@
*
* @group aphront
*/
class AphrontReloadResponse extends AphrontRedirectResponse {
final class AphrontReloadResponse extends AphrontRedirectResponse {
public function getURI() {
if ($this->getRequest()->isAjax()) {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -17,6 +17,8 @@
*/
/**
* TODO: Should be final, but isn't because of Aphront403Response / 404Response.
*
* @group aphront
*/
class AphrontWebpageResponse extends AphrontResponse {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorAuditComment extends PhabricatorAuditDAO {
final class PhabricatorAuditComment extends PhabricatorAuditDAO {
protected $phid;
protected $actorPHID;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorOAuthProviderFacebook extends PhabricatorOAuthProvider {
final class PhabricatorOAuthProviderFacebook extends PhabricatorOAuthProvider {
private $userData;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorOAuthProviderGitHub extends PhabricatorOAuthProvider {
final class PhabricatorOAuthProviderGitHub extends PhabricatorOAuthProvider {
private $userData;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorOAuthProviderGoogle extends PhabricatorOAuthProvider {
final class PhabricatorOAuthProviderGoogle extends PhabricatorOAuthProvider {
private $userData;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorOAuthFailureView extends AphrontView {
final class PhabricatorOAuthFailureView extends AphrontView {
private $request;
private $provider;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_arcanist_projectinfo_Method
final class ConduitAPI_arcanist_projectinfo_Method
extends ConduitAPI_arcanist_Method {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod {
final class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
return false;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod {
final class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
return false;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod {
final class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
return false;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_daemon_launched_Method extends ConduitAPIMethod {
final class ConduitAPI_daemon_launched_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
// TODO: Lock this down once we build phantoms.

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_daemon_log_Method extends ConduitAPIMethod {
final class ConduitAPI_daemon_log_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
// TODO: Lock this down once we build phantoms.

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_createcomment_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_createcomment_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Add a comment to a Differential revision.";

View file

@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_creatediff_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_creatediff_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Create a new Differential diff.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_createrevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Create a new Differential revision.";

View file

@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_find_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_find_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Query Differential revisions which match certain criteria.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getalldiffs_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_getalldiffs_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Load all diffs for given revisions from Differential.";

View file

@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getcommitmessage_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_getcommitmessage_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Retrieve Differential commit messages or message templates.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getcommitpaths_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_getcommitpaths_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Query which paths should be included when committing a ".

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getdiff_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_getdiff_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Load the content of a diff from Differential.";

View file

@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getrevision_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_getrevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Load the content of a revision from Differential.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getrevisioncomments_Method
final class ConduitAPI_differential_getrevisioncomments_Method
extends ConduitAPIMethod {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_getrevisionfeedback_Method
final class ConduitAPI_differential_getrevisionfeedback_Method
extends ConduitAPIMethod {
public function getMethodDescription() {

View file

@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_markcommitted_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_markcommitted_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Mark Differential revisions as committed.";

View file

@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_parsecommitmessage_Method
final class ConduitAPI_differential_parsecommitmessage_Method
extends ConduitAPIMethod {
public function getMethodDescription() {

View file

@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_query_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_query_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Query Differential revisions which match certain criteria.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_setdiffproperty_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_setdiffproperty_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Attach properties to Differential diffs.";

View file

@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_updaterevision_Method extends ConduitAPIMethod {
final class ConduitAPI_differential_updaterevision_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Update a Differential revision.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_differential_updatetaskrevisionassoc_Method
final class ConduitAPI_differential_updatetaskrevisionassoc_Method
extends ConduitAPIMethod {
public function getMethodDescription() {

View file

@ -19,8 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_differential_updateunitresults_Method
extends ConduitAPIMethod {
final class ConduitAPI_differential_updateunitresults_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Update arc unit results for a postponed test.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_diffusion_findsymbols_Method extends ConduitAPIMethod {
final class ConduitAPI_diffusion_findsymbols_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Retrieve Diffusion symbol information.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_diffusion_getcommits_Method extends ConduitAPIMethod {
final class ConduitAPI_diffusion_getcommits_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Retrieve Diffusion commit information.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_diffusion_getrecentcommitsbypath_Method
final class ConduitAPI_diffusion_getrecentcommitsbypath_Method
extends ConduitAPIMethod {
const RESULT_LIMIT = 10;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_feed_publish_Method extends ConduitAPIMethod {
final class ConduitAPI_feed_publish_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "(UNSTABLE!!!) Publish a story to the feed.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,8 @@
/**
* @group conduit
*/
class ConduitAPI_file_download_Method extends ConduitAPIMethod {
final class ConduitAPI_file_download_Method
extends ConduitAPIMethod {
public function getMethodDescription() {
return "Download a file from the server.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_file_info_Method extends ConduitAPIMethod {
final class ConduitAPI_file_info_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Get information about a file.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_file_upload_Method extends ConduitAPIMethod {
final class ConduitAPI_file_upload_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Upload a file to the server.";

View file

@ -19,7 +19,7 @@
/**
* @group maniphest
*/
class ConduitAPI_maniphest_gettasktransactions_Method
final class ConduitAPI_maniphest_gettasktransactions_Method
extends ConduitAPI_maniphest_Method {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method {
final class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() {
return 'Create a new paste.';

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method {
final class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() {
return "Retrieve an array of information about a paste.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_path_getowners_Method extends ConduitAPIMethod {
final class ConduitAPI_path_getowners_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Find the Owners package that contains a given path.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_phriction_edit_Method
final class ConduitAPI_phriction_edit_Method
extends ConduitAPI_phriction_Method {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_phriction_history_Method
final class ConduitAPI_phriction_history_Method
extends ConduitAPI_phriction_Method {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_phriction_info_Method
final class ConduitAPI_phriction_info_Method
extends ConduitAPI_phriction_Method {
public function getMethodDescription() {

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPI_slowvote_info_Method extends ConduitAPIMethod {
final class ConduitAPI_slowvote_info_Method extends ConduitAPIMethod {
public function getMethodDescription() {
return "Retrieve an array of information about a poll.";

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitException extends Exception {
final class ConduitException extends Exception {
private $errorDescription;

View file

@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPIRequest {
final class ConduitAPIRequest {
protected $params;
private $user;

View file

@ -19,7 +19,7 @@
/**
* @group conduit
*/
class ConduitAPIResponse {
final class ConduitAPIResponse {
private $result;
private $errorCode;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO {
final class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO {
protected $client;
protected $clientVersion;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/**
* @group conduit
*/
class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO {
final class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO {
protected $userPHID;
protected $token;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorTimer extends PhabricatorCountdownDAO {
final class PhabricatorTimer extends PhabricatorCountdownDAO {
protected $id;
protected $title;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialRevisionListData {
final class DifferentialRevisionListData {
const QUERY_OPEN_OWNED = 'open';
const QUERY_OPEN_REVIEWER = 'reviewer';

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialCommentEditor {
final class DifferentialCommentEditor {
protected $revision;
protected $actorPHID;

View file

@ -21,7 +21,7 @@
* reviewers, diffs, and CCs. Unlike simple edits, these changes trigger
* complicated email workflows.
*/
class DifferentialRevisionEditor {
final class DifferentialRevisionEditor {
protected $revision;
protected $actorPHID;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,6 +16,6 @@
* limitations under the License.
*/
class DifferentialFieldValidationException extends Exception {
final class DifferentialFieldValidationException extends Exception {
}

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail {
final class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail {
protected function renderSubject() {
$revision = $this->getRevision();

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialCommentMail extends DifferentialMail {
final class DifferentialCommentMail extends DifferentialMail {
protected $changedByCommit;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialDiffContentMail extends DifferentialMail {
final class DifferentialDiffContentMail extends DifferentialMail {
protected $content;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialExceptionMail extends DifferentialMail {
final class DifferentialExceptionMail extends DifferentialMail {
public function __construct(
DifferentialRevision $revision,

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialNewDiffMail extends DifferentialReviewRequestMail {
final class DifferentialNewDiffMail extends DifferentialReviewRequestMail {
protected function renderSubject() {
$revision = $this->getRevision();

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialChangesetParser {
final class DifferentialChangesetParser {
protected $visible = array();
protected $new = array();

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialReplyHandler extends PhabricatorMailReplyHandler {
final class DifferentialReplyHandler extends PhabricatorMailReplyHandler {
private $receivedMail;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialChangeset extends DifferentialDAO {
final class DifferentialChangeset extends DifferentialDAO {
protected $diffID;
protected $oldFile;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialComment extends DifferentialDAO {
final class DifferentialComment extends DifferentialDAO {
const METADATA_ADDED_REVIEWERS = 'added-reviewers';
const METADATA_ADDED_CCS = 'added-ccs';

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialDiff extends DifferentialDAO {
final class DifferentialDiff extends DifferentialDAO {
protected $revisionID;
protected $authorPHID;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialDiffProperty extends DifferentialDAO {
final class DifferentialDiffProperty extends DifferentialDAO {
protected $diffID;
protected $name;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialHunk extends DifferentialDAO {
final class DifferentialHunk extends DifferentialDAO {
protected $changesetID;
protected $changes;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialInlineComment extends DifferentialDAO {
final class DifferentialInlineComment extends DifferentialDAO {
protected $revisionID;
protected $commentID;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialRevision extends DifferentialDAO {
final class DifferentialRevision extends DifferentialDAO {
protected $title;
protected $status;

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialChangesetDetailView extends AphrontView {
final class DifferentialChangesetDetailView extends AphrontView {
private $changeset;
private $buttons = array();

View file

@ -16,7 +16,7 @@
* limitations under the License.
*/
class DifferentialChangesetListView extends AphrontView {
final class DifferentialChangesetListView extends AphrontView {
private $changesets = array();
private $references = array();

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DiffusionPathChangeQuery {
final class DiffusionPathChangeQuery {
private $request;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,6 +16,10 @@
* limitations under the License.
*/
/**
* TODO: This might need to be concrete-extensible, but straighten out the
* class hierarchy here.
*/
class DiffusionRequest {
protected $callsign;

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DiffusionGitRequest extends DiffusionRequest {
final class DiffusionGitRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data);

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -18,7 +18,7 @@
// TODO: This has some minor code duplication vs the Git request that could be
// shared.
class DiffusionMercurialRequest extends DiffusionRequest {
final class DiffusionMercurialRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data);

View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License.
*/
class DiffusionSvnRequest extends DiffusionRequest {
final class DiffusionSvnRequest extends DiffusionRequest {
protected function initializeFromAphrontRequestDictionary(array $data) {
parent::initializeFromAphrontRequestDictionary($data);

Some files were not shown because too many files have changed in this diff Show more