revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 06:50:55 +01:00
Code Issues Releases Wiki Activity

Fix a phutil_json_decode call in CustomField PHID

Browse source 
Summary: I assume this is correct, it fixes my test case and was inconsistent with the rest of the file.

Test Plan: Add and Remove a CustomFieldPHID in Maniphest, no longer get errors.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8866

Differential Revision: https://secure.phabricator.com/D13642
This commit is contained in:
Chad Little 2015-07-16 21:02:01 -07:00
parent d082c33a5d
commit 039be71b87
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
View file

@ -118,7 +118,7 @@ abstract class PhabricatorStandardCustomFieldPHIDs
$old = array(); $old = array();
} }
$new = phutil_json_decode($xaction->getNewValue()); $new = json_decode($xaction->getNewValue());
if (!is_array($new)) { if (!is_array($new)) {
$new = array(); $new = array();
} }