Add assertions to no-assertions tests in phabricator/

Summary: Ref T4570. Add trivial assertions to tests which fail-by-exploding so we can fail tests with no assertions.

Test Plan: Ran `arc unit --everything` with Arcanist patched to fail with no assertions.

Reviewers: leebyron, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4570

Differential Revision: https://secure.phabricator.com/D8436

src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php

@@ -15,6 +15,8 @@ final class PhabricatorUserEditorTestCase extends PhabricatorTestCase {
     $this->registerUser(
       'PhabricatorUserEditorTestCaseOK',
       'PhabricatorUserEditorTestCase@example.com');
+
+    $this->assertEqual(true, true);
   }
 
   public function testRegistrationEmailInvalid() {

src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php

@@ -16,6 +16,7 @@ final class PhabricatorInfrastructureTestCase
    */
   public function testEverythingImplemented() {
     id(new PhutilSymbolLoader())->selectAndLoadSymbols();
+    $this->assertEqual(true, true);
   }
 
   public function testApplicationsInstalled() {

src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php

@@ -17,6 +17,8 @@ final class AphrontIsolatedDatabaseConnectionTestCase
     queryfx(
       $this->newIsolatedConnection(),
       'INSERT INVALID SYNTAX');
+
+    $this->assertEqual(true, true);
   }
 
   public function testInsertGeneratesID() {
@@ -39,6 +41,8 @@ final class AphrontIsolatedDatabaseConnectionTestCase
   public function testDeletePermitted() {
     $conn = $this->newIsolatedConnection();
     queryfx($conn, 'DELETE');
+
+    $this->assertEqual(true, true);
   }
 
   public function testTransactionStack() {

src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php

@@ -54,6 +54,7 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
       // Expected, pass.
     }
 
+    $this->assertEqual(true, true);
   }
 
   public function testMagicMethods() {