1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00

Add assertions to no-assertions tests in phabricator/

Summary: Ref T4570. Add trivial assertions to tests which fail-by-exploding so we can fail tests with no assertions.

Test Plan: Ran `arc unit --everything` with Arcanist patched to fail with no assertions.

Reviewers: leebyron, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4570

Differential Revision: https://secure.phabricator.com/D8436
This commit is contained in:
epriestley 2014-03-07 10:02:46 -08:00
parent 5e47f2a862
commit 0488ce73c4
4 changed files with 8 additions and 0 deletions

View file

@ -15,6 +15,8 @@ final class PhabricatorUserEditorTestCase extends PhabricatorTestCase {
$this->registerUser(
'PhabricatorUserEditorTestCaseOK',
'PhabricatorUserEditorTestCase@example.com');
$this->assertEqual(true, true);
}
public function testRegistrationEmailInvalid() {

View file

@ -16,6 +16,7 @@ final class PhabricatorInfrastructureTestCase
*/
public function testEverythingImplemented() {
id(new PhutilSymbolLoader())->selectAndLoadSymbols();
$this->assertEqual(true, true);
}
public function testApplicationsInstalled() {

View file

@ -17,6 +17,8 @@ final class AphrontIsolatedDatabaseConnectionTestCase
queryfx(
$this->newIsolatedConnection(),
'INSERT INVALID SYNTAX');
$this->assertEqual(true, true);
}
public function testInsertGeneratesID() {
@ -39,6 +41,8 @@ final class AphrontIsolatedDatabaseConnectionTestCase
public function testDeletePermitted() {
$conn = $this->newIsolatedConnection();
queryfx($conn, 'DELETE');
$this->assertEqual(true, true);
}
public function testTransactionStack() {

View file

@ -54,6 +54,7 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
// Expected, pass.
}
$this->assertEqual(true, true);
}
public function testMagicMethods() {