1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00

Add "M<digit>" and "P<digit>" to the default Remarkup ignore list

Summary: Ref T13575. Particularly with the new Apple silicon, I think there are enough domain collisions for `M1`, `M2`, `P1`, etc., to justify adding them to the default ignore list.

Test Plan: Created a mock, then wrote a comment referencing an object on the list (`M1`) and an object not on the list (`T1`). Got text and a link respectively.

Maniphest Tasks: T13575

Differential Revision: https://secure.phabricator.com/D21507
This commit is contained in:
epriestley 2021-01-11 10:47:48 -08:00
parent 18f049a282
commit 04c1f67a02

View file

@ -169,7 +169,21 @@ EOREMARKUP
'Maniphest. If you\'d prefer more traditional UI strings like '. 'Maniphest. If you\'d prefer more traditional UI strings like '.
'"Add Comment", you can set this flag to disable most of the '. '"Add Comment", you can set this flag to disable most of the '.
'extra flavor.')), 'extra flavor.')),
$this->newOption('remarkup.ignored-object-names', 'string', '/^(Q|V)\d$/') $this->newOption(
'remarkup.ignored-object-names',
'string',
// Q1, Q2, etc., are common abbreviations for "Quarter".
// V1, V2, etc., are common abbreviations for "Version".
// P1, P2, etc., are common abbreviations for "Priority".
// M1 is a computer chip manufactured by Apple.
// M2 (commonly spelled "M.2") is an expansion slot on motherboards.
// M4 is a carbine.
// M8 is a phonetic spelling of "mate", used in culturally significant
// copypasta about navy seals.
'/^(Q|V|M|P)\d$/')
->setSummary( ->setSummary(
pht('Text values that match this regex and are also object names '. pht('Text values that match this regex and are also object names '.
'will not be linked.')) 'will not be linked.'))